From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFE3EC4338F for ; Fri, 6 Aug 2021 12:21:08 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B22C26052B for ; Fri, 6 Aug 2021 12:21:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B22C26052B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C219B82DD3; Fri, 6 Aug 2021 14:21:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1628252465; bh=8Rx7ceaeAEDibpMnsmpUSuzWEkE1Sl4yOamf+yII2pA=; h=Subject:From:To:Cc:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=iQACsfv81uY5v5AEh32tMZEwQ2u5JvfV5aQ6Hn7CkC1STiTTlZrP750nVPDKeHr3t OVaHU+Ie41APLdVW1mU2uLqsAoTFuF8ua7AX73IMdVWNVrU0ENbw7vwn35YZL5sCB/ aSX6ZfJs5PMEAb0QicyTaSOfKvVhUCBvRhSHarZcz0N/lCAJ+2d8SVqIhelTFnv8Nc yVlBGj1vSeLqDeLYnFcQwvmZkJehv5UbhF1Z+n5N1Q095ONoHpgqpDOX0j3qUVVPuN SAVOW3Zx8XaVxMrOezScskxS5JdTjHt531C69RxxOyeIXba/I7cQqzAtP12g8/i+Kw wh6wvdH9T3Gkg== Received: from maia.denx.de (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: hws@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 5FEE782C8C; Fri, 6 Aug 2021 14:21:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1628252462; bh=8Rx7ceaeAEDibpMnsmpUSuzWEkE1Sl4yOamf+yII2pA=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=h0M/x7YrcI1mqlDEk4wv9gOLwhGBuchmnTLRy+Pv0iM1XP7hT+LhX0vuJPcdYms+5 HZ7SnZCErat3C5dEL0XwfLZG6I1T2R8BrO9kpb91S1KFn7VrS6f6zfIn9Rg52FoY4g BwWBvNOKThsgY1pz0n3pwTbEKiiunZl6mu6x6Y3DqEZFeqwq4t7n3Pv4epA6E7O9kE FQNZho3rJGOCU+i/bgjwwbbi3Q3BdM1Pb50arE/89vNgO0K9OJcY+APqQ1Haul6WFT mqHrPPCodbTvc6B3vQvc8rO3rJyYm0m5FUZzbyZQ5Dwk2X6SpQy9FatazCqJD0G3YV 0aSlcXPNcm6fA== Message-ID: <023dd4d80d17e2c3a3cf9eb2784d243d3a83c744.camel@denx.de> Subject: Re: [BISECTED] arm: dts: Resync BeagleBone device trees From: Harald Seiler To: Peter Robinson Cc: "Matwey V. Kornilov" , U-Boot Mailing List , paul.barker@sancloud.com, Tom Rini Date: Fri, 06 Aug 2021 14:21:01 +0200 In-Reply-To: References: <5739230aa8a33618d50645315c456669c41598d1.camel@denx.de> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.3 (3.40.3-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Fri, 2021-08-06 at 12:44 +0100, Peter Robinson wrote: > On Fri, Aug 6, 2021 at 12:39 PM Harald Seiler wrote: > > > > Hi, > > > > On Fri, 2021-08-06 at 13:54 +0300, Matwey V. Kornilov wrote: > > > Hello, > > > > > > I've found that the following commit breaks USB on BeagleBone Black > > > board (am335x based): > > > > > > commit 942853dd96df5de1c0a2a61c877c1cf1c24f1e91 > > > Author: Paul Barker > > > Date: Mon Jul 12 21:14:09 2021 +0100 > > > > > > arm: dts: Resync BeagleBone device trees > > > > > > > > > When commit is applied then I see the following: > > > > > > starting USB... > > > No working controllers found > > > USB is stopped. Please issue 'usb start' first. > > > starting USB... > > > No working controllers found > > > > > > Before the commit USB was working as expected: > > > > > > starting USB... > > > Bus usb@47401800: scanning bus usb@47401800 for devices... 1 USB Device(s) found > > > scanning usb for storage devices... 1 Storage Device(s) found > > > > > > Device 0: Vendor: Rev: PMAP Prod: USB DISK Pro > > > Type: Removable Hard Disk > > > Capacity: 7381.2 MB = 7.2 GB (15116736 x 512) > > > ... is now current device > > > > It looks the the arch/arm/dts/am33xx.dtsi file is out of sync with > > Linux, leading to this regression. In the current U-Boot version, it > > has > > > > status = "disabled"; > > > > lines for e.g. usb0 while in Linux mainline, those are missing. As the > > commit you found by bisecting drops the > > > > status = "okay"; > > > > lines from arch/arm/dts/am335x-bone-common.dtsi, the device now are no > > longer enabled. Maybe try syncing am33xx.dtsi as well to check if it > > helps? > > It's usual for peripheral devices to be disabled in the SoC .dtsi > file, those that are actively used by devices are supposed to enable > them in the device .dts so I would expect to see the appropriate bit > enabling it in the device .dts. True, but apparently this was changed for am33xx.dtsi, see Linux commit 0782e8572ce4 ("ARM: dts: Probe am335x musb with ti-sysc") [1]. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0782e8572ce43f521ed6ff15e4a7ab9aa5acdc85 -- Harald DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-62  Fax: +49-8142-66989-80   Email: hws@denx.de