From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00E67C77B7F for ; Wed, 3 May 2023 09:17:57 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EF45F84755; Wed, 3 May 2023 11:17:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1683105476; bh=jcWTT/qMQEeFo2zAWascrtocNPv6AH/Uv/BLZslwcK4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=eycTvuiWn1fMcPpWVR/NtVJo/wsO6z6J8s+SxPpKHvZ2GkQXjv8B9meMWctekns/t 14AJrlPFMAeTDn0lvetMkdvJLeMgao0qcz1fUNkzzXwGZHgWv9vUQ3Jorl9+iBBp2A QIuzmOe8kN/8aZ+UZbkZNCy6WB+WgNOs+d0LLdsoHzbU3GVwrVWRwNwq6LruDe6OQF YOsSwEXgKfw/gi92c4KjazfivFwpI+VreBqA2arAOffQ+lhlIZjd2jWbABNpokHNRR iev2UmcefCfvBpFCJ8xLAi0K97FwOOImdFQh8rk8TC26vMNIWpULWP8Dsgh6OGbaeC UbC6I16y3Pu0A== Received: by phobos.denx.de (Postfix, from userid 109) id 9390984756; Wed, 3 May 2023 11:17:54 +0200 (CEST) Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [80.241.59.207]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7AF8F84752 for ; Wed, 3 May 2023 11:17:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4QBBDt3hwrz9sZf; Wed, 3 May 2023 11:17:50 +0200 (CEST) Message-ID: <02b3ca4d-3dea-32ef-b8e6-80b0b16b2d7d@denx.de> Date: Wed, 3 May 2023 11:17:49 +0200 MIME-Version: 1.0 Subject: Re: [PATCH v2 u-boot-mvebu 4/4] arm: mvebu: clearfog: Update eMMC/SD/SATA instructions Content-Language: en-US To: =?UTF-8?Q?Pali_Roh=c3=a1r?= Cc: Martin Rowe , u-boot@lists.denx.de, Sergiu Moga , Tudor Ambarus , Eugen Hristev References: <20230413205750.10641-1-pali@kernel.org> <20230413205750.10641-5-pali@kernel.org> <20230426234423.gsitkyax7j3kqpac@pali> <5ea2f898-1c2c-ed2f-5f0f-d158d4fb61d0@denx.de> <20230429110821.ymsnnnjkw2zmpf43@pali> From: Stefan Roese In-Reply-To: <20230429110821.ymsnnnjkw2zmpf43@pali> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 4/29/23 13:08, Pali Rohár wrote: > On Thursday 27 April 2023 10:56:17 Stefan Roese wrote: >> Hi Pali, >> >> On 4/27/23 01:44, Pali Rohár wrote: >>> On Thursday 13 April 2023 22:43:25 Martin Rowe wrote: >>>> On Thu, 13 Apr 2023 at 20:58, Pali Rohár wrote: >>>>> >>>>> BootROM and neither SPL does not use eMMC boot acknowledgement or boot >>>>> enable bits in EXT_CSD_PART_CONF eMMC register. And also fixed SATA disk >>>>> sector 0x141 is not used at all. >>>>> >>>>> Signed-off-by: Pali Rohár >>>> >>>> SPL successfully loads u-boot from the same partition as SPL. SD card >>>> and UART continue to boot. >>>> >>>> Thanks Pali! >>>> >>>> Tested-by: Martin Rowe >>> >>> Ok, is something more needed for this patch series? >> >> Unfortunately yes. As at least this board breaks with this patchset >> added: >> >> $ make sama5d2_icp_mmc_defconfig >> $ make -sj >> /opt/kernel.org/gcc-12.2.0-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi-ld.bfd: >> u-boot-spl section `__u_boot_list' will not fit in region `.sram' >> /opt/kernel.org/gcc-12.2.0-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi-ld.bfd: >> region `.sram' overflowed by 32 bytes >> make[1]: *** [scripts/Makefile.spl:527: spl/u-boot-spl] Error 1 >> make: *** [Makefile:2049: spl/u-boot-spl] Error 2 >> >> So CI build fails and I can't send a pull request. I'm sending a patch >> though, to fix this image overflow by enabling LTO. Stay tuned... > > I see... LTO helped. So can be this patch series now applied? No problems with this series now in master, so: Applied to u-boot-marvell/master Thanks, Stefan >> Thanks, >> Stefan >> >>>>> --- >>>>> board/solidrun/clearfog/README | 20 ++++++++++---------- >>>>> 1 file changed, 10 insertions(+), 10 deletions(-) >>>>> >>>>> diff --git a/board/solidrun/clearfog/README b/board/solidrun/clearfog/README >>>>> index ed4a712c5aa2..c86b37061a30 100644 >>>>> --- a/board/solidrun/clearfog/README >>>>> +++ b/board/solidrun/clearfog/README >>>>> @@ -1,7 +1,7 @@ >>>>> Update from original Marvell U-Boot to mainline U-Boot: >>>>> ------------------------------------------------------- >>>>> >>>>> -Generate the U-Boot image with these commands: >>>>> +Generate the U-Boot image for eMMC/SD with these commands: >>>>> >>>>> $ make clearfog_defconfig >>>>> $ make >>>>> @@ -9,7 +9,7 @@ $ make >>>>> The resulting image including the SPL binary with the >>>>> full DDR setup is "u-boot-with-spl.kwb". >>>>> >>>>> -Now all you need to do is copy this image on a SD card. >>>>> +Now all you need to do is copy this image on a SD card's sector 1. >>>>> For example with this command: >>>>> >>>>> $ sudo dd if=u-boot-with-spl.kwb of=/dev/sdX bs=512 seek=1 >>>>> @@ -20,12 +20,6 @@ of "/dev/sdX" here! >>>>> Install U-Boot on eMMC: >>>>> ----------------------- >>>>> >>>>> -To make SPL load the main U-Boot image from the eMMC boot partition enable >>>>> -eMMC boot acknowledgement and boot partition with the following U-Boot >>>>> -command: >>>>> - >>>>> - mmc partconf 0 1 1 0 >>>>> - >>>>> Install U-Boot on eMMC boot partition from Linux running on Clearfog: >>>>> >>>>> echo 0 > /sys/block/mmcblk0boot0/force_ro >>>>> @@ -37,8 +31,14 @@ Consider initial boot from UART (see below). >>>>> Install U-Boot on SATA: >>>>> ----------------------- >>>>> >>>>> -When loading the main U-Boot image from raw SATA sector, set >>>>> -CONFIG_SPL_SATA_RAW_U_BOOT_SECTOR to 0x141. >>>>> +Generate the U-Boot image for SATA with these commands: >>>>> + >>>>> +$ make clearfog_sata_defconfig >>>>> +$ make >>>>> + >>>>> +Copy image on a SATA disk's sector 1: >>>>> + >>>>> +$ sudo dd if=u-boot-with-spl.kwb of=/dev/sdX bs=512 seek=1 >>>>> >>>>> Boot selection: >>>>> --------------- >>>>> -- >>>>> 2.20.1 >>>>> >> >> Viele Grüße, >> Stefan Roese >> >> -- >> DENX Software Engineering GmbH, Managing Director: Erika Unter >> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany >> Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de