From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2DD0BC433EF for ; Fri, 17 Dec 2021 07:28:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6A33F82FE7; Fri, 17 Dec 2021 08:28:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=walle.cc header.i=@walle.cc header.b="hh0Ho35n"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C114B8305D; Fri, 17 Dec 2021 08:28:42 +0100 (CET) Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D4A8381432 for ; Fri, 17 Dec 2021 08:28:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@walle.cc Received: from [127.0.0.1] (nyx.walle.cc [158.255.213.36]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 4CADE2222E; Fri, 17 Dec 2021 08:28:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1639726112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JrAZxHhS4vPOxcE4Gcd+2fpFfPA4YYW3nSLJ/Q1zY4E=; b=hh0Ho35nDmr27KEG3892up6Wi3T3G4PVrhbkcssj4l0hhtNRTxrJve5Hb1e6nXxSmw0a18 qFiRteE3c1T6H9VVBiUH8t5Xy3AY4wpCK6+dxBGtgYRtTkUA0LU0Bgix/iFPAGslMt3Y6b t1M7L6jEpL0SqQb6Gh0GY94Ugrgvxuc= Date: Fri, 17 Dec 2021 12:27:04 +0500 From: Michael Walle To: "Sahil Malhotra (OSS)" , ZHIZHIKIN Andrey CC: =?ISO-8859-1?Q?Cl=E9ment_Faure?= , Gaurav Jain , Pankaj Gupta , Priyanka Jain , "u-boot@lists.denx.de" , Varun Sethi , Ye Li Subject: RE: [PATCH 1/2] fsl-layerscape: add dtb overlay feature User-Agent: K-9 Mail for Android In-Reply-To: References: <20211117062347.24517-1-sahil.malhotra@oss.nxp.com> <20211117075314.3606691-1-michael@walle.cc> <21c98b3d9cead3f003718425d11137ec@walle.cc> Message-ID: <0881EC7E-715B-4A08-82AC-FFBD77292F0C@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Am 17=2E Dezember 2021 11:19:42 GMT+05:00 schrieb "Sahil Malhotra (OSS)" : >Hi Michael/Andrey > >Gentle reminder for comment on this patch series=2E > >Regards, >Sahil Malhotra > >> -----Original Message----- >> From: Sahil Malhotra (OSS) >> Sent: Friday, December 10, 2021 12:03 PM >> To: ZHIZHIKIN Andrey ; Sahil >> Malhotra (OSS) ; Michael Walle >> >> Cc: Cl=C3=A9ment Faure ; Gaurav Jain >> ; Pankaj Gupta ; Pri= yanka >> Jain ; u-boot@lists=2Edenx=2Ede; Varun Sethi >> ; Ye Li >> Subject: RE: [PATCH 1/2] fsl-layerscape: add dtb overlay feature >>=20 >> Hi Andrey, >>=20 >> > -----Original Message----- >> > From: ZHIZHIKIN Andrey >> > Sent: Wednesday, December 8, 2021 3:43 PM >> > To: Sahil Malhotra (OSS) ; Michael = Walle >> > >> > Cc: Cl=C3=A9ment Faure ; Gaurav Jain >> > ; Pankaj Gupta ; >> Priyanka >> > Jain ; u-boot@lists=2Edenx=2Ede; Varun Set= hi >> > ; Ye Li >> > Subject: RE: [PATCH 1/2] fsl-layerscape: add dtb overlay feature >> > >> > Hello Sahil, >> > >> > > -----Original Message----- >> > > From: Sahil Malhotra (OSS) >> > > Sent: Wednesday, December 8, 2021 7:12 AM >> > > To: Michael Walle ; Sahil Malhotra (OSS) >> > > >> > > Cc: Cl=C3=A9ment Faure ; Gaurav Jain >> > > ; Pankaj Gupta ; >> > Priyanka >> > > Jain ; u- boot@lists=2Edenx=2Ede; Varun = Sethi >> > > ; Ye Li ; ZHIZHIKIN Andrey >> > > >> > > Subject: RE: [PATCH 1/2] fsl-layerscape: add dtb overlay feature >> > > >> > > >> > > Hi Michael, >> > > >> > > -----Original Message----- >> > > From: Michael Walle >> > > Sent: Monday, November 29, 2021 11:17 PM >> > > To: Sahil Malhotra (OSS) >> > > Cc: Cl=C3=A9ment Faure ; Gaurav Jain >> > > ; Pankaj Gupta ; >> > Priyanka >> > > Jain ; u- boot@lists=2Edenx=2Ede; Varun = Sethi >> > > ; Ye Li ; ZHIZHIKIN Andrey >> > > >> > > Subject: Re: [PATCH 1/2] fsl-layerscape: add dtb overlay feature >> > > >> > > Hi Sahil, >> > > >> > > Am 2021-11-29 12:55, schrieb Sahil Malhotra (OSS): >> > > > Am 2021-11-17 19:11, schrieb Sahil Malhotra (OSS): >> > > >>> Could you please add some description what this is doing and fo= r >> > > >>> what this is intended? To have a "DTB overlay feature", it is >> > > >>> enough to just enable CONFIG_OF_LIBFDT_OVERLAY=2E >> > > >> I will add some description, and yes for DTB overlay feature, it >> > > >> is enough to enable CONFIG_OF_LIBFDT_OVERLAY but we need to do >> > > >> this step before booting the kernel that's why also have to >> > > >> enable CONFIG_OF_SYSTEM_SETUP=2E >> > > > >> > > >> Ok=2E What will the overlay do? Could you give an example? >> > > > This overlay will be disabling the crypto nodes which will be use= d >> > > > by optee in secure world, so that linux should not use it=2E >> > > > >> > > > >> > > >>> Apparently you're adding an overlay passed by optee=2E Doesn't >> > > >>> this have to be applied to u-boot's control dtb too? >> > > >> Yes, we will be applying the overlay passed by optee, yes it wil= l >> > > >> be applied to dtb which will be passed to uboot for kernel booti= ng=2E >> > > > >> > > >> If I read this patch correctly, you're modifying the DT before >> > > >> you jump to linux=2E But I was asking whether you also have to >> > > >> modify the DT which is used by u-boot=2E Eg=2E if you disable so= me >> > > >> kind of crypto nodes (because optee will use them in secure >> > > >> world), this also have to communicated to u-boot, not only linux= , no? >> > > > Yes, I got your point now, and is very valid, but as of now for >> > > > u-boot we are just using the first available node for >> > > > communicating with CAAM leaving other job rings as it is=2E >> > > > So we need not to apply overlay to DTB used by uboot=2E >> > > >> > > > But we should do the correct thing, so that u-boot and linux >> > > > doesn't see a >> > > different version of the device tree=2E >> > > >> > > > Also what do you mean with "the first available node"? >> > > > There is already a new CAAM driver for u-boot pending, see >> > > > https://lore=2Ekernel=2Eorg/u-boot/20211115070014=2E17586-1-gaura= v=2Ejain@ >> > > > nx >> > > > p=2Ecom/ >> > > >> > > Very first CAAM Job Ring is always used by u-boot, OP-TEE does not >> > > use this job ring=2E Same job ring can be used by Linux once it boo= ts up=2E >> > >> > Just for clarification: by saying "Very first CAAM Job Ring" do you >> > actually mean JR0? >> Yes, Very first CAAM Job Ring means JR0 for Layerscape=2E >>=20 >> > >> > If the BootROM logic with respect to JR reservation for LS family doe= s >> > not differ from i=2EMX8M family (which I assume does not), then why >> > can't the logic be implemented in the same way proposed by Gaurav [1] >> here as well? >> BootROM logic with respect to JR reservation is different for both Laye= rscape >> and i=2EMX8M family=2E >> On Layerscape Platforms we don't have HAB, so we don=E2=80=99t need to = reserve >> JR0=2E >>=20 >> > >> > DT nodes can be statically disabled if we know that they are held by >> > HAB and are not released to NS World=2E >> > >> > OP-TEE does set the status itself via dt_enable_secure_status(), whic= h >> > should present the properly configured FDT when U-Boot takes over=2E >> Yes, OP-TEE set the status by dt_enable_secure_status() in DTB overlay >> which gets merged with DTB provided for Linux bootup and then Linux boo= ts >> with merged DTB=2E >> But u-boot uses the DTB embedded in its image=2E How can we modify that >> DTB or merge DTB overlay passed by OP-TEE with uboot DTB ? >>=20 >> > >> > This is however valid only if OP-TEE implementation for LS matches to >> > one from i=2EMX8M family=2E >> > >> > If it OP-TEE does differ, then I suggest this should be rather >> > addressed there before U-Boot, since OP-TEE have all facilities in >> > place to reserve JR nodes as they are needed=2E >> OP-TEE reserves the JR node needed by it, but it needs to tell that to = Normal >> World entities and that is being done using DTB overlay for now=2E >>=20 >> > >> > > >> > > Regards, >> > > Sahil Malhotra >> > >> > -- andrey >> > Link: [1]: https://lore=2Ekernel=2Eorg/u-boot/20211207074129=2E10955-= 9- >> > gaurav=2Ejain@nxp=2Ecom >>=20 >> Regards, >> Sahil Malhotra >>=20 >>=20 >>=20 > hey sahil, I'm on vacation until the end of this week=2E will comment beginning of ne= xt week=2E -michael