u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: Patrice Chotard <patrice.chotard@foss.st.com>, u-boot@lists.denx.de
Cc: Patrick DELAUNAY <patrick.delaunay@foss.st.com>,
	U-Boot STM32 <uboot-stm32@st-md-mailman.stormreply.com>,
	Farhan Ali <farhan.ali@broadcom.com>,
	Sean Anderson <seanga2@gmail.com>, Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH] mtd: nand: raw: convert nand_dt_init() to ofnode_xx() interface
Date: Tue, 28 Sep 2021 08:30:11 +0200	[thread overview]
Message-ID: <0e5077de-9765-2bd3-1938-ae6382b06929@denx.de> (raw)
In-Reply-To: <20210913142553.24333-1-patrice.chotard@foss.st.com>

Hello Patrice,

On 13.09.21 16:25, Patrice Chotard wrote:
> nand_dt_init() is still using fdtdec_xx() interface.
> If OF_LIVE flag is enabled, dt property can't be get anymore.
> Updating all fdtdec_xx() interface to ofnode_xx() to solve this issue.
> For doing this, node parameter type must be ofnode.
> First idea was to convert "node" parameter to ofnode type inside
> nand_dt_init() using offset_to_ofnode(node). But offset_to_ofnode()
> is not bijective, in case OF_LIVE flag is enabled, it performs an assert().
> So, this leads to update nand_chip struct flash_node field from int to
> ofnode and to update all nand_dt_init() callers.
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> ---
>  drivers/mtd/nand/raw/denali.c          |  2 +-
>  drivers/mtd/nand/raw/mxs_nand.c        |  2 +-
>  drivers/mtd/nand/raw/nand_base.c       | 27 +++++++++++---------------
>  drivers/mtd/nand/raw/stm32_fmc2_nand.c |  2 +-
>  drivers/mtd/nand/raw/sunxi_nand.c      |  2 +-
>  include/linux/mtd/rawnand.h            |  6 +++---
>  6 files changed, 18 insertions(+), 23 deletions(-)

Applied to u-boot-i2c next



DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs@denx.de

  reply	other threads:[~2021-09-28  6:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13 14:25 [PATCH] mtd: nand: raw: convert nand_dt_init() to ofnode_xx() interface Patrice Chotard
2021-09-28  6:30 ` Heiko Schocher [this message]
2021-09-28 18:44 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e5077de-9765-2bd3-1938-ae6382b06929@denx.de \
    --to=hs@denx.de \
    --cc=farhan.ali@broadcom.com \
    --cc=patrice.chotard@foss.st.com \
    --cc=patrick.delaunay@foss.st.com \
    --cc=seanga2@gmail.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-stm32@st-md-mailman.stormreply.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).