From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1CCDC433EF for ; Sat, 18 Dec 2021 08:35:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D3B8683028; Sat, 18 Dec 2021 09:34:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1639816499; bh=8+r5OTu/Dl8aoY4unYboxaVCB6dkH2qJ5Cz000mQUIo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=sTMdso8/J886Q+E39ypblxI2uLxtVy4e4JmHCmLMdz/5780H3wpGDHFWia+WxW33i B8md3KFj8WNIeJfEUhjVDsqqIa3Kwrqke2zWWVRDE1UbbiwlhJIHlyOsFzIFNoTxnM h9nVeqC9zDxOT1icuUTT9cCezGUhNXGOy7lwkBiBGl59Fq6no7hNPi06JgO5N+VtO3 FbTfvtTPF02WWR8Ofw5PT1k9ZTbGBHK/nOnkYBX99YjYhTUbkt7qycpPyVhiCNN3P3 zZPdC24ljZNEgbSifwhkTU41op+udbMp611L/2xnWjhc4zL1p37l02QkH+hxyrHh0q A1XnJoxMiG2Ew== Received: by phobos.denx.de (Postfix, from userid 109) id BA9528303B; Sat, 18 Dec 2021 09:34:56 +0100 (CET) Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [91.198.250.253]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DFF9982A68 for ; Sat, 18 Dec 2021 09:34:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp2.mailbox.org (unknown [91.198.250.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4JGK0Y2yxPzQlHC; Sat, 18 Dec 2021 09:34:53 +0100 (CET) Message-ID: <10c2869e-6ad8-1c73-d94d-8c0765aaf50e@denx.de> Date: Sat, 18 Dec 2021 09:34:49 +0100 MIME-Version: 1.0 Subject: Re: [PATCH] arm: mvebu: Use printf for printing fatal errors Content-Language: en-US To: =?UTF-8?Q?Pali_Roh=c3=a1r?= Cc: =?UTF-8?Q?Marek_Beh=c3=ban?= , u-boot@lists.denx.de References: <20211217173114.4948-1-pali@kernel.org> From: Stefan Roese In-Reply-To: <20211217173114.4948-1-pali@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 12/17/21 18:31, Pali Rohár wrote: > There is no point to hide/disable fatal errors via debug() macro. > Print fatal errors loudly. > > Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan > --- > arch/arm/mach-mvebu/spl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c > index 29a8adc9d79c..609495097585 100644 > --- a/arch/arm/mach-mvebu/spl.c > +++ b/arch/arm/mach-mvebu/spl.c > @@ -313,7 +313,7 @@ void board_init_f(ulong dummy) > > ret = spl_init(); > if (ret) { > - debug("spl_init() failed: %d\n", ret); > + printf("spl_init() failed: %d\n", ret); > hang(); > } > > @@ -329,7 +329,7 @@ void board_init_f(ulong dummy) > /* Setup DDR */ > ret = ddr3_init(); > if (ret) { > - debug("ddr3_init() failed: %d\n", ret); > + printf("ddr3_init() failed: %d\n", ret); > hang(); > } > #endif > Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de