From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E0CDC433FE for ; Tue, 4 Oct 2022 17:26:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 200AF84C2D; Tue, 4 Oct 2022 19:26:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="YNOiqQeM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2A27D84D45; Tue, 4 Oct 2022 19:26:14 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C6AD384B96 for ; Tue, 4 Oct 2022 19:26:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1664904370; bh=4OQuPRtXC365bVxxRE8h+qFPdmBkaPDwI0UvRxAFkEE=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=YNOiqQeMW4dRIoC8fJiyw0zBt6y/R+WBVItGhl0tx7ay9vdVkCYYi5VFZPpX7UtLJ T1SwjL3m5LY7ADY7oQC32tu9B8yXWRb1bx2GqpOgqfK2LQmafZlRyYiXcKt0R+9T03 LFIQA/+qdvklC8M3U4OGvawGRkIokXftQjBF9Ahs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.67] ([84.118.157.2]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mof5H-1ozxCV27Zp-00p8tz; Tue, 04 Oct 2022 19:26:10 +0200 Message-ID: <120652a2-1dcb-f80a-70c1-58526f571f96@gmx.de> Date: Tue, 4 Oct 2022 19:25:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v3 1/3] efi_loader: Add SPI I/O protocol support Content-Language: en-US To: Paul Barker Cc: u-boot@lists.denx.de, Tom Rini , Ilias Apalodimas References: <20220921160628.4166966-1-paul.barker@sancloud.com> <20220921160628.4166966-2-paul.barker@sancloud.com> <2f1cf732-0fd3-2071-2cc2-7e86abbf5582@gmx.de> <3a888c87-7635-63ed-9c14-f2a53c530168@sancloud.com> From: Heinrich Schuchardt In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:/cvLVKaXg3uPJOsKsOi69g5oR1nrXpqP09EquJcsaA/DhrADFiM 7FCVA55aX3LooSCknBfLouFInphsZz33+9x2rdVmwMNs2jEQy3/EibtWTCjdp/mmQ2DDkOW YcwlxSnOGyIN52bPP0jEHCsUAkS4H+iPbEKTNw9K4HulGaulmFIbY7JiDvNbx6qCcDps6Oh 9Gm5QsjYW0KFl0ud9wJqg== X-UI-Out-Filterresults: notjunk:1;V03:K0:FAeI28PDXZ0=:fr26oujdN3l5eTZQRLfhdW VViou6vRocRXz0n5qEvswoh5yfgBrdIu7NAnL12UKPI1KILfmtwlKRjrHePvGLpzCkuJMxlQC vrbi+kcL9RLcNJBjiJ6RzKs93c+EaZEWXZRluR/zsHBfTUFutKLk7oH2E5bIn6BKLAXEGOChd LeGIx1vtbJkFWTeYKIhHB0xrqdOkCvKKqjvglY9o4lFk/ydR3bqJJojbB+sPzpUZRE/bxt5mK BnC5BL+oo+vr2SGUHIeGP4H/CBbSn3sxWxd1kugWHS/TZYv3P7RZIldYeS8fQzqfQFoHRqtHK La21c9RLg4LWeTPJcCpbcXyBDV0iROnh3ixthRj1hSnvxuaRfhYD5FdB878i3M4fvhBRQu6st 7rrq31g2tl/MvBW8eXVMSHQAWFUh/fPPWNDkBCrQFSAK1eoS2npS4Jb+SlEyUkj1wfaMKJ+ZD Es4UOTo6CQEiYoHR952MalCjf8h4KMKhTX5hqGFuD4RxP9lUKZB4hRYbZzsVMyyWtMUbxztKo cCTBQrV3ZedCwqbNQOGynGlXs6LJZU85OpGVUpaYjcGlV6XFbbE7KomD80dY2Gn5a0Z+7qzj3 a8aY6DAYlTy1JNQrg3vaUOlMg8bK855KXaGtigYmwMpA4k3QXhzBIRiuvYM5lWg/MYVX6bVlA PvPa24Apb6aollAoVJCKjGMoyJ30+8OonG5fxt5BpqJor+qlpBOSX7siT++9q6Hg9RuTKoMnA KpqUhJUVIoO/8NFPWGmGV6Tjm626iYFTJS3m3aVJYY+hVXLClDcvF1cc/1KwXyyMdFwLRdQME 0Jmo/WzZPmYaodFqJuWbSt6O5laE3GgVd3mo4SDK49eJg5AMakNmStksAuxxte6zIG/YeWvBq j76/k0VP5UnHaYJjlOvKLXnJ+qJ3r7w+qZrnm50v3Klg+TSLAS5Rn6vOLpwHAWxG4CQu6a5/6 qu8WMrfvgI2Cs1bOkL1N0JWyu5cVJyFlavXryNA1V/SGcmaacN8acGQtA8ny4vDBAkHf3iLvC Xp2XFU0sXCY34r1MaMOnn6834Mi/yEbQWS7jgNGiWqDaZBwRV4baMrB45DlY7bMW1CteRo3qE MBMUilnAsXXsJNbQa6w0sezylpMd4sBFZdWEBUBKpV9+91n8JY8YI2+1PlLPqXxf6H5qd3gvb HBnLOeIylYa0WlI464tjLEqHcU X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 10/4/22 18:31, Paul Barker wrote: > On 03/10/2022 13:05, Paul Barker wrote: >> On 26/09/2022 14:52, Heinrich Schuchardt wrote: >>> On 9/21/22 18:06, Paul Barker wrote: >>>> + >>>> +=C2=A0=C2=A0=C2=A0 log_debug("Added EFI_SPI_IO_PROTOCOL for %s with = guid " >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "%02x%02x%02x= %02x-%02x%02x-%02x%02x-%02x%02x-%02x%02x%02x%02x%02x%02x\n", >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 name, >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 guid->b[3], g= uid->b[2], guid->b[1], guid->b[0], >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 guid->b[5], g= uid->b[4], guid->b[7], guid->b[6], >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 guid->b[8], g= uid->b[9], guid->b[10], guid->b[11], >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 guid->b[12], = guid->b[13], guid->b[14], guid->b[15]); >>>> +=C2=A0=C2=A0=C2=A0 return EFI_SUCCESS; >>> >>> This should be >>> >>> log_debug(Added EFI_SPI_IO_PROTOCOL for %s with guid %pD\n", guid); >> >> I'll address this in v4. > > After a quick look in lib/vsprintf.c, I assume you meant %pUl here. yes > > Thanks, >