From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3877ECAAA3 for ; Fri, 26 Aug 2022 13:42:50 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7D42F847E8; Fri, 26 Aug 2022 15:42:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1661521368; bh=Fdh2Trw/70bp1O4pFCesS8ikapEnFkO8Gb4Zm9aBGaU=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=cAZ1yYxmx8F26DlpRh5UMv/7+Ui74Vd04yP3zVSU2C7CJlzRDBGg7rI+BzehF7w32 x6EIMcCZfq2eQJ5J6q0Wr+5yuku0RSWune4v/ZZALccYMBc6HPUq8NF+/OLR4CLe3B l/jhFilQD+t4bU/bEJb81byHa3gfrgQNViSd4d8/p8i65wSvkEH9sOdrpEj0lo9K2O jl2Q10RvXhG6FIFH+fa+xHEDWrp/PPvqWuq5R5SSApZeHdI8zs29WioTaOqSKmJ4e9 BuafdApV+MYaUHKlrKEYOLU94l2Ojq5oIr/zmHjnG+OBiSJJ8xNa5d7Kt9G0TQ32m3 Mf91RItyoXNUQ== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 607C283FA7 for ; Fri, 26 Aug 2022 15:42:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1661521366; bh=Fdh2Trw/70bp1O4pFCesS8ikapEnFkO8Gb4Zm9aBGaU=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=YNprlrD1MyTUgc0y4dNGTLV47ZZW0ZDXJpXMSxFxTJNy6UajRmH1PlZaHXEI9KXND dC3HoyxLyv17pYUS3k+w/61WkCRcpG9u0YZcqf4fGsvzroKDqsyUB+M97FW7IRQTwZ Ly/0oZ7hCxQHp1EJqMh4ENjgSEpaMd/N6T/TznK7MBTOCsMcrA9mIM8O+Z2IR6Oiq2 HHWixjXaE1pWH0lXBMiLpUhhik7JSJChjumySBzu0sVTehzkTn/tAe0y+TekLnFojC EhrGnYGv0+TxIUqskSPvpz/KSw3JCDTP4CfLAv3JDKoHBz2SncUYR7+neTyvPSXeNY TIsrKYzHn0aMg== Received: by janitor.denx.de (Postfix, from userid 108) id DA8B3A0280; Fri, 26 Aug 2022 15:42:45 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 7DC90A00A5; Fri, 26 Aug 2022 15:42:44 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 350101E0662; Fri, 26 Aug 2022 15:42:44 +0200 (CEST) To: Paul Barker cc: u-boot@lists.denx.de From: Wolfgang Denk Subject: Re: [PATCH 3/3] exports: Fix export of SPI access functions MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20220505153242.1598807-4-paul.barker@sancloud.com> References: <20220505153242.1598807-1-paul.barker@sancloud.com> <20220505153242.1598807-4-paul.barker@sancloud.com> Comments: In-reply-to Paul Barker message dated "Thu, 05 May 2022 15:32:42 -0000." Date: Fri, 26 Aug 2022 15:42:44 +0200 Message-ID: <13212.1661521364@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Dear Paul, In message <20220505153242.1598807-4-paul.barker@sancloud.com> you wrote: > * With CONFIG_DM_SPI defined, spi_get_bus_and_cs needs to be used > instead of spi_setup_slave to configure a SPI bus. As spi_setup_slave is > already present in the export list it is reasonable to also export > spi_get_bus_and_cs. > > * For the functions listed in the jump table to be callable they must > also be defined in the "exports.h" header. Define the various exported > SPI functions so that they can be used. > > Signed-off-by: Paul Barker > --- > include/_exports.h | 4 ++++ > include/exports.h | 15 ++++++++++++++- > 2 files changed, 18 insertions(+), 1 deletion(-) Sorry, but I disagree here. The SPI functions should have never been part of the export interface. As far as I can see now, they have been added by commit bedd8403f7 export SPI functions to standalone apps While we're here, fix the broken #ifdef handling in _exports.h. Signed-off-by: Mike Frysinger in 2009. Actually I must even have seen them, as I complained about incorrect comment style :-( But no, SPI support should not be inclluded. I2C was there because it was needed for reading the environment from an EEPROM, but then the interface was frozen ano no more new interfices / drivers should be allowed. Viele Grüße, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr. 5, 82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de If you can't explain it to a six year old, you don't understand it yourself. - Albert Einstein