From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B16E5C43334 for ; Sat, 16 Jul 2022 11:17:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EB61480FA1; Sat, 16 Jul 2022 13:17:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=weidmueller.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=weidmueller.onmicrosoft.com header.i=@weidmueller.onmicrosoft.com header.b="R0qnaMoh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B4AC3810E8; Sat, 16 Jul 2022 13:17:54 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80071.outbound.protection.outlook.com [40.107.8.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 832E680741 for ; Sat, 16 Jul 2022 13:17:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=weidmueller.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=stefan.herbrechtsmeier-oss@weidmueller.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jnT8/Utf57mTSuRpUpq+A/zO7kS/66kTwDtpQ65YvX1E6HEQwwiKOKtf4Ru/8HLeUCNC3lLgj8ds8bnI8TZS7C2IKVcLRlFLMboat4Ic5KgU+Pltr0ELMaaKZjRAph6qBudNgBDFHkV4/qiDb0sma3/kvOKEttKOdAMoLBYxdpd+4bSOdk/SneZ6PnrUP5AdwCj3anaRRS6xP/nfZFyvho5fRkfifdm7qTPD1qrsCRuGdPK3qd391Jp1PPGI/hG7oggksGW1SNj8tz6t8qBOC2h/E4IardHCy0fulNwDBudZRGHJ4nDlhgraUjLFW4Ikhp3boTZFnGknARtjQDZDGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QNztvBqY6nNfqledVBzMYtEHoQ/K5aq2Iwr62RATaPE=; b=BO6Z2hllICfQCkUrN1dRb0i6/jhoQ081E2Pnh/yvluzToeInqzna23sU8/oPFT51UJ97VnR5LdLFVEwjp6xPyNo3D92px2/mEA7y2hB1Oed7HZiDY40UBoVnnaG2DimIEBiLGp9IyIxJPzL0Jf+TUTHg7ZE9veuDLTfl5cUbfPfgAW33q62ykF3N4mwfWjPwgMIxO0noJ8H6UOkcdMfe0KSMJOeMFc6j7dUay9aeQIVAC4o63aw9uYTiaZjFyJ74WO7cbCivF9RMjSlmhYK35R93SKpNdvVpmFHTfkweulZymH+X5s6abL4kdjBVbSDqoXgAjGU7S8m6hq+q0TrUKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.onmicrosoft.com; s=selector1-weidmueller-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QNztvBqY6nNfqledVBzMYtEHoQ/K5aq2Iwr62RATaPE=; b=R0qnaMohxMVMvTsBG7q28D0/j3zXeHx5dKoByJasHh7tLoexulDPmPVG7Qdqd5vegYP6VkC9dHjqi7aCU/HjA+1Xr5yjLkycIaZ+Y6oRav1pA7zYbcn7TcL2E+VtUAJpuK8vqSQDfleJz56dbQiA3UNs9YDaKlELWE4/rdBbzTU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from PAXPR08MB6969.eurprd08.prod.outlook.com (2603:10a6:102:1d8::23) by AS1PR08MB7540.eurprd08.prod.outlook.com (2603:10a6:20b:470::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Sat, 16 Jul 2022 11:17:48 +0000 Received: from PAXPR08MB6969.eurprd08.prod.outlook.com ([fe80::49a6:e5ff:7f94:8787]) by PAXPR08MB6969.eurprd08.prod.outlook.com ([fe80::49a6:e5ff:7f94:8787%8]) with mapi id 15.20.5438.020; Sat, 16 Jul 2022 11:17:48 +0000 Message-ID: <18849dd4-eadc-415f-9e6f-28bf2c4cd2b9@weidmueller.com> Date: Sat, 16 Jul 2022 13:17:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/5] firmware: zynqmp: Load config overlay for core0 to pmufw Content-Language: en-US To: Michal Simek , Ashok Reddy Soma , u-boot@lists.denx.de Cc: adrian.fiergolski@fastree3d.com, jh80.chung@samsung.com, sven@svenpeter.dev, kettenis@openbsd.org, sjg@chromium.org, git@xilinx.com, git@amd.com References: <1657877964-16742-1-git-send-email-ashok.reddy.soma@xilinx.com> <1657877964-16742-3-git-send-email-ashok.reddy.soma@xilinx.com> <22a75fb0-51b8-7f88-1d45-fa33819156a5@amd.com> From: Stefan Herbrechtsmeier In-Reply-To: <22a75fb0-51b8-7f88-1d45-fa33819156a5@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0099.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::17) To PAXPR08MB6969.eurprd08.prod.outlook.com (2603:10a6:102:1d8::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3fbf288d-bffb-40ba-665e-08da671cd0a5 X-MS-TrafficTypeDiagnostic: AS1PR08MB7540:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lqg1qgaUob82OpsAVcCMbEjUSONi8QjsseJPxtN63s2vwkk9qyqXl21Zopm3bPMpMMlD2SiUvgfE1uIffjXe62L1tUz32/mNisAiOGzx3H78zUlB4It3PExoyUNSFZgFtGO3nV2iPO3uQM/dlWdua+hhtsM40Ey9gKtuQziZ18nB+v8lYWi3nBeiCjK7fXPDwmKRVfPP+tSeXmBLdATsNPwcbkilxRvp+z6JvBBQ7AuihiAx/4/gjmkPqpdaqkDtamoVPpkL2mY54KKhEbPdsVdBmQYFw/8ZWBBpD00RF9+K3bYjT27O1IZ9btkthixl1dbVZkbS7CB9fI6YxiRJlUvjVz08B1LY5lQE+Qu0A8bC4RPNAyWsCPzLE4eEyo0i2Ty7ezPaFydO7CJm/PIObqL+ZIVlSM+/X2llY7jcl/4hEjY0C5Hra8l03L9Ki8UzEE/lOU6sMKVRgSrn8t3R04pBgqNQ2jbx8rkAQVmMTwz98C1rIxHe1Dad3t9DRqHZ8Xhk8JXUWF497Baq4H1DfHRQFhY7NqCjPkpQPeWQtbZkWYUp5SMMG07bNB+hhgbpNtFTCqPMCiRtZC2GRiOIBWdiBdG4lQbj3oqrQByRXrh3G5oJxYAMc/PKhH0Yc8zE7l7a3GIs/TEk71QzuKyLG6Exdkvjwam07ucWHuTp1W2iJItV69iudNg4VWlVqVq7Oggku5wmyH6q36yuSUnAb/NT8VHsnW0oJi5BGXE9rvBwlWDGXnSEXdHBoyTH+9Hlm+xI4lwZ32Qzw8e3TxDNm14OE9Nj2cOfEo4db1YNjbIM/6yQmT+HpzwmB1c68KGuccifsGJzPgR13apHjMLguk7OIR12obJuVpCpCznUPC7d4uTACpyVg37jH0PM/hlS X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR08MB6969.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(346002)(376002)(136003)(396003)(39860400002)(316002)(86362001)(8676002)(4326008)(31696002)(83380400001)(6506007)(52116002)(53546011)(6512007)(66476007)(26005)(66556008)(478600001)(66946007)(6486002)(36756003)(7416002)(6666004)(31686004)(41300700001)(38350700002)(38100700002)(8936002)(110136005)(2906002)(5660300002)(186003)(2616005)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUlGTWdjRmgwZFcwT2JHQW83R3BEQzZSYmJPRllCOWUyY01MT0NINitPaWZC?= =?utf-8?B?dFRwZnNrcTFVckcveDVheThEeTRBcGE2cTRyenpkenpWdWJEL0NKbm82dW9j?= =?utf-8?B?YjAzRmtIamw0UE1pMFVyek9tcXkrMGxxMklFbm5xVkJKWk94KytxVDJCalRT?= =?utf-8?B?TnY0V082QUZSbWovT0kwSVBkNnd4ZHRRYmdoYUZWMHBGZ2ZsT21TY1VLQU9M?= =?utf-8?B?Z0I3ZXZLSzQ4YzJySTJqU3dnaWNsRUZqck1yQnBVeCt3Q2Fha1FWWlNkRjBB?= =?utf-8?B?K1c5YzdoU0c2aTlrNHZvc0Y1K2s5RnFITGVvNHhuRE55L3VHVDY5ZzFVUGFI?= =?utf-8?B?NmZQMWNFSUM1eVM5TmtlbUF5RDl3NGtPNWpUU3ZsM2JKK0JyNGo4dVRJN1dM?= =?utf-8?B?MnQrYndlNGx6dzFwS2ZRamU1V0pNRkFEYUM4aDhaSGdmaFdMWndoNVJUSGlG?= =?utf-8?B?VExOaERIQzk3Q0l2c0FCTnR3VE5GQTRYeE1qNEJJVUVWRWVqL29uUTRxOVF1?= =?utf-8?B?UkZWUm9Bd2V2YWZNR0dZbDJPWXZkTGlibHMzZGNvNTNvQ1k0U2dGQU0vajJ0?= =?utf-8?B?SU50SXVXczRHdDV5U2hTT0tmRkFvZjN6RDlHdzBrQ3dFRUcvcFpIMEdtVE5E?= =?utf-8?B?SGQ1M0dYMVNyQ205c1ArL3VJSVlsdWhzUEtFd09JQXRkNFVBVVdQYXV0N3Fx?= =?utf-8?B?LzBpRDk4cmdJYndiQ2U5ZzNtMUJ4QjMxdjd5VXhYaUcrOUdQeUhHMmlxbU5K?= =?utf-8?B?djVkOS9PY3NpK1NUeklzc0hsNWpDYVFpV01MUzlBaHhKK1dodmI3ZzBqbGhI?= =?utf-8?B?bUxFTDJlWm5wbGNvRGk4TStZR0Q5R1FPdHJOREZ3YzBUQUNrMFRCNGFyNEN3?= =?utf-8?B?WnhlYkJROWJRSUdJZld1U3BqbjdIU01TdzlmZ3IxWVQzWVdLT3hzMklUL3Qx?= =?utf-8?B?cjdYNEpFbkhmUFNHTlE2Q1I4djV2MThRbGNZZUF6TkROUDNTbjBaR05IcmF1?= =?utf-8?B?UXpsdEVLY2d1dmxIcEJ2U21lS2ZCa0drVExyUVdjeDc5ZWlBU0I2Sm5IbjdV?= =?utf-8?B?UXlWSUtjNnZPRVdoQmtLU1RITHI3aDBMd0lwTWozd1FzWHJGNVFaVWlwblUx?= =?utf-8?B?MjJnZTZ5dnJJYTFUdXkwMng1R2ZEcWpaVGFCRndvNEZlY01JSWZlSWNHVnV2?= =?utf-8?B?dVJmdVAzRFk1NmNCclNkQzgySllUbVd3Q3Z1aWM1SmVoR1Bjc3lCVWlwbjZ6?= =?utf-8?B?R2ZRS0N5NzMxN0t2UFNnZDZtZ0VZeldmSjNKS1NmVUpBdHdyb1dwVUVlYjdn?= =?utf-8?B?NzhKV0RHM2RVVkhHdjc1dUxVK08xcnF4TkYwR3dqdU9IYnB6Y1d5YmM3SzlJ?= =?utf-8?B?RjU1Tmhic3llU3hBMWxXa0VIdFQvNjFiTC8vb2xLelN1ak5xUDMreWY4ZCtB?= =?utf-8?B?OFg3a1F1TVpLVktKelV1N2ZKYnZhRzBtb1BhTUkyeTFkVTNOMUg4Tm5mNXNK?= =?utf-8?B?dlI2WVBNaFN6dVVPMUxQMEk3RWRsUlkxNjA5Y2duM2xkODA3UlllZUxSa0Vy?= =?utf-8?B?UC9Td05wMTZJOFVJWXdraVA3US9WbHFraFUvay9YcE8rR2lGYlJDNmlVWkxJ?= =?utf-8?B?MGlpampuT0ZYenVCV0RHQWZTbEZwY2NadmFJbXdSaGRnN0IwLzZGRWwyWUpz?= =?utf-8?B?bEt5djExSUo0STg5NVlBTUhGbG90OFAvMEd5R0loMEI1T3BqeTJSRWhuKzln?= =?utf-8?B?a05haE8wb05TdGdXa2pNYjArRnRhNkwzRFU1SFRBQ3Rsd2hwaXJ6cE5yT0ti?= =?utf-8?B?ZlBNY0VkT05MeG0rUEcvNEl0OGRlUWRyalFGdmxnUnh5WEp2VFJ5NklRZmNV?= =?utf-8?B?cXZWL0QxUWZRZVR3eEhlVHlZR0ZaKzEvSVdsMkcwUkNKNXprZW92UURMalJP?= =?utf-8?B?azRmM1JORExIcUlFbmZPZHk0SVZOeFF5aGNhUUtBTk53L3BxeXFXWXQ3TUUx?= =?utf-8?B?T0FJTUd2ajhqeXQ2dzE5WkFLMzNhbjhwaXordkQzZlJaWXU4enEzVytDd0hm?= =?utf-8?B?ZjB0SkowaUNCNmtiSmJMWk84VTNKeW5vNlRvMWhMUnl5LzEzLzNpSTduQmFT?= =?utf-8?B?RXhIL1BGb0hVRnN4bUhCVDVEUURZb0FBU0JxVnFnWUs3V0tvcDRGK1BRRDNq?= =?utf-8?B?SGc9PQ==?= X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3fbf288d-bffb-40ba-665e-08da671cd0a5 X-MS-Exchange-CrossTenant-AuthSource: PAXPR08MB6969.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2022 11:17:48.4686 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o4rC6eawbUNi9AJFVn1Qe2PUUtnIlwnSKXlhRGrbJhEBWyLxyTWvrK38BTP5dy3sw0LEtmCTg/fGQPuYgyMpXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7540 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Am 15.07.2022 um 18:34 schrieb Michal Simek: > > > On 7/15/22 18:13, Stefan Herbrechtsmeier wrote: >> Am 15.07.2022 um 11:39 schrieb Ashok Reddy Soma: >>> Try loading pmufw config overlay for core0, if it doesn't return any >>> error it means pmufw is accepting nodes for other IP's. Otherwise dont >>> try to load config object for any other IP, just return from >>> zynqmp_pmufw_node function. >>> >>> Signed-off-by: Ashok Reddy Soma >>> --- >>> >>>   drivers/firmware/firmware-zynqmp.c | 14 ++++++++++++++ >>>   1 file changed, 14 insertions(+) >>> >>> diff --git a/drivers/firmware/firmware-zynqmp.c >>> b/drivers/firmware/firmware-zynqmp.c >>> index 34d9b47003..288151533e 100644 >>> --- a/drivers/firmware/firmware-zynqmp.c >>> +++ b/drivers/firmware/firmware-zynqmp.c >>> @@ -68,8 +68,13 @@ int zynqmp_pmufw_config_close(void) >>>       return 0; >>>   } >>> +static bool config_enabled; >>> + >> >> Please move the variable inside the function. > > How can this work? When you move it to zynqmp_pmufw_node() then won't be > visible in zynqmp_power_probe() and vice-versa. If you reuse the zynqmp_pmufw_node function in zynqmp_power_probe function you can check the id parameter to update the config_enabled variable in zynqmp_pmufw_node.