Re: [PATCH v3 0/7] rpi5: initial support

From: Marc Zyngier <maz@kernel.org>
To: "Ivan T. Ivanov" <iivanov@suse.de>
Cc: Matthias Brugger <mbrugger@suse.com>,
	Peter Robinson <pbrobinson@gmail.com>,
	Dmitry Malkin <dmitry@bedrocksystems.com>,
	Thomas Fitzsimmons <fitzsim@fitzsim.org>,
	Peng Fan <peng.fan@nxp.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Anatolij Gustschin <agust@denx.de>,
	wahrenst@gmx.net, florian.fainelli@broadcom.com,
	u-boot@lists.denx.de
Subject: Re: [PATCH v3 0/7] rpi5: initial support
Date: Fri, 22 Dec 2023 12:44:49 +0000	[thread overview]
Message-ID: <1b435a7d04a9cd3a0d7c71c5b44f5e45@kernel.org> (raw)
In-Reply-To: <evdxlvvwhotp77abj23arm2zwbgcqijqxxmuregf2uas4c3clj@jbfqnkc6fc7x>

On 2023-12-22 12:33, Ivan T. Ivanov wrote:
> On 12-22 12:19, Marc Zyngier wrote:
>> 
>> Hi Ivan,
>> 
>> On 2023-12-18 21:03, Ivan T. Ivanov wrote:
>> > Hi,
>> >
>> > These patches are adding basic support for RPi5.
>> > They are based on v2 series from Dmitry Malkin[1].
>> >
>> > With them I am able to _start_ current openSUSE
>> > Tumbleweed without modification. They are still
>> > a lot of things to be added to the upstream Linux
>> > before it runs flawlessly on this device, but at
>> > least in U-Booot SD controller used for uSD card
>> > and Frameboffer and HDMI0 devices are working fine
>> > now. It seems that PCIe controller is working fine
>> > too, but I have not tested it too much.
>> >
>> > Serial console and reset are also functional.
>> >
>> > Hopefully this will help others add missing pieces
>> > more easily.
>> 
>> So I've given this a go, and the basics (serial) worked
>> out of the box (thanks for that!) after performing the
>> memory-map change you described in your reply to patch 1.
>> 
>> However, I don't get anything on the PCIe front:
>> 
>> U-Boot> pci enum
>> PCIe BRCM: link down
>> PCIe BRCM: link down
>> 
>> despite having an nvme device connected and enabled
>> (the RPi kernel finds it).
>> 
>> I'm guessing I must be missing something. How did you
>> test PCIe?
>> 
> 
> No, you are not missing anything. I have not tested it
> for real. That is why I said "it seems". Sorry.
> 
> Yesterday I started looking more closely at what's missing
> and unfortunately a lot more changes are needed.

Ah, fair enough. I was slightly surprised that it appeared
to be working out of the box, which would have been a first
on the ARM side...

Happy to test whatever patches you come up with!

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...