u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Patrice CHOTARD <patrice.chotard@foss.st.com>
To: Jorge Ramirez-Ortiz <jorge@foundries.io>, <hs@denx.de>,
	<patrick.delaunay@foss.st.com>, <oleksandr.suvorov@foundries.io>
Cc: <uboot-stm32@st-md-mailman.stormreply.com>, <u-boot@lists.denx.de>
Subject: Re: [PATCHv2 1/2] i2c: stm32f7: fix clearing the control register
Date: Wed, 24 Aug 2022 17:35:07 +0200	[thread overview]
Message-ID: <1be010a7-8ecc-c102-ff74-7e4380865bd4@foss.st.com> (raw)
In-Reply-To: <20220815145211.31342-1-jorge@foundries.io>

Hi Jorge

On 8/15/22 16:52, Jorge Ramirez-Ortiz wrote:
> Bits should be set to 0, not 1.
> 
> Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
> ---
>  drivers/i2c/stm32f7_i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/stm32f7_i2c.c b/drivers/i2c/stm32f7_i2c.c
> index bf2a6c9b4b..3a727e68ac 100644
> --- a/drivers/i2c/stm32f7_i2c.c
> +++ b/drivers/i2c/stm32f7_i2c.c
> @@ -413,7 +413,7 @@ static int stm32_i2c_check_end_of_message(struct stm32_i2c_priv *i2c_priv)
>  		setbits_le32(&regs->icr, STM32_I2C_ICR_STOPCF);
>  
>  		/* Clear control register 2 */
> -		setbits_le32(&regs->cr2, STM32_I2C_CR2_RESET_MASK);
> +		clrbits_le32(&regs->cr2, STM32_I2C_CR2_RESET_MASK);
>  	}
>  
>  	return ret;


Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice

  parent reply	other threads:[~2022-08-24 15:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-15 14:52 [PATCHv2 1/2] i2c: stm32f7: fix clearing the control register Jorge Ramirez-Ortiz
2022-08-15 14:52 ` [PATCHv2 2/2] i2c: stm32f7: do not set the STOP condition on error Jorge Ramirez-Ortiz
2022-08-25  8:52   ` Patrice CHOTARD
2022-08-25 13:36   ` Patrice CHOTARD
2022-09-07  9:20     ` Alain Volmat
2022-09-09  9:35       ` Patrick DELAUNAY
2022-08-24 15:35 ` Patrice CHOTARD [this message]
2022-08-30  7:43 ` [PATCHv2 1/2] i2c: stm32f7: fix clearing the control register Patrick DELAUNAY
2022-09-15 15:14 ` Patrick DELAUNAY
2022-08-24 15:56 Jorge Ramirez-Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1be010a7-8ecc-c102-ff74-7e4380865bd4@foss.st.com \
    --to=patrice.chotard@foss.st.com \
    --cc=hs@denx.de \
    --cc=jorge@foundries.io \
    --cc=oleksandr.suvorov@foundries.io \
    --cc=patrick.delaunay@foss.st.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-stm32@st-md-mailman.stormreply.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).