From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F2C5C433F5 for ; Thu, 23 Dec 2021 09:34:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 91B5183146; Thu, 23 Dec 2021 10:34:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=walle.cc header.i=@walle.cc header.b="lC9WfR1W"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 45267831D7; Thu, 23 Dec 2021 10:34:50 +0100 (CET) Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 16A0883112 for ; Thu, 23 Dec 2021 10:34:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@walle.cc Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 7C81922246; Thu, 23 Dec 2021 10:34:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1640252085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mn7ELF0ng4iqrrccLdy/xuhDMqNjoNsSRP4SyLKUYrg=; b=lC9WfR1WLLsfXbUV2rRg9SyP/AtaY7ZNbT4R4LZf4Qp+/HwBYhGCZa5j9ls8YaHhcOxiwJ kMSHIVuPtybzIt/NcDtuSknpN5J6A4dQQXWbNwq1LRIJzFdfMgXods0sfvQfwemOd++xXl iq4OIGlSakRThwL8AZptlr1GhCU0jhg= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 23 Dec 2021 10:34:45 +0100 From: Michael Walle To: "Sahil Malhotra (OSS)" Cc: ZHIZHIKIN Andrey , =?UTF-8?Q?C?= =?UTF-8?Q?l=C3=A9ment_Faure?= , Gaurav Jain , Pankaj Gupta , Priyanka Jain , u-boot@lists.denx.de, Varun Sethi , Ye Li Subject: Re: [EXT] Re: [PATCH 1/2] fsl-layerscape: add dtb overlay feature In-Reply-To: References: <20211117062347.24517-1-sahil.malhotra@oss.nxp.com> <20211117075314.3606691-1-michael@walle.cc> <21c98b3d9cead3f003718425d11137ec@walle.cc> <537512dc76cbd87695d93bf7ea419a07@walle.cc> User-Agent: Roundcube Webmail/1.4.12 Message-ID: <1ea4e3f13da952e61d530ec9b31d193c@walle.cc> X-Sender: michael@walle.cc X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Sahil, Am 2021-12-23 09:46, schrieb Sahil Malhotra (OSS): >> -----Original Message----- >> From: U-Boot On Behalf Of Michael Walle >> Sent: Monday, December 20, 2021 6:23 PM >> To: Sahil Malhotra (OSS) >> Cc: ZHIZHIKIN Andrey ; Clément >> Faure ; Gaurav Jain ; >> Pankaj Gupta ; Priyanka Jain >> ; u-boot@lists.denx.de; Varun Sethi >> ; Ye Li >> Subject: [EXT] Re: [PATCH 1/2] fsl-layerscape: add dtb overlay feature >> >> Caution: EXT Email >> >> Hi Sahil, >> >> Am 2021-12-10 07:33, schrieb Sahil Malhotra (OSS): >> >> DT nodes can be statically disabled if we know that they are held by >> >> HAB and are not released to NS World. >> >> >> >> OP-TEE does set the status itself via dt_enable_secure_status(), >> >> which should present the properly configured FDT when U-Boot takes >> over. >> > Yes, OP-TEE set the status by dt_enable_secure_status() in DTB overlay >> > which gets merged with DTB provided for Linux bootup and then Linux >> > boots with merged DTB. >> > But u-boot uses the DTB embedded in its image. How can we modify that >> > DTB or merge DTB overlay passed by OP-TEE with uboot DTB ? >> >> But then u-boot has the "wrong" dtb. What is the reason, there is an >> overlay >> instead of a whole dtb? what if the overlay doesn't match the dtb? > "wrong" dtb means that uboot will not be aware of CAAM job ring which > is taken by > OP-TEE and uboot on LS platforms currently use JR0, which is not being > used by any other > entity in LS bootflow. I don't know I follow. u-boot and linux should have the same device tree; regardless if that device is used or not. So applying the overlay just for linux isn't enough here. > We don't use DTB in OP-TEE, but when we use CAAM in OP-TEE, OP-TEE > reserves > One Job Ring for its use and that is communicated to Kernel using DTB > overlay. > >> what if the overlay doesn't match the dtb? > I didn't get this point, can you please elaborate a little. You are merging a dtb fragment with an unknown dtb, right? Who says they match? you might have an old dtb where the supplied dtb fragment doesn't make any sense. I might be missing something here. Eg. where is the linux dtb supposed to come from? This patchset is really missing an example and a description how things should work. -michael