From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 554D7C4338F for ; Fri, 13 Aug 2021 01:11:50 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 809D360295 for ; Fri, 13 Aug 2021 01:11:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 809D360295 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7A28782DC1; Fri, 13 Aug 2021 03:11:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="qNbDUB6J"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CC58782DC3; Fri, 13 Aug 2021 03:11:44 +0200 (CEST) Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8E14082DA1 for ; Fri, 13 Aug 2021 03:11:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf31.google.com with SMTP id 3so4352071qvd.2 for ; Thu, 12 Aug 2021 18:11:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Dj5wQstoroj4ZUpTjqmsGkMKf6Go/u6mxtzNwZVaP+A=; b=qNbDUB6J/ZrMywSnhSBtjOdZHCgPTqaemvJC5t402ijY3S1oQ6uPzUOycYpTBGDGzw M2Q3QAay/nHHP72xDNqnwglrgfKWKqmqN8swLt7MyR5o3Xgq47AlUNcaePJAo5uFXcx0 hpyPQdxvd7x7kPjSFpscY5qf5hgV7QjdMjSshIQrYqsRl58TOfsnnuFeZHMvrghmVuML oOoj7nNmA9F71um2lpsBGaRmF0Zg8yIAaSj7TZtXtjTc9KlEazNbvp2ebKQ5cL1SNjfY frSnxAb82wPp87yKYSXsr6QndKBZfDiTI3DE8rD04Y3Of5XxyOJObify8NEdkX7gppSb SRpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Dj5wQstoroj4ZUpTjqmsGkMKf6Go/u6mxtzNwZVaP+A=; b=XOgfg5k3pQ/7tQP7724/5ijcg88xRx0v4YFOFoUeBhqU1WBdev2QtAMa4IPkvFdH1f hbvMQsYtta2atnHPOIYMDa9WPBqFkuzOueBofKeWnzBSaG2cBYpxcZ4WP1qR55VRv/k9 YC2le2uenwjkSN2KtTZ4gqPhuA41kSintzIqsey/JEW8PuOyQxk2zqFOfbOybiCtz8K6 rXhUz5RYySx2b5S4IPqt18NPkDNxa0FVr0T4iLXuv0gkrwbXAiLaUnhLkRz7SMhMXOGd rw8sAmXyO2m+ZU7Xm1u237z05fQsLScWrvjcTGOWuGnm69kYlYPUBUVM5gb7sQo8C1eV KzFA== X-Gm-Message-State: AOAM530lln0k5ACm2e0RczzvxXSvC9hnlx0Ym/6DHJQtngAzzN//7gtw uDYWuxSuzNzWiZFQy1IK6FQ= X-Google-Smtp-Source: ABdhPJy7YdfXlpF3JL2xMYv+3GYh3cAlKtxZPBXlGqvHfXjOTrg75YtF6lJ+O9rf4mZCe8nTC3BNww== X-Received: by 2002:a05:6214:126:: with SMTP id w6mr145266qvs.61.1628817095376; Thu, 12 Aug 2021 18:11:35 -0700 (PDT) Received: from [192.168.1.201] (pool-108-45-127-224.washdc.fios.verizon.net. [108.45.127.224]) by smtp.googlemail.com with ESMTPSA id y124sm2442138qke.70.2021.08.12.18.11.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Aug 2021 18:11:34 -0700 (PDT) Subject: Re: [PATCH 05/23] serial: Add a SERIAL config To: Simon Glass , U-Boot Mailing List Cc: Tom Rini References: <20210808182031.3747270-1-sjg@chromium.org> <20210808182031.3747270-6-sjg@chromium.org> From: Sean Anderson Message-ID: <200122d9-5765-8d85-af5a-63372285a533@gmail.com> Date: Thu, 12 Aug 2021 21:11:34 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210808182031.3747270-6-sjg@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 8/8/21 2:20 PM, Simon Glass wrote: > At present we have SPL_SERIAL and TPL_SERIAL but not piain SERIAL. This nit: plain I believe this typo occurs in several other patches in this series as well, e.g. GPIO and POWER. --Sean > works because there is a special build rule in Makefile that always > includes the drivers/serial directory. > > It is better to have all driver directories included by drivers/Makefile > and there is already a rule in there for this purpose. It just needs a > Kconfig for U-Boot proper, so add one. > > It is always enabled, for now, since that mimics the current behaviour. > It should be possible to drop the strange 'SERIAL_PRESENT' option at some > point and use SERIAL instead. > > Signed-off-by: Simon Glass > --- > > Makefile | 1 - > drivers/serial/Kconfig | 15 +++++++++++++-- > 2 files changed, 13 insertions(+), 3 deletions(-) > > diff --git a/Makefile b/Makefile > index 269e353a28a..653df0d2731 100644 > --- a/Makefile > +++ b/Makefile > @@ -829,7 +829,6 @@ libs-$(CONFIG_FMAN_ENET) += drivers/net/fm/ > libs-$(CONFIG_SYS_FSL_DDR) += drivers/ddr/fsl/ > libs-$(CONFIG_SYS_FSL_MMDC) += drivers/ddr/fsl/ > libs-$(CONFIG_$(SPL_)ALTERA_SDRAM) += drivers/ddr/altera/ > -libs-y += drivers/serial/ > libs-y += drivers/usb/cdns3/ > libs-y += drivers/usb/dwc3/ > libs-y += drivers/usb/common/ > diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig > index 93348c0929c..205c9ddc442 100644 > --- a/drivers/serial/Kconfig > +++ b/drivers/serial/Kconfig > @@ -2,7 +2,18 @@ > # Serial device configuration > # > > -menu "Serial drivers" > +menuconfig SERIAL > + bool "Serial" > + default y > + help > + Enable support for serial drivers. This allows use of a serial UART > + for displaying messages while U-Boot is running. It also brings in > + printf() and panic() functions. This should normally be enabled > + unless there are space reasons not to. If you just need to disable > + the console you can adjust the stdout environment variable or use > + SILENT_CONSOLE. > + > +if SERIAL > > config BAUDRATE > int "Default baudrate" > @@ -939,4 +950,4 @@ config SYS_SDMR > depends on MPC8XX_CONS > default 0 > > -endmenu > +endif >