From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Thu, 13 May 2021 19:39:21 -0600 Subject: [PATCH v2 05/16] reset: Avoid a warning in devm_reset_bulk_get_by_node() In-Reply-To: <20210513193923.v2.1.I85633a7354c5b2ad5c55257607280392d069d70c@changeid> References: <20210513193923.v2.1.I85633a7354c5b2ad5c55257607280392d069d70c@changeid> Message-ID: <20210513193923.v2.5.Ia04371ac898c4f270ada6f27a9c013b0f8fc211b@changeid> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de The devres_alloc() function is intended to avoid the need for freeing memory, although in practice it may not be enabled, thus leading to a true leak. Nevertheless this is intended. Add a comment to explain this. Signed-off-by: Simon Glass Reported-by: Coverity (CID: 312952) --- Changes in v2: - Add a standard comment instead of a Coverity annotation drivers/reset/reset-uclass.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/reset/reset-uclass.c b/drivers/reset/reset-uclass.c index ac89eaf098a..a3a088d1b5c 100644 --- a/drivers/reset/reset-uclass.c +++ b/drivers/reset/reset-uclass.c @@ -323,6 +323,8 @@ struct reset_ctl_bulk *devm_reset_bulk_get_by_node(struct udevice *dev, bulk = devres_alloc(devm_reset_bulk_release, sizeof(struct reset_ctl_bulk), __GFP_ZERO); + + /* this looks like a leak, but devres takes care of it */ if (unlikely(!bulk)) return ERR_PTR(-ENOMEM); -- 2.31.1.751.gd2f1c929bd-goog