From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Lokesh Vutla <lokeshvutla@ti.com>,
U-Boot Mailing List <u-boot@lists.denx.de>,
Le Jin <le.jin@siemens.com>,
Bao Cheng Su <baocheng.su@siemens.com>,
Nian Gao <nian.gao@siemens.com>,
Chao Zeng <chao.zeng@siemens.com>
Subject: Re: [PATCH v2 4/5] watchdog: rti_wdt: Add support for loading firmware
Date: Sun, 27 Jun 2021 15:34:20 -0400 [thread overview]
Message-ID: <20210627193420.GV9516@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ3idzeSaLAv28ytY6Eq5Ac4pM7i78bjtWFimGwL_+HrVg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 5406 bytes --]
On Sun, Jun 27, 2021 at 12:18:09PM -0600, Simon Glass wrote:
> Hi Jan,
>
> On Sun, 27 Jun 2021 at 12:01, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> >
> > On 26.06.21 20:29, Simon Glass wrote:
> > > Hi,
> > >
> > > On Fri, 11 Jun 2021 at 08:08, Tom Rini <trini@konsulko.com> wrote:
> > >>
> > >> On Fri, Jun 11, 2021 at 07:14:21PM +0530, Lokesh Vutla wrote:
> > >>> Hi Tom,
> > >>>
> > >>> On 09/06/21 6:47 pm, Jan Kiszka wrote:
> > >>>> On 07.06.21 13:44, Jan Kiszka wrote:
> > >>>>> On 07.06.21 13:40, Tom Rini wrote:
> > >>>>>> On Mon, Jun 07, 2021 at 03:33:52PM +0530, Lokesh Vutla wrote:
> > >>>>>>> +Tom,
> > >>>>>>>
> > >>>>>>> Hi Tom,
> > >>>>>>>
> > >>>>>>> On 02/06/21 3:07 pm, Jan Kiszka wrote:
> > >>>>>>>> From: Jan Kiszka <jan.kiszka@siemens.com>
> > >>>>>>>>
> > >>>>>>>> To avoid the need of extra boot scripting on AM65x for loading a
> > >>>>>>>> watchdog firmware, add the required rproc init and loading logic for the
> > >>>>>>>> first R5F core to the watchdog start handler. In case the R5F cluster is
> > >>>>>>>> in lock-step mode, also initialize the second core. The firmware itself
> > >>>>>>>> is embedded into U-Boot binary to ease access to it and ensure it is
> > >>>>>>>> properly hashed in case of secure boot.
> > >>>>>>>>
> > >>>>>>>> One possible firmware source is https://github.com/siemens/k3-rti-wdt.
> > >>>>>>>>
> > >>>>>>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > >>>>>>>> ---
> > >>>>>>>> drivers/watchdog/Kconfig | 20 ++++++++++++
> > >>>>>>>> drivers/watchdog/Makefile | 5 +++
> > >>>>>>>> drivers/watchdog/rti_wdt.c | 58 ++++++++++++++++++++++++++++++++++-
> > >>>>>>>> drivers/watchdog/rti_wdt_fw.S | 20 ++++++++++++
> > >>>>>>>> 4 files changed, 102 insertions(+), 1 deletion(-)
> > >>>>>>>> create mode 100644 drivers/watchdog/rti_wdt_fw.S
> > >>>>>>>>
> > >>>>>>>> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> > >>>>>>>> index f0ff2612a6..1a1fddfe9f 100644
> > >>>>>>>> --- a/drivers/watchdog/Kconfig
> > >>>>>>>> +++ b/drivers/watchdog/Kconfig
> > >>>>>>>> @@ -209,6 +209,26 @@ config WDT_K3_RTI
> > >>>>>>>> Say Y here if you want to include support for the K3 watchdog
> > >>>>>>>> timer (RTI module) available in the K3 generation of processors.
> > >>>>>>>>
> > >>>>>>>> +if WDT_K3_RTI
> > >>>>>>>> +
> > >>>>>>>> +config WDT_K3_RTI_LOAD_FW
> > >>>>>>>> + bool "Load watchdog firmware"
> > >>>>>>>> + depends on REMOTEPROC
> > >>>>>>>> + help
> > >>>>>>>> + Automatically load the specified firmware image into the MCU R5F
> > >>>>>>>> + core 0. On the AM65x, this firmware is supposed to handle the expiry
> > >>>>>>>> + of the watchdog timer, typically by resetting the system.
> > >>>>>>>> +
> > >>>>>>>> +config WDT_K3_RTI_FW_FILE
> > >>>>>>>> + string "Watchdog firmware image file"
> > >>>>>>>> + default "k3-rti-wdt.fw"
> > >>>>>>>> + depends on WDT_K3_RTI_LOAD_FW
> > >>>>>>>> + help
> > >>>>>>>> + Firmware image to be embedded into U-Boot and loaded on watchdog
> > >>>>>>>> + start.
> > >>>>>>>
> > >>>>>>> I need your input on this proach. Is it okay to include the linker file unders
> > >>>>>>> drivers?
> > >>>>>>
> > >>>>>> Maybe? I suppose the first thing that springs to mind is why aren't we
> > >>>>>> using binman and including this blob (which I happily see is GPLv2)
> > >>>>>> similar to how we do things with x86 for one example.
> > >>>>>>
> > >>>>>
> > >>>>> See https://www.mail-archive.com/u-boot@lists.denx.de/msg377894.html
> > >>>>>
> > >>>>> Jan
> > >>>>>
> > >>>>
> > >>>> Did this help to answer open questions? Otherwise, please let me know.
> > >>>>
> > >>>> I'd also like to avoid that his patch alone blocks 1-3 of the series
> > >>>> needless - but I would also not mind getting everything in at once.
> > >>>
> > >>> Can you provide your reviewed-by if you are okay with this approach?
> > >>
> > >> I was kind of hoping Simon would chime in here on binman usage. So,
> > >> re-re-reading the above URL, yes, fsloader wouldn't be the right choice
> > >> for watchdog firmware. But I think binman_entry_find() and related
> > >> could work, in general, for this case of "need firmware blob embedded in
> > >> to image". That said, this isn't just any firmware blob, it's the
> > >> watchdog firmware. The less reliance on other things the safer it is.
> > >> That means this would be an exception to the general firmware blob
> > >> loading rule and yeah, OK, we can do it this way. Sorry for the delay.
> > >
> > > Yes I've been a little tied up recently. But I think this should use
> > > binman. We really don't want to be building binary firmware into
> > > U-Boot itself!
> > >
> > > Also Tom says, see x86 for a load of binaries of different types and
> > > how they are accessed at runttime. This is what binman is for.
> > >
> >
> > Please take the time and study my arguments. I'm open for better
> > proposals, but they need to be concrete and addressing my points.
>
> Do you mean 'properly hashed' and 'easy access', or something else?
> What can binman not do?
Well, as I said when ack'ing this, we're also talking about making sure
the system watchdog works. It needs to be as dead simple as possible.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-06-27 19:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 9:37 [PATCH v2 0/5] Add SIMATIC IOT2050 board support Jan Kiszka
2021-06-02 9:37 ` [PATCH v2 1/5] arm: dts: Add IOT2050 device tree files Jan Kiszka
2021-06-02 9:37 ` [PATCH v2 2/5] board: siemens: Add support for SIMATIC IOT2050 devices Jan Kiszka
2021-06-02 9:37 ` [PATCH v2 3/5] arm64: dts: ti: k3-am65-mcu: Add RTI watchdog entry Jan Kiszka
2021-06-02 9:37 ` [PATCH v2 4/5] watchdog: rti_wdt: Add support for loading firmware Jan Kiszka
2021-06-07 10:03 ` Lokesh Vutla
2021-06-07 10:20 ` Jan Kiszka
2021-06-07 11:40 ` Tom Rini
2021-06-07 11:44 ` Jan Kiszka
2021-06-09 13:17 ` Jan Kiszka
2021-06-11 13:44 ` Lokesh Vutla
2021-06-11 14:08 ` Tom Rini
2021-06-26 18:29 ` Simon Glass
2021-06-27 18:01 ` Jan Kiszka
2021-06-27 18:18 ` Simon Glass
2021-06-27 19:34 ` Tom Rini [this message]
2021-06-27 20:37 ` Simon Glass
2021-06-28 5:40 ` Jan Kiszka
2021-07-05 15:29 ` Simon Glass
2021-07-14 9:53 ` Jan Kiszka
2021-07-14 14:15 ` Simon Glass
2021-07-20 12:57 ` Jan Kiszka
2021-07-20 16:14 ` Jan Kiszka
2021-07-20 17:33 ` Simon Glass
2021-06-02 9:37 ` [PATCH v2 5/5] configs: iot2050: Enable watchdog support, but do not auto-start it Jan Kiszka
2021-06-11 14:30 ` [PATCH v2 0/5] Add SIMATIC IOT2050 board support Lokesh Vutla
2021-06-11 14:53 ` Tom Rini
2021-06-11 18:20 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210627193420.GV9516@bill-the-cat \
--to=trini@konsulko.com \
--cc=baocheng.su@siemens.com \
--cc=chao.zeng@siemens.com \
--cc=jan.kiszka@siemens.com \
--cc=le.jin@siemens.com \
--cc=lokeshvutla@ti.com \
--cc=nian.gao@siemens.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).