From: "Pali Rohár" <pali@kernel.org>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Cc: Marek Behun <marek.behun@nic.cz>,
"u-boot@lists.denx.de" <u-boot@lists.denx.de>,
Chris Packham <judge.packham@gmail.com>,
Stefan Roese <sr@denx.de>, Baruch Siach <baruch@tkos.co.il>,
motib <motib@marvell.com>
Subject: Re: [PATCH u-boot-marvell] PLEASE TEST ddr: marvell: a38x: fix SPLIT_OUT_MIX state decision
Date: Mon, 28 Jun 2021 09:20:48 +0200 [thread overview]
Message-ID: <20210628072048.dgi7jqrknvsw5mdk@pali> (raw)
In-Reply-To: <20210208212409.52a584a3@nic.cz>
On Monday 08 February 2021 21:24:09 Marek Behun wrote:
> On Mon, 8 Feb 2021 20:14:26 +0000
> Chris Packham <Chris.Packham@alliedtelesis.co.nz> wrote:
>
> > On 9/02/21 8:15 am, Marek Behun wrote:
> > > This patch is needed on some Turris Omnia boards with Samsung DDR chips,
> > > otherwise DDR training fails in ~60% of cases.
> > >
> > > Marvell send us this patch for testing, I have updated it a little.
> > >
> > > Please test this on other A38x boards.
> > >
> > > If it doesn't break anything on other boards, we can apply it and send
> > > it to mv-ddr-marvell upstream.
> > They gave us the same patch. I was hoping their SoC team would get it
> > into mv-ddr-marvell (or even their vendor USP) but obviously they're
> > still sitting on it. I know it improved matters for some of our boards
> > but it didn't totally fix them we still had yield problems when we
> > ramped up production.
>
> There is a bug in the version they sent us:
>
> in file ddr3_training_ip_engine.c there is a line added:
> if ((bit_bit_mask[sybphy_id] & (1 << bit_id)) == 1)
>
> try chaning it to
> if (bit_bit_mask[sybphy_id] & (1 << bit_id))
>
> This is fixed in the version I sent to mailing list
Hello Chris! Have you tried above modification if it fixes your issue?
next prev parent reply other threads:[~2021-06-28 7:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 19:12 [PATCH u-boot-marvell] PLEASE TEST ddr: marvell: a38x: fix SPLIT_OUT_MIX state decision Marek Behún
2021-02-08 19:15 ` Marek Behun
2021-02-08 20:14 ` Chris Packham
2021-02-08 20:24 ` Marek Behun
2021-06-28 7:20 ` Pali Rohár [this message]
2021-06-28 9:21 ` Chris Packham
2021-06-28 9:53 ` Chris Packham
2022-01-04 20:28 Marek Behún
2022-01-04 22:10 ` Chris Packham
2022-01-05 9:10 ` Marek Behún
2022-01-05 22:51 ` Chris Packham
2022-01-06 3:04 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210628072048.dgi7jqrknvsw5mdk@pali \
--to=pali@kernel.org \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=baruch@tkos.co.il \
--cc=judge.packham@gmail.com \
--cc=marek.behun@nic.cz \
--cc=motib@marvell.com \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).