From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7450C4338F for ; Sun, 1 Aug 2021 14:33:49 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CBAA060EB5 for ; Sun, 1 Aug 2021 14:33:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CBAA060EB5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2CE868290A; Sun, 1 Aug 2021 16:33:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Thc7huuh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D176182952; Sun, 1 Aug 2021 16:33:44 +0200 (CEST) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1E3E48290A for ; Sun, 1 Aug 2021 16:33:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x732.google.com with SMTP id c18so14304649qke.2 for ; Sun, 01 Aug 2021 07:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=l3Kcpknvq4UwsNZ1LxD504/HAi90wSIhRVLh4xlcOKM=; b=Thc7huuhN7gNV4obcvXE/m7fjqLzcaEnPWdXhc+6nSrstqDBAo4KF0xvSF5Vqc0Cyb +FcqBPMHiL+seG1OKKcehfo/OqW9RE3vAX56EhpFsfzG0G/7bVUggXtoy2EKEYKiyBDh o5tKYBg8cAmpXjtE4gbdbwssqX3+hipLGM/uA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=l3Kcpknvq4UwsNZ1LxD504/HAi90wSIhRVLh4xlcOKM=; b=q8pUT4NrIH3L2rPlkaOZ010IKllyH60IUcNNrM9s42B8blmHnIAazWZfC/b6ol2NLn X79MxrfGpHJ0UCdcx+KBhdRLdOHVg/P4gf3znfhGwlX1G32zvaAnRZkyO91fR+91POXw Wx0yLKXrb0Biv3mBgQaSJ/WT5iSDO2HD2XDHCV0nttVwlqSUQoX/8/LqjVnZyMLjrvCj LCL5DrUxRFdLaeDi8Kz89HuDoIWxhyXf3Eqh3qWr/5i5XfF8kbgO96Jnq4YoNWQ69jOt N8Jr7QoCWW9aMRKeaOWrbxffJzkgXfER1s388E6FIXOtrRbw1vkMjo64KN7X28DH6/Yh 7LqQ== X-Gm-Message-State: AOAM533sv7HIEBpJ/Ec0pjUCFJueGF2VCLam3XvdDIzLpR6ZyAI2/67b 7yoaXpeoULcn9sZTc3jO+8THqA== X-Google-Smtp-Source: ABdhPJyrQdOgj6nHcr8pqXOy4hHkTzDeJepxpcclym42smtqMVBu0goFjyswJfbV9YoW6mxrueLRtQ== X-Received: by 2002:a37:6353:: with SMTP id x80mr11342326qkb.464.1627828415767; Sun, 01 Aug 2021 07:33:35 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-fdcd-676f-f898-928d.res6.spectrum.com. [2603:6081:7b01:cbda:fdcd:676f:f898:928d]) by smtp.gmail.com with ESMTPSA id o186sm4317494qke.44.2021.08.01.07.33.34 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 01 Aug 2021 07:33:34 -0700 (PDT) Date: Sun, 1 Aug 2021 10:33:33 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Stefan Roese , U-Boot Mailing List Subject: Re: Please pull u-boot-marvell/master Message-ID: <20210801143333.GM9379@bill-the-cat> References: <013c0841-58ff-1706-d52f-32b43e0e26bd@denx.de> <20210801032847.GK9379@bill-the-cat> <20210801104649.tkfal5jykph5k2pk@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tEhStdZb4uHHcvbt" Content-Disposition: inline In-Reply-To: <20210801104649.tkfal5jykph5k2pk@pali> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --tEhStdZb4uHHcvbt Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 01, 2021 at 12:46:49PM +0200, Pali Roh=E1r wrote: > On Sunday 01 August 2021 07:26:51 Stefan Roese wrote: > > On 01.08.21 05:28, Tom Rini wrote: > > > On Sat, Jul 31, 2021 at 12:04:01PM +0200, Stefan Roese wrote: > > >=20 > > > > Hi Tom, > > > >=20 > > > > please pull the next batch of Marvell MVEBU related patches. Here t= he > > > > summary log: > > >=20 > > > First off, I've applied the whole series to u-boot/master and pushed. > > >=20 > > > Second, I see from: > > > commit 5fce2875569d6e859443af7af3477c3aebfee383 > > > Author: Pali Roh=E1r > > > Date: Fri Jul 23 11:14:27 2021 +0200 > > >=20 > > > SPL: Add support for specifying offset between header and image > > >=20 > > > That a number of boards are now doing: > > > variscite_dart6ul: spl/u-boot-spl:all +144 spl/u-boot-sp= l:text +144 > > > spl-u-boot-spl: add: 3/0, grow: 2/-1 bytes: 142/-4 (1= 38) > > > function old = new delta > > > memmove - = 42 +42 > > > spl_mmc_load 320 = 356 +36 > > > __aeabi_uidivmod - = 24 +24 > > > __aeabi_idivmod - = 24 +24 > > > spl_parse_image_header 24 = 40 +16 > > > board_init_r 220 = 216 -4 > > >=20 > > > Which I think is because we need to use do_div and so rather than '/'= and '%' > > > directly in the code. Thanks! > >=20 > > Pali, could you please take a look at this? >=20 > And what we can do here? 32-bit arm does not have 32-bit division > instruction, so it is needed to use some sort of *idiv* function. >=20 > do_div() is macro which is doing 64-bit division by using 32-bit C > operations '/' and '%', therefore it does not help with anything as this > code is doing 32-bit math (not 64-bit). >=20 > Moreover in do_div() implementation is already check that first passed > argument is of 64-bit type, so we cannot use it for 32-bit values. >=20 > Also note that in files which are touched by this commit are already > used 32-bit division operations via C '/' operator. >=20 > So I really do not know what is expected to do here... Thanks for checking. I saw block stuff and that typically does involve a 64bit value somewhere along the way. So if the answer is: - There's no 64-bit math here, really. - There's no existing shift macros we can use instead (or that ends up being larger!) - There's no existing shift macros we just need to import from the kernel. Then we're good. --=20 Tom --tEhStdZb4uHHcvbt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEGsLkACgkQFHw5/5Y0 tyy/cAv/XezX7hwra3G5meApw/QGTwpBv/LaflPr2ZkBvV1d4FD2VBPxCcyH/YJc qHjooSuJe9VGnkAtwMj2yUGuBdsTyxJM1kdE30X0+eY4Y7WIyZS9+sPgpAB1E52Z cn7cjyqjCCKWnMKrHLIMWzrx5YBjMYy5vcukd7+IoH14QvvHHbY/xj5IHJVHyZ8P 5REkIMrJiQkL8zk4IEopnmQw4kMmxVFFjifC2EHB2wUbvC6VghpplwuKOeJXEm+q iQN1f7mm4Ty4DgfBrvJg0TwCBmlZCudZJHgmvfd54MRYfZikhmWSEQrxZfkzMRn9 6qcj1uPftgLTOw4Xhb7cs+zBMSDF3ApjKrBo59iQjvxZFpdLHkQXYS209f8fhsCJ J/U+r1esfnlOyyqG1GETYr44iKptkeEakTZ3i/aC9IH34ACYm8CjO4H/cZ2/KB5G PLMGwqSSOVDcGLP1/9Hic5LTjKsUZ8x4zAQb3kL9WArQEG6KowmGzepF9bxVBrOg HwwvSLrY =yN// -----END PGP SIGNATURE----- --tEhStdZb4uHHcvbt--