From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CC9AC4338F for ; Sat, 7 Aug 2021 13:44:15 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E78E6113B for ; Sat, 7 Aug 2021 13:44:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6E78E6113B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sancloud.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4707682C47; Sat, 7 Aug 2021 15:44:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sancloud.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=sancloud.onmicrosoft.com header.i=@sancloud.onmicrosoft.com header.b="ZIDYZ3SX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AE5CC82BFD; Sat, 7 Aug 2021 14:48:37 +0200 (CEST) Received: from GBR01-CWL-obe.outbound.protection.outlook.com (mail-cwlgbr01on0701.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe14::701]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B39C882BE7 for ; Sat, 7 Aug 2021 14:48:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sancloud.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=paul.barker@sancloud.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f4fUzuUQ2bYTu3cKOu/gUP8+YXAuDhrHvCP3CSprCEfXcoRWGAsqPS7vPv3PoWzgOKgdDlq8QR3w9mok8WyO/0iKjyTxXY0r3pZdFp1piurioKy9oDiJE247PBqSphC4sM2+KWlWnwtbCCoF2+IBnxBiKJ/S77uxsyZPcJJ2Knhg9pyjzmJPU8ZN2CslltVYS+I+FR1YgFeqavZt91aU+E8wxn6U3b+eBSyl+IJAURflTpgAFcGyXGqwPK71RdX7V3DMMLSlHP2Tlb5lhdEi925HYdT+QddB1b9bxgcHZiOrzGIiXmqB/bNlfqE7exdFCwyjvpQ0IIjQJEf+SM30rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8mgBmCE3tmjc0zQswq+fF+fcwSa8UUkgl9x2amJ1yUI=; b=ggJvgk6wco68qDGfcKORMde8wYisnMtWXS6f9uiBqz9gtoQxWKpStoVmRM/nr0CFfpBeeIkq+6oOVGcHH6KPVvfZbS7O/k1yzRq8dI8Pe02IVC7E10xx4jU3QnixeOMpDb7RS3DziZQR1ijJo2BXnWgsD9nV8zrEYj8bxL/WNQ+CPIB7Z+xaIsDRX2j2grrdLDA3V88nfPxkFka90KDMINmtsrl7j5RsBkiFnOdYmyKcZa70HXRrLGd0I0OAlOio1pzxAD9FbunwAsynPArHmxvG1/2G/PWujuqMvK3thKpBhhFzZg6goBEepNsHPnOXjj7yLhqqV5YIFYau1b/lww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sancloud.com; dmarc=pass action=none header.from=sancloud.com; dkim=pass header.d=sancloud.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sancloud.onmicrosoft.com; s=selector2-sancloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8mgBmCE3tmjc0zQswq+fF+fcwSa8UUkgl9x2amJ1yUI=; b=ZIDYZ3SX699zoB3NYEja+7xSit/wA/kjpj8sYTKe8R90fGo5g8XFI0rq8F9QDinyR5R2EMXwvQi7YoI34C91mkf1/mjk11R+d0HFK75W7xeL7Qqa4huWZobw1IlcFZgTJyC7g7eh0a8l7dST1VVMBjDgV5E2LCMn5Kh0M5FJXvs= Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=sancloud.com; Received: from CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM (2603:10a6:401:61::19) by CWLP123MB3380.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:73::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.19; Sat, 7 Aug 2021 12:48:32 +0000 Received: from CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM ([fe80::dc2:e929:76be:a8b0]) by CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM ([fe80::dc2:e929:76be:a8b0%7]) with mapi id 15.20.4394.021; Sat, 7 Aug 2021 12:48:32 +0000 Date: Sat, 7 Aug 2021 13:48:20 +0100 From: Paul Barker To: "Matwey V. Kornilov" Cc: dariobin@libero.it, hws@denx.de, pbrobinson@gmail.com, trini@konsulko.com, u-boot@lists.denx.de Subject: Re: [PATCH] am33xx: Fix USB for am335x boards Message-ID: <20210807134820.2fb3d550.paul.barker@sancloud.com> In-Reply-To: <20210807111738.8391-1-matwey.kornilov@gmail.com> References: <20210807111738.8391-1-matwey.kornilov@gmail.com> Organization: SanCloud Ltd X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-suse-linux-gnu) Content-Type: multipart/signed; boundary="Sig_/JFFF67luBPNat2udbTLyZqw"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-ClientProxiedBy: LO4P123CA0460.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::15) To CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM (2603:10a6:401:61::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from owl.home.b5net.uk (80.7.160.81) by LO4P123CA0460.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.16 via Frontend Transport; Sat, 7 Aug 2021 12:48:32 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d0c14e52-3602-40cb-69ae-08d959a1a9d4 X-MS-TrafficTypeDiagnostic: CWLP123MB3380: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ThRMX+KOWXIp5AXZyLr5EVR5hphUPNUzkMHhFDNwMONUkHh6dEhxEumQq8+oGI26U4mrzgAKbvuPWiItt4Pd+IM2zPNwH5PSkm89tDJY8fc+QbH6BxmfKkSnYKPhQPyK0Bsr4WO7M7P4fjmk2FsYq1HFJvtiEgzpH+cgT3I7zjwKqW6MCdC64CF7zBIvVswTcQlJjn/U26ISTIsvtQwTeQdlVKvXI3rdsr7Y/HPxUU+WO2DAWyg7J0YXAuLLaOlOHZQ+lnps533qFl+FereIlbM/FBZzsfe1OoA9fUClcCO+yb5vUR/RCPwkB7Bw7eUKHWarbvPwsuaNKvJhofOcwYOXxk399OFzssb6kK+LUtg6o27Awk/+52lGdmSPNsTVgsmo3Bb9Gdrqi4//k/JPU0v/mjoXSQRGmLC89O7YPMW7m+Ovsw9tRWQtd1bI+RbY0wf9afJ9mZsp0yHrdNRnI8/wpXpakNJufknzwFdZsZhvEoUROt/ObNXu3wFJsK9c2lQxzFATcJkXeQuiRqpHcFDru6yDDviUg88fySqXznUKYUqUOor5YQQSmQOT/4hhkIOPlb1VPeUcELcxhISHN8Uq/b64uU8Nf8zFjPInD8DqTzJVlqHY7W/BNgb/0/s2riK06PMupacKyXwRPgMLqzxejQT0z9t0zq5I60HBehLx5aw9bAP7786QvmoQuSLp0KfN3xVQOn6KeGW1w2Ju7sK0q0/RXZ72nsU138Px32lOcZYVpyCoFAEDwvFELeeRd22a4MQPuGX3MAhT10e8Kg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(366004)(39830400003)(376002)(396003)(346002)(136003)(38350700002)(38100700002)(44832011)(1076003)(6916009)(6512007)(8936002)(83380400001)(26005)(966005)(186003)(8676002)(956004)(2616005)(2906002)(5660300002)(4326008)(6486002)(316002)(86362001)(36916002)(6506007)(36756003)(52116002)(66946007)(66476007)(66556008)(6666004)(508600001)(103116003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xmA24Cgsc4lffJeFLoqfe23g72Joc8y83PjVUDfznb6D3rb2fgPHCqjoxT66?= =?us-ascii?Q?UvudAGVVjiwdgzaq1yHlwkmQ4cGvWQ8WyU6f948UL51gp72cZDUpkkrpkxDG?= =?us-ascii?Q?wQlG6QKD+ScPKK/lurk8COG1Gb754exxCGCf/VRXOeiGFBPoCPT3oiVuQKjE?= =?us-ascii?Q?fRPb7oEsK4O0kob7rjWHhbWX0GgE+rlyYccTFbX1MIELvTRuwAgH8HSSuKrI?= =?us-ascii?Q?TBVyJoDNQoNN179CJeyGorsd/TcZ6re0LdRt7O4hqhtVqKB/I+bU1pww+O2t?= =?us-ascii?Q?HXlfuHqRnFSXPrUUrPO7FlMnlNiGpw/HyD13GvdKuq6ZeKb1JnrGI961lXNu?= =?us-ascii?Q?4QVjOVRJegz2HsaHwh/IKAcAlp5zjdsXHflWIAOIYSOGo+xq34iKzCABXGIe?= =?us-ascii?Q?SD7IA71tDg7TbdG5BpptGUgQ3lGIb/+ap5u5TgHH04ErumYIjabrTtoVmgp6?= =?us-ascii?Q?aKlAsF9SjvyBTbOh2xwdMvnnLXKslqm3j59zdVvxVWc5uReqF68HnksaSuAo?= =?us-ascii?Q?jzWaaKV63pDbtTWyjLCYFQgP/CL6+6rmJwO0um8a6oTqVrKGkkH1FcuSVO3m?= =?us-ascii?Q?WT+63PNye2eGCTpMiyGb423aAsfcjPEQBPrmMJHxK4SYz4jlrmoks3CgML1V?= =?us-ascii?Q?xNXet+G4ee/oJ+3I2jTqNK/pazMQVB/Zn2NBI71T3rMtYs74JlS4LF8pXwC5?= =?us-ascii?Q?M3meq0sadI7Ax6HWC9efzlnw3LaJrVGKOSL+NTatLG/+so0r/iN3imJVxDVd?= =?us-ascii?Q?QEz7EUCp1O9hY4U5o6mt09LU3XuIKgtNqBzc9Zl6D1TgJfqqw316z0KnxNpp?= =?us-ascii?Q?CbRnB0/cmxWdMfCl+T9enqOQcYJWYrkM37jXHj27TIq2irtcn6e7jb8D/a3t?= =?us-ascii?Q?dHzF6d02FtrE5T/3cL+kMc/vpQWV6ib5dpwvHObpkghKtkC1ni+cv9nIteiA?= =?us-ascii?Q?q9uLpYqaBlmsY6MBTimVuC77+ffnEA+wDUGACdx8cc+EAA/2aGfeBjLYnqtq?= =?us-ascii?Q?unGBqKk1ZJHISQKPOJ86D/dIaGh02cc3pURH/mI2a2CQa9Ol1Fwa7nZdX/yJ?= =?us-ascii?Q?MBK7szVEe+fR1cyCv/1Q+dnXY3hWbFlIos/b3TPnB+lHgjzWeZ2If9OHHJRz?= =?us-ascii?Q?mgSxTgR2IJzhhdq0I0wrxg3T5dWKipcOuGs2xJa/ouhoSDXmMuvWv+vduxvz?= =?us-ascii?Q?g0pWjPFwyEUxm0x9Z9dwJtgt0qRRnLa0SCDH9lQPkLTT0mLdCE44/XXmsCbd?= =?us-ascii?Q?LpP2ojJSaU9HiMWsUtnhah6S7ojrvE/K4/M/hqD8hS47z46XC0Z+GuFGOPtS?= =?us-ascii?Q?CRpbXvtGtA5GjUy+Vx8+MK+v?= X-OriginatorOrg: sancloud.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0c14e52-3602-40cb-69ae-08d959a1a9d4 X-MS-Exchange-CrossTenant-AuthSource: CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2021 12:48:32.4562 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 840be37c-244a-450e-9bcc-2064862de1f4 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pfP0Ea3Fe4/AxO02HUWVPBrcfFebP74Kt8d4EQLuyUIsPdP6q+JtolRMPmoXd4q5g6AidJiiLfxxqqdEnfqvkgQ2V2bvAdXWRkktPYZlr78= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP123MB3380 X-Mailman-Approved-At: Sat, 07 Aug 2021 15:43:54 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --Sig_/JFFF67luBPNat2udbTLyZqw Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 7 Aug 2021 14:17:38 +0300 "Matwey V. Kornilov" wrote: > USB nodes were mistakenly disabled in >=20 > commit 942853dd96df ("arm: dts: Resync BeagleBone device trees") >=20 > This commit is to fix the following issue: >=20 > starting USB... > No working controllers found > USB is stopped. Please issue 'usb start' first. > starting USB... > No working controllers found >=20 > Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux= .git/commit/?id=3D0782e8572ce43f521ed6ff15e4a7ab9aa5acdc85 > Fixes: 942853dd96df ("arm: dts: Resync BeagleBone device trees") > Signed-off-by: Matwey V. Kornilov > --- > arch/arm/dts/am33xx.dtsi | 6 ------ > 1 file changed, 6 deletions(-) >=20 > diff --git a/arch/arm/dts/am33xx.dtsi b/arch/arm/dts/am33xx.dtsi > index ce07cec846..b5093020ee 100644 > --- a/arch/arm/dts/am33xx.dtsi > +++ b/arch/arm/dts/am33xx.dtsi > @@ -380,28 +380,24 @@ > #address-cells =3D <1>; > #size-cells =3D <1>; > ti,hwmods =3D "usb_otg_hs"; > - status =3D "disabled"; > =20 > usb_ctrl_mod: control@44e10620 { > compatible =3D "ti,am335x-usb-ctrl-module"; > reg =3D <0x44e10620 0x10 > 0x44e10648 0x4>; > reg-names =3D "phy_ctrl", "wakeup"; > - status =3D "disabled"; > }; > =20 > usb0_phy: usb-phy@47401300 { > compatible =3D "ti,am335x-usb-phy"; > reg =3D <0x47401300 0x100>; > reg-names =3D "phy"; > - status =3D "disabled"; > ti,ctrl_mod =3D <&usb_ctrl_mod>; > #phy-cells =3D <0>; > }; > =20 > usb0: usb@47401000 { > compatible =3D "ti,musb-am33xx"; > - status =3D "disabled"; > reg =3D <0x47401400 0x400 > 0x47401000 0x200>; > reg-names =3D "mc", "control"; > @@ -443,14 +439,12 @@ > compatible =3D "ti,am335x-usb-phy"; > reg =3D <0x47401b00 0x100>; > reg-names =3D "phy"; > - status =3D "disabled"; > ti,ctrl_mod =3D <&usb_ctrl_mod>; > #phy-cells =3D <0>; > }; > =20 > usb1: usb@47401800 { > compatible =3D "ti,musb-am33xx"; > - status =3D "disabled"; > reg =3D <0x47401c00 0x400 > 0x47401800 0x200>; > reg-names =3D "mc", "control"; This looks like the right approach to me. As you noted in your other email, just resyncing am33xx.dtsi isn't as trivial as it seems as all dts/dtsi files which include this would also need resyncing. I focused on just resyncing the files for the BeagleBone and its derivatives as that was more manageable. I did a quick check of am33xx.dtsi for potential incompatibilities but obviously missed this one, thanks for sending this patch to fix it. Reviewed-by: Paul Barker --=20 Paul Barker Principal Software Engineer SanCloud Ltd --Sig_/JFFF67luBPNat2udbTLyZqw Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQS7m7rT1+CktY3YG1PYN3IfEvob6gUCYQ6BFAAKCRDYN3IfEvob 6uGZAP9XlJ4jxOKUAn4jQoRkEkKN1SGVSiC78KinvlzxZj8kswD9E3daZaiAb2gm OQQPu8fZLsk0Gp3zl4NR8Jgc4TF8mgo= =UlDH -----END PGP SIGNATURE----- --Sig_/JFFF67luBPNat2udbTLyZqw--