From: "Pali Rohár" <pali@kernel.org>
To: Luka Kovacic <luka.kovacic@sartura.hr>
Cc: u-boot@lists.denx.de, robert.marko@sartura.hr,
luka.perkov@sartura.hr, marek.behun@nic.cz, sr@denx.de,
sjg@chromium.org, patrick.delaunay@foss.st.com,
xypron.glpk@gmx.de
Subject: Re: [PATCH v3 1/3] arm: mvebu: mvebu_armada-37xx: Implement the mac command (Marvell hw_info)
Date: Fri, 13 Aug 2021 12:29:29 +0200 [thread overview]
Message-ID: <20210813102929.hkgljpeqekvmrj72@pali> (raw)
In-Reply-To: <20210812233938.11633-2-luka.kovacic@sartura.hr>
On Friday 13 August 2021 01:39:36 Luka Kovacic wrote:
> diff --git a/board/Marvell/mvebu_armada-37xx/Kconfig b/board/Marvell/mvebu_armada-37xx/Kconfig
> new file mode 100644
> index 0000000000..b84dd20023
> --- /dev/null
> +++ b/board/Marvell/mvebu_armada-37xx/Kconfig
> @@ -0,0 +1,29 @@
> +menu "Marvell Armada 37xx configuration"
> +depends on TARGET_MVEBU_ARMADA_37XX
> +
> +config MVEBU_MAC_HW_INFO
> + bool "Marvell hw_info (mac) support"
> + depends on SPI_FLASH && ENV_IS_IN_SPI_FLASH && ARCH_MVEBU
> + default n
> + help
> + Enable loading of the Marvell hw_info parameters from the
> + SPI flash hw_info area. Parameters (usually the board serial
> + number and MAC addresses) are then imported into the
> + existing U-Boot environment.
> + Implementation of this command is compatible with the
> + original Marvell U-Boot command. Reading and writing is
> + supported.
> + EEPROM config pattern and checksum aren't supported.
> + After enabled, these parameters are managed from the common
> + U-Boot mac command.
> +
> +config MVEBU_MAC_HW_INFO_OFFSET
> + hex "Marvell hw_info (mac) SPI flash offset"
> + depends on MVEBU_MAC_HW_INFO
> + default 0x3E0000
> + help
> + This option defines the SPI flash offset of the Marvell
> + hw_info area. This defaults to 0x3E0000 on most Armada
> + A3720 platforms.
Just a question, cannot we load this offset from DTS? In DTS are already
specified SPI partitions, so this could eliminate need for defining this
offset at two places. But I really do not know at which time is this
code called, if DTB is available at this time or not.
> +endmenu
next prev parent reply other threads:[~2021-08-13 10:29 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 23:39 [PATCH v3 0/3] Add support for the GST ESPRESSOBin-Ultra board Luka Kovacic
2021-08-12 23:39 ` [PATCH v3 1/3] arm: mvebu: mvebu_armada-37xx: Implement the mac command (Marvell hw_info) Luka Kovacic
2021-08-13 1:43 ` Marek Behún
2021-08-13 8:23 ` Pali Rohár
2021-08-13 9:23 ` Luka Kovacic
2021-08-13 9:41 ` Pali Rohár
2021-08-13 9:51 ` Luka Kovacic
2021-08-13 10:09 ` Pali Rohár
2021-08-13 10:16 ` Luka Kovacic
2021-08-13 10:29 ` Pali Rohár [this message]
2021-08-13 10:43 ` Luka Kovacic
2021-08-13 10:49 ` Pali Rohár
2021-08-12 23:39 ` [PATCH v3 2/3] arm: mvebu: mvebu_armada-37xx: Define the loadaddr environment variable Luka Kovacic
2021-08-13 8:08 ` Pali Rohár
2021-08-13 8:59 ` Luka Kovacic
2021-08-13 9:31 ` Pali Rohár
2021-08-13 9:33 ` Luka Kovacic
2021-08-13 9:42 ` Pali Rohár
2021-08-13 13:59 ` Pali Rohár
2021-08-16 8:21 ` Luka Kovacic
2021-08-16 8:22 ` Pali Rohár
2021-08-12 23:39 ` [PATCH v3 3/3] arm: mvebu: Initial ESPRESSOBin-Ultra board support Luka Kovacic
2021-08-13 8:14 ` Pali Rohár
2021-08-13 9:08 ` Luka Kovacic
2021-08-13 9:54 ` Pali Rohár
2021-08-13 9:58 ` Stefan Roese
2021-08-13 10:25 ` Luka Kovacic
2021-08-13 10:46 ` Pali Rohár
2021-09-24 18:30 ` Pali Rohár
2021-09-27 8:31 ` Luka Kovacic
2021-08-13 9:27 ` Pali Rohár
2021-08-13 10:03 ` Luka Kovacic
2021-08-13 10:22 ` Pali Rohár
2021-08-13 10:33 ` Luka Kovacic
2021-08-13 10:59 ` Pali Rohár
2021-08-16 8:37 ` Luka Kovacic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210813102929.hkgljpeqekvmrj72@pali \
--to=pali@kernel.org \
--cc=luka.kovacic@sartura.hr \
--cc=luka.perkov@sartura.hr \
--cc=marek.behun@nic.cz \
--cc=patrick.delaunay@foss.st.com \
--cc=robert.marko@sartura.hr \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).