From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 470D0C433EF for ; Wed, 8 Sep 2021 11:38:20 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BC31610C8 for ; Wed, 8 Sep 2021 11:38:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9BC31610C8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sancloud.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3C25B82BFD; Wed, 8 Sep 2021 13:38:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sancloud.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=sancloud.onmicrosoft.com header.i=@sancloud.onmicrosoft.com header.b="jZTzyEDF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E29F382BFD; Wed, 8 Sep 2021 13:38:13 +0200 (CEST) Received: from GBR01-CWL-obe.outbound.protection.outlook.com (mail-cwlgbr01on072c.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe14::72c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 77C6A82BFD for ; Wed, 8 Sep 2021 13:38:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sancloud.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=paul.barker@sancloud.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gmSaDnX6kMqQ9CmahiHRUfCrRGipFqXKQfbkjyPs/UBgJas1VInhnbsE0FP5gtHfycvEpz5o0r+1n53QlsY8JmbFo42OlhFypXtrYYNUiu53mrfuAK8mEZTCHrdwt/QQ7XvCj26Q1YQhtT8JdqOjU/J4P1kNaHX6RWMqdRJ9rKNMAuJVmoTZ5I4bnGUGs5GbjPCj4VKRT79yTOoMOxawFYjb4qxwZFX8hWfDqvjT+KB5nLrBPlTnf9Ls6GYngbEiG5NIO5bmqTXZXhSThYdgpPAk6girL0zvZRCiFn2VNK1YXwAYcgToqsstjHD4XR/ws8gLJa8vXSoxrzXbWL/SiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jVI9gQ1NZMVRRpGppTqCKosfNm+G0YfxA+ttQSwZHaA=; b=FBi0A2rOOVPrqcWsJhbUF+6Kua6Xd4sSwfqW+cyag22jAZytnMUbtUTeX3HILdjAYcT0gVcpnm2DtM/JwYHfjLHgU+xnjGMGoUAUmBubJvR4Il2hBBygcyFjszPJids2zunvKBORLTKazcQ1k18Z6D/ZNVorBmj9djsN8l4iD1jMfQ0GorDbbpKuncJZalg/PxTfw51HHc+zGGuuHwHTqr7dq0Sso2GfHY93cFIAiNuTuJLE8ZpID65bOBH6OGw2rQ6MxO4WoHVkes8R/6KWxAmvQPt8TaGnFLix9Gk4Dqk9r8L2S/LbUBQAlS/7leM1WDzAfe7rg5bM4y6TQ1LejQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sancloud.com; dmarc=pass action=none header.from=sancloud.com; dkim=pass header.d=sancloud.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sancloud.onmicrosoft.com; s=selector2-sancloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jVI9gQ1NZMVRRpGppTqCKosfNm+G0YfxA+ttQSwZHaA=; b=jZTzyEDFJjTv8jAoeDpwhXmFI6zdI9ilO5MmBCz50pTEuQI/ZW9S8vGHiWi7s5ERAC7KRw+mpIE21aH15TSFIG7luMS5iNPD62lFhQcBqa++EX+tiYPLmxfoXS4zXmy9WexHpfcNESq/fyiljjBSecWopR32NWfLV3freCyRRB4= Authentication-Results: chromium.org; dkim=none (message not signed) header.d=none;chromium.org; dmarc=none action=none header.from=sancloud.com; Received: from CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM (2603:10a6:401:61::19) by CWXP123MB3045.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:42::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Wed, 8 Sep 2021 11:38:09 +0000 Received: from CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM ([fe80::d45d:1046:b6e9:de6e]) by CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM ([fe80::d45d:1046:b6e9:de6e%7]) with mapi id 15.20.4500.015; Wed, 8 Sep 2021 11:38:09 +0000 From: Paul Barker To: Simon Glass , Tom Rini , u-boot@lists.denx.de Cc: Paul Barker Subject: [PATCH v4 0/2] Refactor and improve full help output from tools Date: Wed, 8 Sep 2021 12:38:00 +0100 Message-Id: <20210908113802.5252-1-paul.barker@sancloud.com> X-Mailer: git-send-email 2.33.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: LO2P265CA0495.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::20) To CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM (2603:10a6:401:61::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from badger.mshome.net (80.7.160.81) by LO2P265CA0495.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.20 via Frontend Transport; Wed, 8 Sep 2021 11:38:09 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ba2de0be-814c-48bc-2e7f-08d972bd21e0 X-MS-TrafficTypeDiagnostic: CWXP123MB3045: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3513; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FHhBI+GwB6X87rnMXLnZjmX2k4NDTIMajRgpp8KEjTTRO7QkbGy1OIiibZglQSXKEhAEji5I/MNQEJJ7O/ovuPYImhDz9vuVGPPoeDL9TOJz8eKiefnBvAlh/Dk1dHFG3S5Si5AoLMxon3GQUwVQ02TLwqCfwG2aLtHvgSJCkQUlFr87ghn292GxMakAULVFRGKTJq4/NDX/SwV0+9wieBMPysHB2azAghMFWQut/pV/iOKO65eWbr1wy45Vz0K1dqAdQfNkldki2G6L4UNaHrrT+V8zUGWfOkuyYpWxlPrzaLLsKWs+mlgKYiosfiIN+ZmBH7nwm8m/Dpori34DHIYDtxIORSQ+RMfQDKw69sRaayoa/RJyEr2a3X4doQ0Q7PzJ2y4IkM4+UIE8W0AYV1QolOWBkSuSjdLPxpsN818DE3L9cdqVNdsqNLR2G8B6BT4jrun2WeMmZIwcFpI0dVF/I4uXmSJ9sq/uReach+LhI04Ly1+K0TLOfETUUrzh8lM0miEvHnBH/+CoDKwtKKGZ3bXhGFs4BAAEB38njatfW8rRDVyDM74iFtLGmUUeyycd9AEtTB1UPpLx93NXwOE4ZaYlXNJMZ7sp2l8ZXL+8st1lVT/hh0b/G2ZkYNa9GSUlg8VKL7LPm+yjESn9rRR4luM9FUfcZ+qOwP57Wz/XvkYmCsiKCSAoKo+FsTIdlwbdaxaOSJ2go0K0hq2XNA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(366004)(39830400003)(346002)(136003)(376002)(396003)(1076003)(2616005)(956004)(186003)(2906002)(83380400001)(508600001)(4326008)(6506007)(6486002)(110136005)(52116002)(6666004)(8676002)(6512007)(8936002)(316002)(38350700002)(38100700002)(26005)(36756003)(66946007)(66556008)(66476007)(107886003)(5660300002)(44832011)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ik3qR9KTJ664jBpkAAbA/ugR7V5LioQ7R26Ea2stYHezxI8ZmJhPxkJjBymZ?= =?us-ascii?Q?HV2DPc8X4V+zUrvAvACF9glpUgxEDoJ4fbRe0u952CPSismSzJFHaUlqNjaV?= =?us-ascii?Q?eFhpdomlCkXt1kmlZoatOXsnMzQYYgLbyoj2o/a0DRG6G5oNnTApmTeaaKZX?= =?us-ascii?Q?9t4Pt9BXZoK/RYUnFky05jal33ETt5FYGrVyfcRasyIvJT55DPiZCTVxe6il?= =?us-ascii?Q?MGAvwgtI708zVKlUg9E3R9kXYXR4bPZNpfYvZi4FVx8vlXPMpGRqhYUQx8cT?= =?us-ascii?Q?k71timX8lSqdST4FiwQK6eM2WYsdMFTuQiWzZXiUtQUgdVgnr/FYUoWqg8Nt?= =?us-ascii?Q?06dqBQEw/rlN1OTJHWYQJRZdbbSSWTRbb9BILqUUWu6uvooGoIR/lSlPuJ0U?= =?us-ascii?Q?W1NZ8x+O8VuXqhHDTZhI/8WON/L9ajsLiIbjXPE+ti4JM4bnI+saO5jQppiA?= =?us-ascii?Q?NYefcVc1mvSgzLfqGCmLKQ1PatNceg9rgn03GRAiFCd16pO60KaPRBnirhMl?= =?us-ascii?Q?IW4nY4naphQhCs6GhdhBydijKEAze7dEkTAe2JoWiVDQ98jNIx+5IX70o7YK?= =?us-ascii?Q?nLSC2TcSWvUOyg99AtiRlpv1p7P+HbIG5Rfn9OLz5EoEOTjHxrhx+7cr2dk8?= =?us-ascii?Q?31+aeepViFR86tzEgv8xWEfhSoynBm8TbYQLIguJnf1EBUGXzWY4VvRG0YnT?= =?us-ascii?Q?OVnUdOitvLCRmpN5GiBtJOvqzVq98JlQtGgA74TrJi9Qq4UoX8BMZWkMzTeN?= =?us-ascii?Q?aLcrwwqqifVZLkA+rC+eUCge1znGLsBZmd8PTBxhLc5bz5QABR4/EeEERQsH?= =?us-ascii?Q?dKl5J/yedOF3ishueEiasfYFurgJ/duHmxeikuEJa9IikE9S2idcn0zCCjhZ?= =?us-ascii?Q?oxGZQnNzWb15IDS4ogR5QPpjGChTFjOijvyB9akVo2lNy1GkPSSf/DEWZpIJ?= =?us-ascii?Q?PtBgipqqllXUgZXgVpRhS3GFRC4pbgkI6TVrH4ShpUa0h+hkazilux9QC0Rc?= =?us-ascii?Q?cH1PqBL6n4T0DlrvfoSr7b6/wk6gOCbRaMSqAjGvsWJJ4ThqFoPfRcFvGNYX?= =?us-ascii?Q?ukweY5ABTGRMAZu5LY1BnjSjnU0fNuT3G9TH43YJ7/YtJ3lMnASuaHFqjmxF?= =?us-ascii?Q?wJmhXAYbeTeQdGdLrU2CzGZHiqqQifiudtnscLcQUiHGkqiEWFaJZPG7xPJk?= =?us-ascii?Q?XAf2JdEAJYmAHog38fi22mSdFOEjwizgfVy1v6STASZ8t0/XVGkROSIN6M6O?= =?us-ascii?Q?P7enoIrjAhcEzFRiV9H4kh98qttF8/25SF/wHrwYVbPiw0L+448+R67FBnCy?= =?us-ascii?Q?eeMJ4+F7ZPFOlMswzpeFC1c+?= X-OriginatorOrg: sancloud.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba2de0be-814c-48bc-2e7f-08d972bd21e0 X-MS-Exchange-CrossTenant-AuthSource: CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 11:38:09.3270 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 840be37c-244a-450e-9bcc-2064862de1f4 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GpynmsVXv+n0OuOmpB//tVdOGaS29PtYcQk/Tt8HIFSt+WH/5VvprbbwNonvsHUJCFag8LSxFrsqGDBruw1tognukk5Oa/1Vm1S63Z9yDXc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP123MB3045 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Changes from v3: * I found some more Python madness: >>> bool([]) False >>> bool([None]) True So we need to ensure that if `shlex.which(less)` returns None we don't set pager to `[None]` else we won't be able to fall back to using more as the pager. Apologies for the noise in having to send v4 so quickly! Changes from v2: * Handle the case where `PAGER` is unset. For some absolutely crazy reason `shlex.split(None)` reads the string to split from stdin so we need to ensure that `os.getenv()` returns an empty string instead of None if `PAGER` is unset. Changes from v1: * Collected the full help printing code from patman, buildman & binman into a single function so that when support for PAGER containing arguments is added it applies to all the relevant tools. Paul Barker (2): tools: Refactor full help printing tools: Handle PAGER containing arguments tools/binman/control.py | 9 +++------ tools/buildman/control.py | 10 ++++------ tools/patman/main.py | 12 ++++-------- tools/patman/tools.py | 15 +++++++++++++++ 4 files changed, 26 insertions(+), 20 deletions(-) -- 2.33.0