From: "Pali Rohár" <pali@kernel.org>
To: Simon Glass <sjg@chromium.org>, Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: u-boot@lists.denx.de
Subject: [PATCH 1/2] xyz-modem: Wait infinitely for initial y-modem packet
Date: Fri, 10 Sep 2021 22:46:52 +0200 [thread overview]
Message-ID: <20210910204653.3066-1-pali@kernel.org> (raw)
Now when command loady can be aborted / cancelled by CTRL+C, change wait
timeout for initial packet to infinite. This would allow user to not be
hurry when locating file which want to send. Commands loadb and loads
already waits infinitely too.
Signed-off-by: Pali Rohár <pali@kernel.org>
---
common/xyzModem.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/common/xyzModem.c b/common/xyzModem.c
index ece25acb183b..d6be489a174b 100644
--- a/common/xyzModem.c
+++ b/common/xyzModem.c
@@ -449,8 +449,14 @@ xyzModem_stream_open (connection_info_t * info, int *err)
return 0;
}
- while (retries-- > 0)
+ while (1)
{
+ if (--retries <= 0)
+ {
+ retries = xyzModem_MAX_RETRIES;
+ crc_retries = xyzModem_MAX_RETRIES_WITH_CRC;
+ xyz.crc_mode = true;
+ }
stat = xyzModem_get_hdr ();
if (stat == 0)
{
--
2.20.1
next reply other threads:[~2021-09-10 20:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 20:46 Pali Rohár [this message]
2021-09-10 20:46 ` [PATCH 2/2] xyz-modem: Wait infinitely for initial x-modem packet Pali Rohár
2021-09-13 10:43 ` Wolfgang Denk
2021-09-13 10:42 ` [PATCH 1/2] xyz-modem: Wait infinitely for initial y-modem packet Wolfgang Denk
2021-09-13 11:08 ` Pali Rohár
2021-09-13 12:12 ` Wolfgang Denk
2021-09-13 12:22 ` Pali Rohár
2021-09-13 13:02 ` Wolfgang Denk
2022-08-27 11:50 ` Pali Rohár
2021-09-13 14:32 ` Tom Rini
2022-08-27 11:48 ` [PATCH v2] xyz-modem: Allow to configure initial timeout for loadx and loady Pali Rohár
2022-08-27 12:53 ` Tom Rini
2022-08-27 12:56 ` Pali Rohár
2022-08-27 14:30 ` Tom Rini
2022-08-27 14:32 ` Pali Rohár
2022-08-27 14:41 ` Tom Rini
2022-08-27 14:47 ` Pali Rohár
2022-08-29 14:54 ` Heinrich Schuchardt
2022-08-27 14:37 ` [PATCH v3] " Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210910204653.3066-1-pali@kernel.org \
--to=pali@kernel.org \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).