From: Pratyush Yadav <p.yadav@ti.com>
To: <tkuw584924@gmail.com>
Cc: <u-boot@lists.denx.de>, <jagan@amarulasolutions.com>,
<vigneshr@ti.com>, <Bacem.Daassi@infineon.com>,
Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
Subject: Re: [PATCH 1/2] mtd: spi-nor-ids: Add support for Spansion S25FL256L
Date: Fri, 17 Sep 2021 22:17:32 +0530 [thread overview]
Message-ID: <20210917164730.yquamxiqeto4epxh@ti.com> (raw)
In-Reply-To: <b282d36f73480877e5b3b6da3bd81b4f95fe2245.1631088494.git.Takahiro.Kuwano@infineon.com>
On 08/09/21 05:47PM, tkuw584924@gmail.com wrote:
> From: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
>
> The S25FL256L is a part of the S25FL-L family and has the same feature set
> as S25FL128L except the density.
>
> The datasheet can be found in the following link.
> https://www.cypress.com/file/316171/download
>
> Tested on Xilinx Zynq-7000 FPGA board.
I think you should add fixups and the flash entry in the same commit
instead of adding them in separate ones. This would make sure the flash
works correctly if someone lands on this commit when bisecting.
The patch LGTM otherwise.
>
> Signed-off-by: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
> ---
> drivers/mtd/spi/spi-nor-ids.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index 4aef1ddd6e..11d7d4fcaa 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -227,6 +227,7 @@ const struct flash_info spi_nor_ids[] = {
> { INFO("s25fl208k", 0x014014, 0, 64 * 1024, 16, SECT_4K | SPI_NOR_DUAL_READ) },
> { INFO("s25fl064l", 0x016017, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
> { INFO("s25fl128l", 0x016018, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
> + { INFO("s25fl256l", 0x016019, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
> { INFO6("s25hl512t", 0x342a1a, 0x0f0390, 256 * 1024, 256,
> SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES |
> USE_CLSR) },
> --
> 2.25.1
>
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
next prev parent reply other threads:[~2021-09-17 16:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 8:47 [PATCH 0/2] mtd: spi-nor: Add support for Spansion S25FL256L tkuw584924
2021-09-08 8:47 ` [PATCH 1/2] mtd: spi-nor-ids: " tkuw584924
2021-09-17 16:47 ` Pratyush Yadav [this message]
2021-09-08 8:47 ` [PATCH 2/2] mtd: spi-nor-core: Add fixups " tkuw584924
2021-09-17 16:51 ` Pratyush Yadav
2021-09-29 5:22 ` Takahiro Kuwano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210917164730.yquamxiqeto4epxh@ti.com \
--to=p.yadav@ti.com \
--cc=Bacem.Daassi@infineon.com \
--cc=Takahiro.Kuwano@infineon.com \
--cc=jagan@amarulasolutions.com \
--cc=tkuw584924@gmail.com \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).