From: Pratyush Yadav <p.yadav@ti.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Jagan Teki <jagan@amarulasolutions.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Mike Frysinger <vapier@gentoo.org>
Subject: Re: [PATCH v4 3/5] sf: Tidy up code to avoid #ifdef
Date: Mon, 20 Sep 2021 16:38:07 +0530 [thread overview]
Message-ID: <20210920110804.y45c26bkvyyaczgy@ti.com> (raw)
In-Reply-To: <20210919214937.3829422-4-sjg@chromium.org>
Hi Simon,
On 19/09/21 03:49PM, Simon Glass wrote:
> Update this code to use IS_ENABLED() instead.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
>
> Reviewed-by: Pratyush Yadav <p.yadav@ti.com>
Nitpick: Trailers shouldn't have a blank line between them. I see it for
this patch and 4/5 as well. It probably doesn't matter, but I wonder if
it will trip up some tools that work on commit trailers like
git-interpret-trailers. Something you might want to fix in your
workflow...
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
next prev parent reply other threads:[~2021-09-20 11:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-19 21:49 [PATCH v4 0/5] sf: Add documentation and an 'sf mmap' command Simon Glass
2021-09-19 21:49 ` [PATCH v4 1/5] command: Use a constant pointer for the help Simon Glass
2021-10-08 12:40 ` Jagan Teki
2021-11-13 11:13 ` Heinrich Schuchardt
2021-11-24 17:47 ` Simon Glass
2021-11-24 17:47 ` Simon Glass
2021-09-19 21:49 ` [PATCH v4 2/5] sf: Use const for the stage name Simon Glass
2021-10-08 12:41 ` Jagan Teki
2021-11-13 11:15 ` Heinrich Schuchardt
2021-11-24 17:47 ` Simon Glass
2021-11-24 17:47 ` Simon Glass
2021-09-19 21:49 ` [PATCH v4 3/5] sf: Tidy up code to avoid #ifdef Simon Glass
2021-09-20 11:08 ` Pratyush Yadav [this message]
2021-09-24 2:48 ` Simon Glass
2021-10-08 12:41 ` Jagan Teki
2021-11-24 17:47 ` Simon Glass
2021-11-24 17:47 ` Simon Glass
2021-09-19 21:49 ` [PATCH v4 4/5] sf: doc: Add documentation for the 'sf' command Simon Glass
2021-10-08 12:42 ` Jagan Teki
2021-11-13 11:34 ` Heinrich Schuchardt
2021-11-13 14:21 ` Simon Glass
2021-11-13 15:26 ` Heinrich Schuchardt
2021-11-13 18:14 ` Simon Glass
2021-11-24 17:47 ` Simon Glass
2021-11-24 17:47 ` Simon Glass
2021-09-19 21:49 ` [PATCH v4 5/5] sf: Provide a command to access memory-mapped SPI Simon Glass
2021-10-08 12:47 ` Jagan Teki
2021-10-08 20:29 ` Simon Glass
2021-11-13 11:47 ` Heinrich Schuchardt
2021-11-25 0:12 ` Simon Glass
2021-11-13 3:17 ` [PATCH v4 0/5] sf: Add documentation and an 'sf mmap' command Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210920110804.y45c26bkvyyaczgy@ti.com \
--to=p.yadav@ti.com \
--cc=jagan@amarulasolutions.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=vapier@gentoo.org \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).