From: Tom Rini <trini@konsulko.com>
To: Wasim Khan <wasim.khan@oss.nxp.com>
Cc: priyanka.jain@nxp.com, v.sethi@nxp.com, u-boot@lists.denx.de,
Wasim Khan <wasim.khan@nxp.com>
Subject: Re: [PATCH] board/freescale/vid : move platform specific definitions
Date: Tue, 21 Sep 2021 10:43:49 -0400 [thread overview]
Message-ID: <20210921144349.GF8579@bill-the-cat> (raw)
In-Reply-To: <20210921142457.3485758-1-wasim.khan@oss.nxp.com>
[-- Attachment #1: Type: text/plain, Size: 558 bytes --]
On Tue, Sep 21, 2021 at 04:24:57PM +0200, Wasim Khan wrote:
> From: Wasim Khan <wasim.khan@nxp.com>
>
> VID is a common driver. Move platform specific definitions
> to platform specific header files
>
> Signed-off-by: Wasim Khan <wasim.khan@nxp.com>
> ---
> board/freescale/common/vid.h | 10 ----------
> include/configs/lx2160a_common.h | 7 +++++++
> 2 files changed, 7 insertions(+), 10 deletions(-)
NAK. Things need to move out of include/configs/ and not in to them,
please find another common header file to use.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-09-21 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 14:24 [PATCH] board/freescale/vid : move platform specific definitions Wasim Khan
2021-09-21 14:43 ` Tom Rini [this message]
2021-09-24 8:36 ` Wasim Khan (OSS)
2021-09-24 11:53 ` Tom Rini
2021-09-24 20:27 ` Wasim Khan (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210921144349.GF8579@bill-the-cat \
--to=trini@konsulko.com \
--cc=priyanka.jain@nxp.com \
--cc=u-boot@lists.denx.de \
--cc=v.sethi@nxp.com \
--cc=wasim.khan@nxp.com \
--cc=wasim.khan@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).