From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADE51C433F5 for ; Wed, 22 Sep 2021 19:41:27 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D472961038 for ; Wed, 22 Sep 2021 19:41:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D472961038 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 15F2183333; Wed, 22 Sep 2021 21:41:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="mDa2rDUr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2AD8D8331E; Wed, 22 Sep 2021 21:41:23 +0200 (CEST) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 21D6283314 for ; Wed, 22 Sep 2021 21:41:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x729.google.com with SMTP id t4so13546798qkb.9 for ; Wed, 22 Sep 2021 12:41:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cNUWGOyFKR1d4DW9zzXncdC0W4gGiZ6rT0qL3W7jxFA=; b=mDa2rDUrKWX5EfJypRb0RGiN7Ck5Y3rcPl7XTUNT91bfUDDoUQhu6lpXlwvZbQZHKW u8gynqdaQ0x1zNSFOGWmR9OTWKzLjjhQlfphc/QAizvvGRWJ83Wf8JCyjmHfmS4vZkAE mej7aXncvqbzXkSMov3e1Dhu3LYCxQXDpq7x4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cNUWGOyFKR1d4DW9zzXncdC0W4gGiZ6rT0qL3W7jxFA=; b=auWdMPjyXXZf2/V6C3eNkL65rzF3q5VISTaCGFkLB+FmxlcZCe/k1GCQUFNCHT9dvu dGcinBbCYGKTriKWSt+Bt13kIGC3+8dNmKXMqY0vq/mQ67WiJEdKc3v/NJwllQHG0Aiw MmsgfwnH+E5j154g1yFzYLsZ77BX+x1DY07S4ZR0fU79rtDGVho4mG0cIho6xQDpmLmm vqVRq70peDeZ6BgHNQpSD1cnI4Ki4rkiSGtXAmKUKyfi0zSBfbSo5GSHj5TaCxakJMCO 5fMMd/hM1Y48ETAqLS8nmGnIv4tLIelm891z3ij94mo+82gfrAu2pHwp+bD6BaqpbN6p xowQ== X-Gm-Message-State: AOAM530hRZn2HnzV7kdrMEc8+kP92wm/iHpnbnqtlID0Z13ROZB/dz3y tR5TpHkpT0ZCXydz9LqHWNV8BQ== X-Google-Smtp-Source: ABdhPJwFcgJiE8dXrYklvwFKKj+V4yOSi4gnp90TE4urYp+cskMCie+TrGqdOPWp3lyeVnQpwzFweQ== X-Received: by 2002:a05:620a:1723:: with SMTP id az35mr1092752qkb.2.1632339677851; Wed, 22 Sep 2021 12:41:17 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-a58e-d475-4878-38e2.res6.spectrum.com. [2603:6081:7b01:cbda:a58e:d475:4878:38e2]) by smtp.gmail.com with ESMTPSA id w185sm2649725qkd.30.2021.09.22.12.41.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 Sep 2021 12:41:17 -0700 (PDT) Date: Wed, 22 Sep 2021 15:41:15 -0400 From: Tom Rini To: Marek Vasut Cc: Marek =?iso-8859-1?Q?Beh=FAn?= , Patrick Delaunay , u-boot@lists.denx.de, Pali =?iso-8859-1?Q?Roh=E1r?= , Jagan Teki , Christophe KERELLO , Miquel Raynal , Priyanka Jain , Patrice Chotard , Heiko Schocher , Simon Glass , Vignesh R , U-Boot STM32 Subject: Re: [PATCH v4 0/2] mtd: spi: nor: force mtd name to "nor%d" Message-ID: <20210922194115.GB31748@bill-the-cat> References: <20210922162909.1857566-1-patrick.delaunay@foss.st.com> <20210922192925.723abcba@thinkpad> <20210922210536.6c9c2f9e@thinkpad> <56df80f7-aa1d-3cff-5b29-16fdafcf7bcf@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mojUlQ0s9EVzWg2t" Content-Disposition: inline In-Reply-To: <56df80f7-aa1d-3cff-5b29-16fdafcf7bcf@denx.de> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --mojUlQ0s9EVzWg2t Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 22, 2021 at 09:24:24PM +0200, Marek Vasut wrote: > On 9/22/21 9:05 PM, Marek Beh=FAn wrote: >=20 > Hi, >=20 > [...] >=20 > > > > I find this either not complete or not needed: > > > >=20 > > > > - either you need mtd names to be of this format so that old MTDPAR= TS > > > > config definitions do not need to be changed, i.e. something li= ke > > > > CONFIG_MTDPARTS_DEFAULT=3D"nor0:1M(u-boot),0x1000@0xfff000(en= v)" > > > > does not work currently, and you want to make it work. > > > >=20 > > > > I find your solution here incomplete because MTDPARTS can also = be > > > > used to be passed to Linux as mtdparts parameter, but there is = no > > > > guarantee that the "norN" numbering you are creating in U-Boot = will > > > > be the same as the one in kernel. > > > >=20 > > > > - or it is not needed, because you can remove MTDPARTS definition f= rom > > > > the board config entirely and move the information into device = tree. > > > > In fact this was the main idea behind making the series > > > > Support SPI NORs and OF partitions in `mtd list` > > > > The SPI-NOR MTDs after this series can have conflicting names, > > > > because you can still choose between them via OF path with the = `mtd` > > > > command. > > > >=20 > > > > Tom and I were of the opinion that MTDPARTS should be deprecate= d and > > > > removed in favor of OF. Marek Vasut says that this is not possi= ble > > > > for every board, and so needs to stay. > > > >=20 > > > > BTW, I find it a little weird for Marek to defend old API which sho= uld > > > > be converted to DT, when in discussion about DM USB / Nokia N900 > > > > USB TTY console [1] he was defending the opinion that we should be > > > > heading to DT in U-Boot. > > > >=20 > > > > [1] > > > > https://patchwork.ozlabs.org/project/uboot/patch/20210618145724.255= 8-1-pali@kernel.org/ > > >=20 > > > That USB discussion is completely unrelated to the problem here, the = USB > > > discussion is about internal (i.e. not user facing) conversion to DM/= DT. > > > The user-facing ABI does not change there. Also, that discussion was > > > about patching USB stack to permit new non-DM/DT operation, not fixing > > > existing one. > >=20 > > This is not only about the user ABI (altough now I agree that you are > > correct there, see below). What I meant is this: > > Should we push for converting to device-tree even if for some boards > > it is not possible, and would mean removing them? >=20 > The N900 could however be converted to DT as far as I can tell, there was= a > solution which didn't end up patching the USB core with legacy stuff. Just for the record and to hopefully end this specific tangent, the "fix" at the time was to correct the "CONFIG_USB means host or gadget" so that N900 has more time (and an active developer on) migrating gadget as it does not use host. --=20 Tom --mojUlQ0s9EVzWg2t Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFLhtcACgkQFHw5/5Y0 tyxd6wwAhM3zmgvF4sCvPVoYJjDvZdfKP/5CiXPUiJLA1Effj2lTGOe6OzxBf2yA Ar27XAqVvRrci/cVL3Osy9B3p270mGlAA6jIm7yEy8NuTOo+GeeB179ba/32xgdi ARFcTRMRQDYDy/8yedMxu93EjlqXJs1PxCwJeHgHNxU5jhnyJlikqjr5Jal+DTf1 4Y4E9FqTGk3aA0kuuqkQvtsis02zF2geBgZx9AoYClHREoSmDHZJ/yB1/+ZxuA+T 3GmdSF47BbIG6Dk3+KsVMzdYhbKbrV41XpylSLsIVAiclRlI3rpc/XVqlrm7ew/l aqql4R4slF5bhapkxpd17BdGdxJzUUGQwU3BQRr8uKVlgZ2Q6gfl0xp9MQ1TbLIB 3BaFgmR6jeFUwFt4xodFqorpl0QUDJkyrp1oYpVSx0YXQWc4xxjxk/ZjJKpHaDdO /pEhgxmEMm+EC49KXiUrdnIfA/1rmlnWoM5Wora5O3dt3hobeJhvVP/OHNwwjZML +nWS/6e0 =FW9R -----END PGP SIGNATURE----- --mojUlQ0s9EVzWg2t--