From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67575C433F5 for ; Fri, 24 Sep 2021 11:53:50 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6DCBB60F9C for ; Fri, 24 Sep 2021 11:53:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6DCBB60F9C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C276283400; Fri, 24 Sep 2021 13:53:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="qh/wXwdJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E52AD83400; Fri, 24 Sep 2021 13:53:43 +0200 (CEST) Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 807DD8338C for ; Fri, 24 Sep 2021 13:53:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf36.google.com with SMTP id a12so6079202qvz.4 for ; Fri, 24 Sep 2021 04:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0Bao6hYKe/GB47vvNAW/dhezRSWgFANp1A7n/fZ2apg=; b=qh/wXwdJKjbZOq8uZX+Yw93T3udXns6MtIhlSKCsmutiN2CEsB03mpo2ktUkp4/pMn V4FccFUdPdtgm6UpaYxzBHKRg7gBfWT77hh/V/txbWqjLCuuxok4LwMjNzYNvUt9IcvO HzetHkHL2gZbpiIBGLH1aijTCGUFJq+aZc7aM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0Bao6hYKe/GB47vvNAW/dhezRSWgFANp1A7n/fZ2apg=; b=QUnOd8afbBqm6NQeYtTtMTNl/IvSbiFUBhWmkChSpczgGlyVG6MibxZLtIDXu60kFj A0narP+4U/bTQpDr1mcX3hQ+l4jsNPRcQag13Y/OxSraj/PBt2unpl+HdHzOr/LL60F6 0GJp7zWgTj/dhJ9gf/6CQN3z12tec2cFNpQjv1Dv62c/S0yIqU20Vjkkr5PtZqEs3Nki rKpgD5nlfogWXJ2sgpWMpdWsvCQZ7dZ1ZR6EutXVSPh9DdMjj4z8Cv0x57Z8dwSWetJB KQGZ0lwPaWxjqzQUzJ6zciWjiEIvAZH8BFt4ymTW1bhdQj30syMGQjez2SnZ1+y503IC 9sYA== X-Gm-Message-State: AOAM532YOWUkFFl0mWgT0OLhaCEKGRImOKsuvJL0x5cPEa5eIP8eVPE2 7SzvZKdpCHSyHg3m9128VItMVg== X-Google-Smtp-Source: ABdhPJwFDzpMhxDrlH7BsCz5r973h0Pw5XPGNEZH+mce6sAdhn6n2sXGNG8ehKsQzJYoEK23sv0pGA== X-Received: by 2002:ad4:44e4:: with SMTP id p4mr9618456qvt.40.1632484419285; Fri, 24 Sep 2021 04:53:39 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-11b7-7bd8-71db-92e9.res6.spectrum.com. [2603:6081:7b01:cbda:11b7:7bd8:71db:92e9]) by smtp.gmail.com with ESMTPSA id z10sm5212566qtv.6.2021.09.24.04.53.38 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 Sep 2021 04:53:38 -0700 (PDT) Date: Fri, 24 Sep 2021 07:53:36 -0400 From: Tom Rini To: "Wasim Khan (OSS)" Cc: Priyanka Jain , Varun Sethi , "u-boot@lists.denx.de" Subject: Re: [PATCH] board/freescale/vid : move platform specific definitions Message-ID: <20210924115336.GA31748@bill-the-cat> References: <20210921142457.3485758-1-wasim.khan@oss.nxp.com> <20210921144349.GF8579@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zDL9gdIhmXu2QQXr" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --zDL9gdIhmXu2QQXr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 24, 2021 at 08:36:45AM +0000, Wasim Khan (OSS) wrote: > Hi Tom, >=20 > > -----Original Message----- > > From: Tom Rini > > Sent: Tuesday, September 21, 2021 8:14 PM > > To: Wasim Khan (OSS) > > Cc: Priyanka Jain ; Varun Sethi ; u- > > boot@lists.denx.de; Wasim Khan > > Subject: Re: [PATCH] board/freescale/vid : move platform specific defin= itions > >=20 > > On Tue, Sep 21, 2021 at 04:24:57PM +0200, Wasim Khan wrote: > >=20 > > > From: Wasim Khan > > > > > > VID is a common driver. Move platform specific definitions to platform > > > specific header files > > > > > > Signed-off-by: Wasim Khan > > > --- > > > board/freescale/common/vid.h | 10 ---------- > > > include/configs/lx2160a_common.h | 7 +++++++ > > > 2 files changed, 7 insertions(+), 10 deletions(-) > >=20 > > NAK. Things need to move out of include/configs/ and not in to them, p= lease > > find another common header file to use. > >=20 > > -- > > Tom >=20 > Thank you so much for review. > Header files 'include/configs/' are auto picked for platform we are using= =2E=20 > I find it useful especially for common drivers like VID to auto pick requ= ired values for underneath platform from 'include/configs/.h' and we don't need changes in common driver. >=20 > (arch/Kconfig) > config SYS_CONFIG_NAME > string > help > This option should contain the base name of board header file. > The header file include/configs/.h > should be included from include/config.h. >=20 >=20 > (Same is recommended for add/remove boards: doc/README.kconfig) > Define CONFIG_SYS_CONFIG_NAME=3D"target" to include > include/configs/.h >=20 >=20 > Currently all NXP platforms (except LX2 series) are using CONFIG_SYS_CONF= IG_NAME to include platform specific header file for VID driver. I extended= the support for LX2 and because the changes are common for lx2160ardb, lx2= 160aqds and lx2162aqds , I added them to lx2160a_common.h.=20 >=20 > Do you want me to move changes from ' include/configs/lx2160a_common.h' t= o ' include/configs/lx2160ardb.h', ' include/configs/lx2160aqds.h' and ' i= nclude/configs/lx2162aqds.h' ? > =20 > Or you want me to avoid adding anything to 'include/configs/.h ' files ? Is there any reason to do so ? I want you to find a place outside of include/config/ for these values to reside, yes. The long term goal of moving everything to Kconfig means that we will not have include/config/ headers anymore. Further, values like this which are not actually user-configurable should neither be CONFIG-prefixed (which these are not, good!) nor reside in include/config/ at all. There should be some appropriate header perhaps under arch/arm/include/asm/arch-fsl-layerscape/ to put these values. And if they need to be shared a bit wider, a fsl-layerscape-common or similar directory could be used (similar to arch/arm/include/asm/ti-common/). Does this make sense? Thanks. --=20 Tom --zDL9gdIhmXu2QQXr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFNvDYACgkQFHw5/5Y0 tyxjBgv/WU5Q3JSpC0Er9mbrrNiLmr86IYu7mwRgY7rfJyD82fUFRJojl+d74Ogz VZq/Pe97Ityf5xooY/raDhYY2wGMIcCW81Rv0o/qOuVmz27NYq2GVJE58zo77HhQ OVGXQqK0KTkFiiD61KGIJYNWTCUsW6nPvHYqKPzILzPIOP/7OIJqTam5QR302GB1 g8HG1c1Hedwb5x7YrhoBKMpPh928T0C3FWU2on0zz5DpsGFazI/E0qsRxxrVUMxi T1STTJxBbcVnIwuGi6ak4Lohgy9nL0mtm+aIeGIy53CHbqedbJtPKP9fQWBPMQfY 8Mgtbnp8wGF//l931cjew9tekxeBpMdSPxw6ddufTivMDIaa1LgqEaGENbjwP8/P 1VkZsdg1M7NbYMiu0e/75wlxUbklN9xuqHEtzzxqt66rlIhWSskmRRJet7H8SJQj PGSrrvqCWU4JgXirxjWKJJ1KySBtxhkl0X5b14TXqfwEsu7RczrD/PksykPL4KdT +HbURiPs =Xr6n -----END PGP SIGNATURE----- --zDL9gdIhmXu2QQXr--