From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07418C433EF for ; Mon, 27 Sep 2021 11:26:58 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 821C660D42 for ; Mon, 27 Sep 2021 11:26:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 821C660D42 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8430C8357A; Mon, 27 Sep 2021 13:26:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="VQENweQi"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 60B318362D; Mon, 27 Sep 2021 13:22:46 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20602.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1a::602]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D42D383607 for ; Mon, 27 Sep 2021 13:22:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V7H8j2n7onNPBoZizkn+ksh44ZxDkBHH9b/OwaM5LKf1eDlKji1gcu/yfyS/fEUudMI/+wQEQvhwKU7VZwBujWmZFYj99OPWHqlBqOUnv5veK6YTLImZQExP80lqdujhCagfF4CH/gKC5MLAgz7VBQYJcANNJrHqJH2a6JP5ZLPj+5iInUUNiCyoe8ELL71FvYx4a+Nk+y4CbcdjTEtxZpgjJvuiYWTrVP2Ryox3AzkriDlbrwGlSCxVDM+oYFPe1p2L2e5l659hvn8kepG6VEa4sr4GS+UxedjMa7fe9TdEpVEpYlr6aV7WeW/YlfAnNLEqovo11nnEZVPY3Xdi3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=PxgbChoUVmn5uRkQFCZn2+vf+/IoTYk3K+V+77Yc8/s=; b=WBm8YHRpVixZCqs6vlbL9HWFm/aTPFI79GSHwXNOf4iHgSiCUaM3G79uRz1YdEAoLB5jpPVI/3EyLSQocTJ/x/ZiGZzJ+HZ1OjoKo6c/vhsOSt0cSoqz6YpXZztc3eGsz3+8dfC8McWMtwJokWfmPsViPSzxqoPN3yAVt/IQheg7vGWW93peu81r3Cid8sT38yvF9gcr3M2WYQ3/h7NTLT4kZ3RjQCecppPhunMiyX6EKwMF+mEmLau8Zw1ERbk39AzdGxZJLkwJ+Evox5xmwBvSn7Q/aGQhERDYizAJ962QZ8ckXbwQ6sNj3Y4ZkdRRE0qaCjhZEr2bnSeECk1XpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PxgbChoUVmn5uRkQFCZn2+vf+/IoTYk3K+V+77Yc8/s=; b=VQENweQithFBLqjeSC/FG4Y8vHs/T89yQr5hD9ydRsFWNa/x6iBIBcgeAzICwW5JKIvlHsNzph0YPhr4fbrsfxld7w7APq4pqx7M4rSHh/tnBYVYM886CJc9r1z7omLv9/I58OGKNH8NRBePijS+byf34AqmlTAgU9Jq6Uuu9d0= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR04MB5503.eurprd04.prod.outlook.com (2603:10a6:803:d1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Mon, 27 Sep 2021 11:22:24 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4%5]) with mapi id 15.20.4544.021; Mon, 27 Sep 2021 11:22:24 +0000 From: Vladimir Oltean To: u-boot@lists.denx.de Cc: Joe Hershberger , Ramon Fried Subject: [PATCH 11/25] net: lpc32xx: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation Date: Mon, 27 Sep 2021 14:21:51 +0300 Message-Id: <20210927112205.301876-12-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210927112205.301876-1-vladimir.oltean@nxp.com> References: <20210927112205.301876-1-vladimir.oltean@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 Received: from localhost.localdomain (188.26.53.217) by AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13 via Frontend Transport; Mon, 27 Sep 2021 11:22:24 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a07fec82-df53-49bb-cf7d-08d981a914b4 X-MS-TrafficTypeDiagnostic: VI1PR04MB5503: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a//hnc2TA3ZS7fC+XLssBgwbrv3ywIAt/FjWPo7j9GwBKorY6h7fcdC4dn495/JwKCJAbleZeHJH1UsfXVJ6aDD6jMkV1xVZ5HbO+4W/1G7kv9AAzn0FLdYSO4bEjsV804yflFzz6imu+3zyb85vx8CU0SENDXyvS4NjBfbD6aMqDXUOiOkdSofcXtUpjZeR9ewsu2ao3Tv9kyeAxufeWHXH2RXrxRIYwNF7l73iBp4+NuK/WVZrhUKXYuCkMVZFN4HV8eLl52RMRonmWTKhL36FgLKhPeBM01Bqv7uPBZr+0uEtog5wujAU4VEdtT1a7+inBdqboTkXU8Ivj0BlR5cNP1i3dA14CIu2X2rycUs0HwCu2HuiCHexU8enJE/TNchvax3aZfSHN9Do/IEFC5sDROLblbN2KyfhilHbjrrXozjb2EJHpbtTdRTqOG2eLawJn5ivZsB8IlY/mw75sitpykXbb7jiOpjqkrnXaR81Gu2QZDPaNScPwjB5u/IDrKaLhhPVJF9vYrLAz4hvm/JTo2+qrbms8uugODndZ0vfmEpO51gtM3W0UIjnsu+3PxTtKLgcQCZcxYzDjSp/PjVU3dUZUNT0YS3rGt5oHfoENXHclzVNRi31VWJ6VIVY/5TpMnW4f26Xd1AsXh20mPMelcX4GtPCkVGm2xSoBe0Qdhc7Dx5lx2QDYXZGmSHi0duwSweMZhMTq6zaLgLRbg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6512007)(5660300002)(956004)(6506007)(52116002)(36756003)(316002)(6486002)(54906003)(83380400001)(6916009)(2906002)(26005)(38100700002)(66476007)(4326008)(38350700002)(8676002)(44832011)(66946007)(1076003)(186003)(8936002)(508600001)(66556008)(2616005)(86362001)(6666004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pItDtA7NyPnFK3smF9KICN9NEj8Lkww59ukOU1hhMSRdEbUQjFBf5YcuxO0y?= =?us-ascii?Q?KrpfOTUAq8EDIuRkymvk3iSpn8l2eh6CoeqxDMsu/WHe5/RMTBiwi4u86sI6?= =?us-ascii?Q?+HArDr84gYUzfI8zgdxiPUb8poxqxZM2npGZloSufqj6VyUFGD+7hPdIITbe?= =?us-ascii?Q?5lUu2yCSSsKT6FfNnr0oWe3Dgm1fhSj//U0j6i5WZVdz9+j9Rdnv8c/tL76v?= =?us-ascii?Q?eEAeBDhTascUxu1cubJtapObLJA1qtMyuYXvq41SH8KxRy5Q44qHOj2GzOoM?= =?us-ascii?Q?FllT12n3SO66nMyytrejTqkRrZNNsidGL7FNAUFO2mbjyTRf1095ocWDQEtx?= =?us-ascii?Q?uvdar4ay81NtbHR1u7cISUESBCVUrPCizGIVP8xvTL5R1bgZajZFpWcE4JPu?= =?us-ascii?Q?AJt7YU2eStgqhxdfa6+W6CVyXnbzzcxWXqV5DXu4yLjUMzdZLGfD/IfNMRxx?= =?us-ascii?Q?WRJvlAMs7/fgL7sOsVmaqB/W2oDpwZxmOdDE7YtlXPphrQvOuu7Nao9o3rRw?= =?us-ascii?Q?hDXOF/tP6gSrUXJaP1u4Png8unObwtayKIHOA4gQkNX0GxGouD4GboSdBDQf?= =?us-ascii?Q?ZznsNRMeIkpleOCAfy8TLSEDvgeqFSYPLbP1j0cauLPXbr9VXSUxHUryJa3h?= =?us-ascii?Q?+OQshTdxtH1aRoebO1gUAyFnsRdwailU1JIYJxjINIH61O3FzHE3QvKfefDM?= =?us-ascii?Q?ZDJZR+/oVF5cNG8ObeJrcARGIOEB64vV+iq7YRQVVUVrGsfanI6ewfxOqXcg?= =?us-ascii?Q?+7INGhLrJo9xlTaQa5XF+mLQC3m8R2XcNLnfSY+ciRA/7hb88ZcCCoThEo23?= =?us-ascii?Q?P8anUU8Vu8PKiN+7xSoOhP5OVhgpatl1eROgRWkttvgkppmyPYLCbaSRECri?= =?us-ascii?Q?DW/zQ1vvbcsggX3puTgsQvsl2VJUdsoXj0HLzBLf3Au6QyXXUonoXSFEMNNd?= =?us-ascii?Q?EWtd5eBa507lXJ/V294sukbevSNmYFCJ87/W/53sDqM0F8VP2EMUkE+SRimq?= =?us-ascii?Q?l3b0th7T/pgok7AFOpvIIzZ5WRLELamSl2+5eClPJKNkhiLO4x9IY2lVeDdP?= =?us-ascii?Q?Lu/ofz+yQyqOg0cVm0Kktn5hlD0qAHznP/2N5yLVFWj8mVE/fnaUYaDbA1/9?= =?us-ascii?Q?yeoSZftuZ5za3itfohyRwmLv5DQHnc0vKgVy5KtXqVaUVfM06L5n9DAGtLzF?= =?us-ascii?Q?z4ZrJpgwFJrxxgyLV7ve2Y3DpTCc/HszRMJ39wIIy5Unm7DBk1Sek2OyKD67?= =?us-ascii?Q?TS37jCXOXfJVSJrqmhTJPIhIODl3eX6JjoC82B+G7xjM7JmN3Aj7/PkUeUGj?= =?us-ascii?Q?PVmYOLfglRiFu+uzlQBCYXDa?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a07fec82-df53-49bb-cf7d-08d981a914b4 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 11:22:24.8924 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: giX7ZyRrMOZnC2IvLH4cTDoKpGBXzPKiNcwMGxTDsWVRU9LUCR+xuXzwuw5y3pVDCd69wMSy98a1A/Xav3MAEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5503 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more difficult to maintain. The chosen alternative is to use strlcpy(), which properly limits the copy len in the (srclen >= size) case to "size - 1", and which is also more efficient than the strncpy() byte-by-byte implementation by using memcpy. The destination string returned by strlcpy() is always NULL terminated. Signed-off-by: Vladimir Oltean --- drivers/net/lpc32xx_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/lpc32xx_eth.c b/drivers/net/lpc32xx_eth.c index 3f281a515c6a..1a5734343935 100644 --- a/drivers/net/lpc32xx_eth.c +++ b/drivers/net/lpc32xx_eth.c @@ -638,7 +638,7 @@ int lpc32xx_eth_initialize(struct bd_info *bis) struct mii_dev *mdiodev = mdio_alloc(); if (!mdiodev) return -ENOMEM; - strncpy(mdiodev->name, dev->name, MDIO_NAME_LEN); + strlcpy(mdiodev->name, dev->name, MDIO_NAME_LEN); mdiodev->read = mii_reg_read; mdiodev->write = mii_reg_write; -- 2.25.1