From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B059CC433F5 for ; Mon, 27 Sep 2021 11:25:16 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25D6060F46 for ; Mon, 27 Sep 2021 11:25:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 25D6060F46 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8DB7B8364D; Mon, 27 Sep 2021 13:24:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="kyaQXfbN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D07808361E; Mon, 27 Sep 2021 13:23:00 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on0609.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe08::609]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CE0728361B for ; Mon, 27 Sep 2021 13:22:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MZkPbZc31JtkzrTo0w74W55MjmkiWhzrxWrA2sTW07WvLF9OHYU0NAmx2iU9fvPMCdWOMAgh2hEPIgUk/X40Ne5q2hq8UdXsXb3QAe+fFD9Z59p351m8UXJf6JXjTS2co2VcpeFrGbGZBOmQGUgZHDZ9qdj2LLfgQfkAgvtOFNzMK7fdqvjuGcg9Fun3GS/FML3DVoDlh86rfYg8GVxA/rp0OHmc/7DthRFydb5rZ2hVO2p6dOomHDECbfyMq4lT2OAqsyaZYFlVc/ILdctZoksEy4zyox7vF2Yw/hj5DRg1+TYoYkX5KAtvHwcwKZDFwLOSRUgFqYadKAHaxLXMPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=133Im3di6lY9eNQMtxQu2xKY9ilM2mihoy8Hu5eITVE=; b=OtGk6HsRBqJrmV1o5xhxFsmF4GaLQd4MAUcAj8JP9yGTYfxeHKtrbeJ4GQCKwiX1N6yDssZyZXcUNcw0Njw1cjfJ61xZouhaeWuK0JkXu4HDrWXiAwnO8tcIp1JxQEkY1T/MV1N7F5Yzx9Z4kQR+wetiBPXZjiXC2q/GmcacCKEj8Qm2XmPvEn/+4rENQg3tPczJe5efoNGQtjyxiA7dI/UMeVb5sXutKDIGn960K3OE5Pv2QCcCG6ZuykZY8rgm/7Yx098GBdzjM/+5Y1eYyXc6w2gjctmZVmKLUxsr3R7MFVM352iF0nyndIb1NanlRxP0LLtU3H5yAzPlHiHjyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=133Im3di6lY9eNQMtxQu2xKY9ilM2mihoy8Hu5eITVE=; b=kyaQXfbNArQOkFcemMYZ6G0BhUJzXIvo3pcb3n/h4Gbj5hvWwr4tO8q5GQMWDG3eA5pheVxH4VEMD/LjustJLNt6Pqp9bJi1NQ5w2ks3/ySuZt9B4yp4VjQi2dU4x04aybvpYhEiUUgFVvqc9zK0APO5hROzlcqhcXz+5mBqGYM= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR0402MB3839.eurprd04.prod.outlook.com (2603:10a6:803:21::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.20; Mon, 27 Sep 2021 11:22:28 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4%5]) with mapi id 15.20.4544.021; Mon, 27 Sep 2021 11:22:28 +0000 From: Vladimir Oltean To: u-boot@lists.denx.de Cc: Joe Hershberger , Ramon Fried Subject: [PATCH 15/25] net: mvgbe: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation Date: Mon, 27 Sep 2021 14:21:55 +0300 Message-Id: <20210927112205.301876-16-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210927112205.301876-1-vladimir.oltean@nxp.com> References: <20210927112205.301876-1-vladimir.oltean@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 Received: from localhost.localdomain (188.26.53.217) by AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13 via Frontend Transport; Mon, 27 Sep 2021 11:22:27 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0ae794b2-1ebd-4cfb-2411-08d981a91680 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3839: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1ZyPRKqv22iobSenQ/mN0p+yP/5t5KQWkdxClmoLBDq+nCZfRJCFLYh7fFvJWUefSVYQE9i5SmV0FIKJVX8urR31sX1Z0O5UOw5VAB3DdoO7+XLeyLkqwptSkcV/LMc7O3n28qXwiZfJDjEC7D4tlApr37A6BzdUTBnc0ZrS/8iO4buBbchaunmL6iO0sUfWO89bgMufLj9kwsqU3/N51a3pdCzt7ut2n1MEB/kMgDp92mYLYZIsXCSFn7JoMQNVbHMkArsmI4yPCJNsdejL0QabWgLbt/m6c8Es5OpfHhnXSI3yn6cnQNrQuGt9+cBu0vOvGtTaJpne1ga4i4i1IaIIo+QYtPnd6vpXbqLQcDq8BHEysJ4/D4/hYmKaXs9p0V2W8LIOrWctcdHt4B3XmBYkOMddzzGOjtfbHkH/rhnV4Miwpd517a5sXqpQC20SsYddcFp5XFTtBFKhc4iYUJt1XGzjD03mndxyIhuxa2uH6xGdme8vJHsSzW/Dp0Hri8er0WCihjdtn0bBO3uRycuXfwJSyKoYOsyhRzTVjInvkHUPgF3Nmazvj9t31dPtvs6ynVVjYppWJJBeKCkw7mQUcq+rAkS2yQ9wnB3zf97jbYKMq7mTplOXd1zoG/FlGVP44nq3GvKBtkKxfSM4ASqLvg5TIEDgGJ7llnCdx+wyJho7cbafGdo5K51YB2BIvgA0HN80WnfFn1/ulQGsIQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6512007)(6916009)(956004)(6506007)(8676002)(38350700002)(86362001)(1076003)(38100700002)(508600001)(2906002)(54906003)(66476007)(6486002)(52116002)(36756003)(186003)(66556008)(66946007)(2616005)(5660300002)(83380400001)(26005)(6666004)(8936002)(44832011)(316002)(4326008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WzRRMoVyQJm73u8gwLMbEdabcwhMXoSvwrEAD6DuXJcma+qX3l7CNCCyT5lK?= =?us-ascii?Q?Hzo0yzESqhXZtmqkMVEegnwG6cyLfWRUjMiwhZH9y7KCx5pOVNHsnNMomf69?= =?us-ascii?Q?If8XOtobuT+19VDpaBFPN+MB4lUFIYfSZ9tJP4RF5QPX4dd4+ZvDeHY5l7wt?= =?us-ascii?Q?qLK2bsO2OSaT0A5rBPn+ywF4+MUJDsCcM/VXmFhjlgmhtuRZCvLlIQauWq36?= =?us-ascii?Q?v124UNsKT5jdGaMelRoxSP+FGqRRbiCjSiGKFvY0AW/niMd+c1M3Sn8ON8v1?= =?us-ascii?Q?lh6menlLpIc37r3oJEbZQJcmlFeKblUkk+9tmt/sI7Vps9FEzwjKtlTv/OVC?= =?us-ascii?Q?/23TT8kf9JFtY1DSWKvqJGF1BKFTEzbUuHYLnrXybcvKcRWTFo7Z1k12nvRc?= =?us-ascii?Q?76GVR1BCAhRGHPilNQPlCbUXYL6azorgjSjuS9Hjm+iMa7S50X8Y1avmTNUz?= =?us-ascii?Q?mqud7qWO3CkLGwQYuVlDSBxHfmCTS4TtBhDQM/qiSIilYAu7VJzjEsNB8KNB?= =?us-ascii?Q?AGNbElrnz6iDho86ZQUwNuwf2Zc0roHaJKKnWunLLsEicruid/5uRwLD7bty?= =?us-ascii?Q?ej3N4GgKoB8CcGU2DYqfCAIK8W6+W+6GwI8RHjf9TQKQikoA0RB+zfbpyzKW?= =?us-ascii?Q?L/DihKMuJTqfXY3VO8RlUHDKi+K1sneV4gJ2togOlrr8OyAQmUcdEUdaoCWQ?= =?us-ascii?Q?ZQ58MhYUS4AH1SCqHfX+Nt7UDwFRBvfGWFBWYCx2GMtk+qdDNoYATfKHMPPK?= =?us-ascii?Q?RfS74Xn6hQzz/NQPab3N4idDNtw5DXgx/9kN8gvdhJ/0SCwPEeppn93qzA4r?= =?us-ascii?Q?5s1lWTYFmo+q9SGtFiQJIg0HPlRkmoRpCFpxc3JlUm+gRMzt49joBP871Qeg?= =?us-ascii?Q?uU5LPTvc4S0B4mpSQtYXKVRh8iWEomaWH+sCjR9jmeP72PM6p1nQB41guKFj?= =?us-ascii?Q?rU9PjIz1OrWZOuqmEyHd+F1AGfT/DOhGjQf0qrd6BGE60GoyBhVZ16p+nHzp?= =?us-ascii?Q?DsLm5EPf2rY/0t6EixaOu9eNgMpGxVFHJHajQsQtIq6YOR1HleBvVKyNzxmC?= =?us-ascii?Q?v8uRLlbrt0UQM1CqC9eYBvgFBPqauaAzXvWEFak3WilRvX0pVjT6xclQuaB9?= =?us-ascii?Q?+yG+FdC8evCstbbe5GMkT8KfzQFNdmHXNgcga32y/V/KuGKjReS1Vk4QdFOv?= =?us-ascii?Q?+l01BNCfY4kirmrlj1UNWa2fTyQE3/nx7jPeodZZWN2grl73b0eTv9pMX0Oj?= =?us-ascii?Q?iBF+4K/Qmry0EgS7LxyTejSlY+9d3uMKEzIN8ra1yHbc+GBzqmFI54GVDuGD?= =?us-ascii?Q?NsiShpJTDOXAsVzHx0DqZvYA?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ae794b2-1ebd-4cfb-2411-08d981a91680 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 11:22:27.8787 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jyVG4aZC5pDllXMw3DFNfQPCBrYIIgGAt1P9unDFZyywedDeSrKix/9BSW3r7LleVum0t2dp0p8WavCLemKzGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3839 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more difficult to maintain. The chosen alternative is to use strlcpy(), which properly limits the copy len in the (srclen >= size) case to "size - 1", and which is also more efficient than the strncpy() byte-by-byte implementation by using memcpy. The destination string returned by strlcpy() is always NULL terminated. Signed-off-by: Vladimir Oltean --- drivers/net/mvgbe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mvgbe.c b/drivers/net/mvgbe.c index ce5b8eed64b4..954bf86121a4 100644 --- a/drivers/net/mvgbe.c +++ b/drivers/net/mvgbe.c @@ -883,7 +883,7 @@ int mvgbe_initialize(struct bd_info *bis) struct mii_dev *mdiodev = mdio_alloc(); if (!mdiodev) return -ENOMEM; - strncpy(mdiodev->name, dev->name, MDIO_NAME_LEN); + strlcpy(mdiodev->name, dev->name, MDIO_NAME_LEN); mdiodev->read = smi_reg_read; mdiodev->write = smi_reg_write; -- 2.25.1