From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07CE9C433F5 for ; Mon, 27 Sep 2021 11:27:25 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7AD6860232 for ; Mon, 27 Sep 2021 11:27:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7AD6860232 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 714C583674; Mon, 27 Sep 2021 13:26:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="KsGsYvrE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AAD4A835FB; Mon, 27 Sep 2021 13:23:03 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on0609.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe08::609]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5564883620 for ; Mon, 27 Sep 2021 13:22:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kq9A8M3wzy1y/ah0rAqvyI5k4geR+WivD7iP6SYyk0wPynGeXnSiqtyyJke5la95gQqPZIN0cSFv3HrjppzFQUTQm6RB7wc/GWWwweJYsARq6G4nPO+hezQC9GcNPU5f7HghcmtJ7tAiXuWPDthRZKWf4kttJPPtQ2shkOuDlWcbEneYhZU7qgpwMLqlok5ZOrWpEhtuuqv4jJdbL28b9vyuYGvqusbIpVt+PMY6BH0LI5gVGL1tE8m9qab4vXEn5d66HSDt0LfKMGSkTnfUqbXS2EIklFGZcVBwF69jtI2NhQrOqyM2UhrYXsnPC61moaMrdvD/DUwXLhnLBnaWWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=WXC4BZqeKKVsYVrhdig0Dfk+QM/QsZvcKL/Du5VKGZM=; b=FA8wnFOCFnspjlBfTMIXspcl/2uKftY71Es5r/olrdsVUhVWYeGHHOH30e1b9L247Dz0ojKS54WFIM/qD+OyodRSGZYWI8G2X5GX8fQGKFcmo4Mxia1/33SymeFbHPUCmlYkjSLqaEpIhwwUxD4YLsAsGDBoyEqcQui8Sf5CmSrtd50oq325mEx3rMoobSDZ80T4eQy9hrOzallos4ZTsZ7XUYX3UA7BQuF6Zlt4CYM7+VNjHHaU5lQpda8fwUCRFknO9eNtWwNSAhEwOPnEorDsfO07r2fiGnGq9QgjDyOQmZ/VZ396dUF0/dHZdJPwqG9mmPaH5OOsQ7LRWTKQyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WXC4BZqeKKVsYVrhdig0Dfk+QM/QsZvcKL/Du5VKGZM=; b=KsGsYvrEzrtI2b1wmW+7UzUttRaESSo8pKtlXUDBoBA9mRHk7IsHomBagLDMKKtzrWRaDZBvKiWc/uOKpCf7BWQ2QQ/bIx/c/f8KIWZkIvChvB9RO1Eihd6Z/UyWwPIzLn6CxTmX1kmSPmHq7kD0txsiTvB7xJu8htxOq9aJiH8= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR0402MB3839.eurprd04.prod.outlook.com (2603:10a6:803:21::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.20; Mon, 27 Sep 2021 11:22:28 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4%5]) with mapi id 15.20.4544.021; Mon, 27 Sep 2021 11:22:28 +0000 From: Vladimir Oltean To: u-boot@lists.denx.de Cc: Joe Hershberger , Ramon Fried Subject: [PATCH 16/25] net: sh_eth: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation Date: Mon, 27 Sep 2021 14:21:56 +0300 Message-Id: <20210927112205.301876-17-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210927112205.301876-1-vladimir.oltean@nxp.com> References: <20210927112205.301876-1-vladimir.oltean@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 Received: from localhost.localdomain (188.26.53.217) by AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13 via Frontend Transport; Mon, 27 Sep 2021 11:22:28 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e385d75f-3bee-4cd8-4efc-08d981a91701 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3839: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GH+LH8OvhlaXVrYyiYI0GNnplVV7NdTpGE4L1B1AffzAvPifnzfv/sLYB6cnSSpr+tzpbR1pajikVfMUTr/hYcC2Q2nvXsb75V90uNLdQNOHcePJAZfuc/dlZDIgwoUaifoOfn0FuMtomVjYPsdTYWCZxyAx2QgPvt0IhNGAmePM4oJYIDFbWkKHt8S16RkISSed2nBSiCAOIFPoY1qb65yh/rApldUFuT06tBfQvpPY1wSGdbwdzbF2MULpuMJQN/IwcHoxSf9z1hnIwzrAVn0cAZjB/hm+x58A5QNv3+YeZun4ACbuF7tI6pBhAYUs781EMEyyd5uL7uueH0JOr1hY1I6dtjpyuykGKp2uJuh2IQ384szaNxXj/AMHNms9/b51jn9BdemFVkc01PVQcNJhC3EuS/8OEyMtpZkJ4JUGGNqat6B1zv6lweYniRN8jg5qUIpAzWL+N4fVg/7JT3zWkE//kgjFT7w8O1bHAtolz4uem8YN4QiM4FhhskqnfOq29PzQepfNxErA7gn1AJQ50j/NFj9owZZ0TBh8Ns1S5s1cwjPrMQFj4rfK7ywMAuUPrtXpIyjPgb+160wo/tMQ1OMMZiGXFkal+1hyc2OLQLT8crEYA/slN7kI0zOiqQ9qOGjkjDaUD7ZLj8EkiZfLrSy6VUk6xSqI9kUFCeZKM4K9vruE0Wuxei71KXey0fknRNe3oRpJzCLhVNVnMA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6512007)(6916009)(956004)(6506007)(8676002)(38350700002)(86362001)(1076003)(38100700002)(508600001)(2906002)(54906003)(66476007)(6486002)(52116002)(36756003)(186003)(66556008)(66946007)(2616005)(5660300002)(83380400001)(26005)(6666004)(8936002)(44832011)(316002)(4326008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nVL3yCdIo+jUFBOTlCYeBIKnc3ifJRaXbSZ8YlJZYyBNgFegcw/zKXhlxpaS?= =?us-ascii?Q?zynukGw0A/THbTGDT42g8k9aICzF/d655ah+9Ckf3zAo0JFWLRoosgcYke2a?= =?us-ascii?Q?pn4Wwb8WlRfRu3djCzhnDv5YO8GHLfM+W54V6DXUwXd0bM+dUhfnxaxC6UNl?= =?us-ascii?Q?cylc+ABKMzFmxhbt7SGZKCqEGy46fqH5MkAKXGbHP3zPRUvZoRoQXN3ztQCW?= =?us-ascii?Q?gyPV/yZeYL0U1oVhBz84bMzkdDCed+6k8DPyZJ/93Ohp88FA1xNU8Sh/Kq7/?= =?us-ascii?Q?iSVDLoP80hdUqbII7lgik3oiveH3ocZm4WvEF4BTA6zMap4adQ9SzT7ivPLH?= =?us-ascii?Q?wrOd/tBb/FkJ9noNZNInAm2gALjLqM60OOBa4+ucZkPNxO8ql0GXbOHC779b?= =?us-ascii?Q?DuNkGnIJ4VYumDwmyiMY7Kc4zMbbZeQcXfbloEMv/G9lTmo3eLnEs5dqzVxS?= =?us-ascii?Q?bmJKSB6crsJQPM4ly8VnUVoZwA2GYW9IjDhcD4U7qOIIYnwdNkzG3YnvblzG?= =?us-ascii?Q?74BdLDJcMlcKTvNgvOlHrCAHKUAlVqVmXZ4w8xP0VZXl3x+WWFmEDHTXhx3H?= =?us-ascii?Q?noLKlE+Q89iQrqRbdo4m/hJqTUSqShBAuM9GWRrv1cefCdlrmAX4VaN/LjUH?= =?us-ascii?Q?Es5IV+lrwWMyjpw5k//vNcQqR3n+Cp1Rb3dZ3clG8YLwfQsfOFS6lzR5/mEY?= =?us-ascii?Q?uNnyx5PCC8et2KP/D6njuqElV08MAq7LTY3KPCxpXABBon1ui45b5zREz30R?= =?us-ascii?Q?ie19UWJuo3HFOb8mJJmQQOBoD0SWom0FAn7P3mDD9+thdXuZXYcM0Sb4QJFx?= =?us-ascii?Q?OdOsh3++ahEQIXf+I05xg6w6g2dEVCwN7IOWKOEoULKK2cmrBgxtuLg+GUEq?= =?us-ascii?Q?2HEJcEln6yxWS4X3Va8z0dk9bWvUSuBIZXhlMj71+ZPoYbo7RHgb2mXr6gcF?= =?us-ascii?Q?Mwap7PfRwWhT3/MEET1UdZmrD+3kF2+K5VuvGxEweObymclg9lprrmYRLypA?= =?us-ascii?Q?ohSG8/f9IGVvdzZ6U5pERNbpQLPCjXxo3ALl9gA5dxMTwO3HcFcuheZQUdut?= =?us-ascii?Q?R5DkzoPNhe+PB4eNraueovHDgfWNnaABcM6nF8/HG4oz/lsoMDPjsGlmbzrS?= =?us-ascii?Q?3+vS+YhMUaf8AF1w/AgGasrdFGJYtR6YGYAjzZoOZsXxCuaTo6puisipCkpD?= =?us-ascii?Q?cGTlPE4aOyoixq0xw1oweCkp36h2LIkYMEBva/cbEYXdAC/EsdFIN8uZBgZE?= =?us-ascii?Q?PhqLmpN44pK0Z6LcdseAFbUNVmbl6+2Krm5+3gIkp3A7dUnQp0f2o/E/EwJy?= =?us-ascii?Q?dUDUC6zZSGatnxO5yJP4/Ocs?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e385d75f-3bee-4cd8-4efc-08d981a91701 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 11:22:28.7232 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5GEOGu5auDkC83sDtxunS0kfuJRDvqE/yQ2eMBiKDZs/dvPbT2ywrnQk7mATDQTYKzrT+7xX8wMn4I3ClT+4fQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3839 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more difficult to maintain. The chosen alternative is to use strlcpy(), which properly limits the copy len in the (srclen >= size) case to "size - 1", and which is also more efficient than the strncpy() byte-by-byte implementation by using memcpy. The destination string returned by strlcpy() is always NULL terminated. Signed-off-by: Vladimir Oltean --- drivers/net/sh_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c index 3143a5813a6d..4055f07b2feb 100644 --- a/drivers/net/sh_eth.c +++ b/drivers/net/sh_eth.c @@ -657,7 +657,7 @@ int sh_eth_initialize(struct bd_info *bd) mdiodev = mdio_alloc(); if (!mdiodev) return -ENOMEM; - strncpy(mdiodev->name, dev->name, MDIO_NAME_LEN); + strlcpy(mdiodev->name, dev->name, MDIO_NAME_LEN); mdiodev->read = bb_miiphy_read; mdiodev->write = bb_miiphy_write; -- 2.25.1