From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D96CC433EF for ; Mon, 27 Sep 2021 11:23:22 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F5D560F0F for ; Mon, 27 Sep 2021 11:23:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7F5D560F0F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 20910835B6; Mon, 27 Sep 2021 13:23:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="hUShU61N"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5808383603; Mon, 27 Sep 2021 13:22:23 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03on0601.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe09::601]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D84B283264 for ; Mon, 27 Sep 2021 13:22:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gvUsQsFzmS1heQM7WRCNLEjpxfVIvlgxQ7PPx2cDRihBkeIwsuQabclVedHdROJtMQVnx0vYi35JlYvjoiK43hxH2kWaTXcv3oOJJP1lK5UtQ/Q1nCF/vYzYFguYLmmeEXUdC5OuUj9LeLt/VU1Wsuv/O0+DW2591pzMDdNgNeV4D5kV3z4uuYwDjrXJomyt09iTdRaBLjM5ezkMSQxIsQ1vm+0CFQgE4SfYwX1cgUpTvO/hFN8cMvXxDjqb6pxvRLAUL4Aq6gVkg7C41BPNVCJXJRaPUaSztyUJAjpKZhFDUYZsPx5ZnvDaio+yU/8YRv2FQD1/VE37Pn6s4NjAlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=XM55CcH+8u2qCcbhWvlHXcOGbHDZ0ALevnkyzD7qMHA=; b=gVyNpboYCR53eG2DcavKmAMaHZ6yGSBKvxIVuL/mhxI/JeGCiJJbKPVFlLjMIAKo+0ptvZXDdkrzdS8X+e+57VUre/B5S2lu6JzjyKVlSlaSHaNnDCFhKDxKmNqKkB2IXrGpFwmQxcg3AwFwK7oM7T864kPpOwiGPDsqOnSpbofh1InDP6kLZHLEKiURhPtPJXdeef6MIwAjw17ZnbBE4Gb/KKv5/vtdnEFmKLVv5TXRxsvgHydp5MXcGvyEpm/Q8okufMW9Sh55fu5C6CzFNXXi+Lh8250d+70wV1r/PpziwTDoynMxWlDVyTPSahmpBoe2TAmTJ4mbuRFbCNBh7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XM55CcH+8u2qCcbhWvlHXcOGbHDZ0ALevnkyzD7qMHA=; b=hUShU61NFHjM5TQ9uFoXVRPRIfl/S8joMHzj+chEHkCmzDZmRQQhs/Axn6x8VL0IXgebRE+1yi98wRUOJdIwvO+V7xM6aVLgnXjQbwW+oJhffXArvFYxJjYE7kO8m5RQfIA2QbLQk5P8b6wKqs1hFKQqOv7lL0DC/Ei2JVU8kVM= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR04MB5503.eurprd04.prod.outlook.com (2603:10a6:803:d1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Mon, 27 Sep 2021 11:22:17 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4%5]) with mapi id 15.20.4544.021; Mon, 27 Sep 2021 11:22:17 +0000 From: Vladimir Oltean To: u-boot@lists.denx.de Cc: Joe Hershberger , Ramon Fried Subject: [PATCH 01/25] arch: powerpc: mpc85xx: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation Date: Mon, 27 Sep 2021 14:21:41 +0300 Message-Id: <20210927112205.301876-2-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210927112205.301876-1-vladimir.oltean@nxp.com> References: <20210927112205.301876-1-vladimir.oltean@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 Received: from localhost.localdomain (188.26.53.217) by AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13 via Frontend Transport; Mon, 27 Sep 2021 11:22:16 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c1175273-44ad-42c7-e972-08d981a9102a X-MS-TrafficTypeDiagnostic: VI1PR04MB5503: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QeZ9jhOyVtTvBXAuNWunHra97RPlOgwOTeS4RbPAkcmW/QNyMxQmdl1Az4EtyE1gtZBQqWpCDkiipNPEl7Z8L5hgtGIBLi2fdU/9o+6JvZHmv7iMaRTIgW4Bty6zYpNp0AdxaP3AR8r3mi38iGbWJgK3f5fTrMfJjhrQAGp/H/m0dxG5qAoGnFeU66vpti7LS5DFxlSKsBdLLsvKFp6bQcukQfpfXcVFdtCUXlJqd1SB6cTQadFsaaKRc3XuqeLXdxbGvncsRerro/6TTTmjB7Ist12el3Ti16CMz8Uu/u4LAxYO4l5wL4jV8Bjbg9G8A5N8R3QtBxz57u7cYsOOfUmZ1z6R38v4qbFO8aqbsQ0gGBlKwZYoQ4w5s9uA5lhD1T6h/uPjHT1AelVkZqDXLFyEv5DEgIZRJlL08OJZnIKG2Tx8Q2ShtUwj4FDcIQICa3I0AW526tOGHqBmdWEOx/uSaJmhXHd93w94oV484QwjbmifOSjutrtRDbZSaX5mdvb4tLL6kP9G9FXL0CCZKXBMpiGe3BFG2Ax7nm6KTRWqLci/WZs2n6NwjnKfb8j3OaNnmV/ed/jW2WRZgizmeTazB10zl6DcbmqPcgA2CceQYNwpkoxtxfF8wOM/askDkOaIHzo3SqTZH2x82PoCfLVoMncIpyocYukWCIrudOynbuRY8qC2xqZfX91IknGEEKu+o6X2h2VDWXaTkHxHZQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6512007)(5660300002)(956004)(6506007)(52116002)(36756003)(316002)(6486002)(54906003)(83380400001)(6916009)(2906002)(26005)(38100700002)(66476007)(4326008)(38350700002)(8676002)(44832011)(66946007)(1076003)(186003)(8936002)(508600001)(66556008)(2616005)(86362001)(6666004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aBzC5S+hP43w5R9mf8sc4kRHYRv10MACpCT8UUpdY1Was1BBqCXdInhadeIs?= =?us-ascii?Q?idyZJWqA32naw+YKAEQ9Jehi36RKKPmvrDuvELJFGphClR+eT/KieRYThHT0?= =?us-ascii?Q?t2/IbvTveDOik4SzPTpzcVZScrP+UDHJuV8e+A+i0AWhClTYN9S0LLdI31S6?= =?us-ascii?Q?vhE4hKx16FTE8LHVJerADs/rI7KCjbBPfnFHDL2J7MSRnGDS5FmniWKLN9Ax?= =?us-ascii?Q?2SdH7E7h4iDqF1lOt3lcxUvZemse34rQdR6CKyFFeWtWuH47ueE1MFHWuve1?= =?us-ascii?Q?IJqLd2RCsLqxe9fzSFLoAaYNDAquwbqx73ailOZNWF2N25O3MkWX1fVriioh?= =?us-ascii?Q?EAUntiStyk9JlgkIUrIfHYyLfYIzJc+mwCzqdm/8ixXeTxDebtbFHkZB+mIR?= =?us-ascii?Q?ijfoCka9BHD6UIV9ofKDV0OxGzgEUgU00lXuiGjxts6ZlIHlO2BXXR3/Zdef?= =?us-ascii?Q?vlo9Bg0I90nUnVpyQDaHrTnVNG1BSYJn51tclZ7ROpl6fVcWRBGuQxerqTRs?= =?us-ascii?Q?ak6L7Tpz8l3oFj1vCAO+QlL0VuT3nxCwdAUDs4C/0KjUWXbd00S2y83iab2o?= =?us-ascii?Q?meJdwvP5NL3TwLgT1MB7M8adr6jIH0aKEB4+q7ceq9H/hPCQQfQjzZBlM3UM?= =?us-ascii?Q?XWRFHbFWduq/EKMEphpnWTnGL0mqvpO2kWt0jetAIsZ/ZuZM7fcRPdn6sGm6?= =?us-ascii?Q?2xKIB6ZTBpH7ccfNu7jt39OTOrY9Jev0Lq3TGLoL2EvX/nvFjAH0ewkkzshm?= =?us-ascii?Q?70I/hRmiLC4rLMNsD8g0H7HhTiuyI2OTguAEJEfKuwnkXOFNnZEOAFvwT+lI?= =?us-ascii?Q?DTfjihRVvueLX57PZ09MQXXNCVeqNRiDJ2EgNPzqD0gPf8ZKPvEWucFuwGfT?= =?us-ascii?Q?RebWkFCnP8b/J0YNZ9IKYX6gGT50zNljUkAwy0rwhKAVgz3tLEoAG5b+pSDf?= =?us-ascii?Q?ONZJ/bNN2WKnF6U8fHiwfkjNmix/5RSCzdI0AnTDA1FJNCYMaSa12Favj0Mq?= =?us-ascii?Q?1x6cj0p0lnXpDvX8dSUcaOV2LQkA/F+r2fS2yTBMJF5YHTbUGGqero/QUlN6?= =?us-ascii?Q?CQVkIaYMXXSVA2Rnyom/jgUNDgkZepWSC7Sz2DAHAOxHo4kHZyHdJgJrw2l/?= =?us-ascii?Q?gsR+MCWvXfIhVHCwbOh+jzibLm0oomEl55FZICdjlnxMhgbCx0NvCkWREj0o?= =?us-ascii?Q?v+yKNTgGasXGSOFF4SRO0KCFhEWggAMbeQEvn1yxwNkdCYekS7R8HwCjHrI0?= =?us-ascii?Q?ebPgvUCsQOfdllJLr7DvfpPMqpvYj2f0AbWC79O5JOnIzzgJP38JcmkjZpCC?= =?us-ascii?Q?jIC3MB4aBIiSoEOYY58cN19S?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1175273-44ad-42c7-e972-08d981a9102a X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 11:22:17.2138 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z3KLjSdhftNARBx8oJ4m429Azckqww3HgKoz99GVaiQp9wOdeyLwSfCg2L2TRPOJWpljeQ2LaiKBxHjAtj+Agw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5503 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more difficult to maintain. The chosen alternative is to use strlcpy(), which properly limits the copy len in the (srclen >= size) case to "size - 1", and which is also more efficient than the strncpy() byte-by-byte implementation by using memcpy. The destination string returned by strlcpy() is always NULL terminated. Signed-off-by: Vladimir Oltean --- arch/powerpc/cpu/mpc85xx/ether_fcc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/cpu/mpc85xx/ether_fcc.c b/arch/powerpc/cpu/mpc85xx/ether_fcc.c index 3c4eb1a7eba9..1f6f55707321 100644 --- a/arch/powerpc/cpu/mpc85xx/ether_fcc.c +++ b/arch/powerpc/cpu/mpc85xx/ether_fcc.c @@ -444,7 +444,7 @@ int fec_initialize(struct bd_info *bis) struct mii_dev *mdiodev = mdio_alloc(); if (!mdiodev) return -ENOMEM; - strncpy(mdiodev->name, dev->name, MDIO_NAME_LEN); + strlcpy(mdiodev->name, dev->name, MDIO_NAME_LEN); mdiodev->read = bb_miiphy_read; mdiodev->write = bb_miiphy_write; -- 2.25.1