From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC707C433F5 for ; Mon, 27 Sep 2021 11:23:37 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 028E760F46 for ; Mon, 27 Sep 2021 11:23:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 028E760F46 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B6B4F835FC; Mon, 27 Sep 2021 13:23:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="FHzP3g0R"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 419E483633; Mon, 27 Sep 2021 13:22:35 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2060d.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1a::60d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 80D9F835FB for ; Mon, 27 Sep 2021 13:22:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XfrNOU0EIQ9aBLeX4OcpOaD436/EO58qr9Gex7ogxt6STk5s6BXmDeyOGlBV/1It6LnGrjQ+6L2JsJ2EDqh7UXf8K108m/zIo8EQYGQj0zyuFCPUkoDej+Ahij4Rsm4cjeqoeen/wCLKlqU0auMz95JIxX7KgOmryNpPgjP59RhF+1ViY9ZnDxy4/ITdOP39+7Z8UnUZzUiL7xHLFSNKs9TmgOsmYzI5a2h4CcU8DNhOJbNFbHUT75hZH4CnaX031oFhsNMO7IFcMiFqiAIYG2qfnoiBhz11bEMHzsXpS3CzGgP9MlkLL+tenV5LJmH2WuIxIMHggey0o0e3U6sGhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+lDX6ZFiaoJuUMBnYemIpQcZQEj78kIPvwBRhsubM9s=; b=LKKoYpWRjuCEoer1F/XozutlGkEPHkryTsBFypFAtKERplS3t5m+Xbaq4PeGXADio5sKJak8Yl95Wg9aVjtpi48DVdDDD2Pb8TW6fn3r8UiCn7v8GcwOqiVvZVSXmA4Hj6OeHYftCCluYPKJPNktKKwLnbuH0x4A9YgcHyjUhwIGBbHQuDkRrckqgw3HsG4CSed1bq6a9GjqDADeMaAvnzHxxFxf6vHTlSg4Q5TimUW+3n2Bxm8InuUqjjw6g89o3J0ethUMtMnNoyKEsUTB1GWzKoe1Bw5mAFTGslEdBI/sgpwG6xqHMSva4WXVwBRrO2G60tUooEc4RIEoTwc6Mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+lDX6ZFiaoJuUMBnYemIpQcZQEj78kIPvwBRhsubM9s=; b=FHzP3g0R34LMsWO1/KvkvJJoaU6yAv3uB7YHM+Qxp7uvy0SjeCx2EaK5OgvGI8N9dASM0rI8gkjbNaWYVshEqsZ5M48Gkxw8OUrnQpkcVvXf4BvGysdDqBA3ueIKoywubwk1YKd8wGUKKE8EdYS1i8lMVCX0+6/OX3OIumwTWhw= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR04MB5503.eurprd04.prod.outlook.com (2603:10a6:803:d1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Mon, 27 Sep 2021 11:22:21 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4%5]) with mapi id 15.20.4544.021; Mon, 27 Sep 2021 11:22:21 +0000 From: Vladimir Oltean To: u-boot@lists.denx.de Cc: Joe Hershberger , Ramon Fried Subject: [PATCH 06/25] net: eepro100: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation Date: Mon, 27 Sep 2021 14:21:46 +0300 Message-Id: <20210927112205.301876-7-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210927112205.301876-1-vladimir.oltean@nxp.com> References: <20210927112205.301876-1-vladimir.oltean@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 Received: from localhost.localdomain (188.26.53.217) by AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13 via Frontend Transport; Mon, 27 Sep 2021 11:22:20 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9e4fc2bc-9902-421a-0d6a-08d981a9127d X-MS-TrafficTypeDiagnostic: VI1PR04MB5503: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N2ydMzb17hbxVArtMTtAc5Prap+daYyAOipW7CrFU3Lz86avJXxGNq+pOJXeWPtBJAgQiOywP3gLD2up/aosJLvXE/JrPPg/e2+m49Ht9GTCpxVSVebY8QdegCXoIbe0odGqguwA2V3CxvrOrdwD2uyS6dKh5R0nJF2UtBIANX72ydAQS92/gJOofx0B/ou85LK9ezyl4ILrhKNUygjiWX+gaAjBgCtVtIxHKjT1WddCPbZtDwKcN8pNZXTvF6kwyw0+d1m2UrzTWXAwBDu/9TcmuksNv8prMaDh7m7tTSUroLmpfEyS8QppSUDgdZT0M8OMBEWjfBDfWoc9py11YkRbJB0kAq5bLIMgrBFM6TRuyAdW4IpqsDILj+YGh5cbxCnnJJbZXd9lnIzQnlI0HoodNIt23fxqHRFLPV7lwvmSc8uU2oMMqbwjKi1OA6Hb5sGObNOIbTYM/yYmjzn3ScdIj/x7HLgHCEYlqXFOewERNwx/a7zHVp0myZOxnhUjUmqUsgbMNSWXxRz6LIW5NTCVebmfrrjutWGeuub0nV67mk/V+6VlE0GFkYWIRYyTD86sBke4w6kfoFNmGFJAokIuNM/XCLu3d4+VAjszBzY5Vk1sq5RvVdHWn3RX6nXHdJsShsh49yJlSr2sXbLepMq+dVfrRiiJlgUDPnisGM0bu/8LF9SrqXERlsFS0wP4arAJwxa/JV6DyM1Jfd4qsA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6512007)(5660300002)(956004)(6506007)(52116002)(36756003)(316002)(6486002)(54906003)(83380400001)(6916009)(2906002)(26005)(38100700002)(66476007)(4326008)(38350700002)(8676002)(44832011)(66946007)(1076003)(186003)(8936002)(508600001)(66556008)(2616005)(86362001)(6666004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RoSnwXvdvmDcEBcOcRvOw/omW7qEjJrO8oVE0dJk/erQtN6avKTYRlA06P46?= =?us-ascii?Q?P5jhNA5Bu4cZIPwLM7hU4i0Lplz2509eB30mxbBrPxfXMlpT3ZqvrYzfamJN?= =?us-ascii?Q?ea4IdOUMH2JUz2NjrFI8DM9lXiqMXDbKkBGFICvz3rc/IaZdOLEGGBK9dxUv?= =?us-ascii?Q?UDXs/ebdiQX35ihAuuso+c10pIYu6PJgxRu5CV4MHnLR9wM8KvAhCvctczKJ?= =?us-ascii?Q?iCfNINPBQrNT0Fu4Ym+bBX0+G8S3eLzNmHHAx432OMkj864zNDK+51m3Rfwi?= =?us-ascii?Q?dcwcSCww2yRg388FOq5pHlNOHGgw5iSh7lB6jJh71wCb86bIgKFWK8yFz6kx?= =?us-ascii?Q?36nHm05Kvou51kj1tgSq0XxRZ4S77CCJ+vqR0QIcvh4wXui/a/OuyENhBmFm?= =?us-ascii?Q?Xd9G/XBMFmEGik/LoMyJBdZxjgG/lHTkhlV40qthMnOgc3hMLFKCM+WgwPFH?= =?us-ascii?Q?NnfoquPZK09pmn+sf3eA02DSf99jBWSQkgMIdT45ASff4AJakr68CSgvpom9?= =?us-ascii?Q?R3t1JVQV39P3pdO38ame3wPgNgBlRCxs5h8bo/FnhlYfn6JOINtNcCJWah4k?= =?us-ascii?Q?wMcHWG5NzXt7kzyyiVyJqy59s7h07pZzYOCz+jsoP/fHC+Bo9Oh81EX/tMLg?= =?us-ascii?Q?qDlKD8sp8S3m0/aXNlY2p1JbJcVpzEgLHIBBo9IcoNVycMwbKgV19jXP/0yk?= =?us-ascii?Q?HKQ+VwlxOdBrBUfNiygEAcE0/V6nWbIOqiGODGqL0Mh3rMmHvnZoeMJgNGYA?= =?us-ascii?Q?60Pp9GyVjfk+hvYoCnSJ5MnPYF+MvSCk7ivkt+OkewdOXLX0JxCBh0hBB2fm?= =?us-ascii?Q?2iPr+7su3Fzcd9pxq5JOT9AD1BEYLrw0S2/3V3/Qe5yAqEeGiSrAwrQL3QOq?= =?us-ascii?Q?1btVMMIyjgmVDVB8Sq3P8MjY300OkZHBkdx6Cba04+hsALw1kpM7UX51Kc36?= =?us-ascii?Q?GxFviJoe5omLIficykCxjWX58+H1B3WXUCvBgKy0S1D8Ksf/7CnOBcX9Q8aC?= =?us-ascii?Q?IV1PQeXjvYhWdXK3XQR8+6EZjpNPOwlXGYpCPhDggqVd/Z5WEM4oS6+0qbz2?= =?us-ascii?Q?BIoxzKLcUTGuxjjLtTpM0bQu3qyeOw2L3ZHvXO1CovlOLTg8P9vXdfsMtVEe?= =?us-ascii?Q?Y0V57gzVaVX+CaHbhgKH0fYhq1tEj4SGOahPp1RQBfVj846TsBLAfqxIuz25?= =?us-ascii?Q?KPBZSDQVF/JoOPSC5wE2PTPyGFlKtI2WtHgvFoawmAYlcHRn8Tyqj0kOvqLH?= =?us-ascii?Q?jWbyIAsHL7BLGUOGKPTXmNTsNczz5mbyI28ERbsAQylgAE2HaEpn0Wwv4VRs?= =?us-ascii?Q?q/ttHvB2bvi62QkvUQQXyQIo?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e4fc2bc-9902-421a-0d6a-08d981a9127d X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 11:22:21.1176 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RR0reoBiXPF1aJ7VHp6cFxwwCGv2HzudXyCR0nQtcjwAfmhseaovDJUKVeZPrQFAQT76wJlHuL0cGhHazeI9eA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5503 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more difficult to maintain. The chosen alternative is to use strlcpy(), which properly limits the copy len in the (srclen >= size) case to "size - 1", and which is also more efficient than the strncpy() byte-by-byte implementation by using memcpy. The destination string returned by strlcpy() is always NULL terminated. Signed-off-by: Vladimir Oltean --- drivers/net/eepro100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/eepro100.c b/drivers/net/eepro100.c index 934b881219e9..935cd9c99cef 100644 --- a/drivers/net/eepro100.c +++ b/drivers/net/eepro100.c @@ -493,7 +493,7 @@ static int eepro100_initialize_mii(struct eepro100_priv *priv) if (!mdiodev) return -ENOMEM; - strncpy(mdiodev->name, priv->name, MDIO_NAME_LEN); + strlcpy(mdiodev->name, priv->name, MDIO_NAME_LEN); mdiodev->read = eepro100_miiphy_read; mdiodev->write = eepro100_miiphy_write; mdiodev->priv = priv; -- 2.25.1