From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7469C433EF for ; Mon, 27 Sep 2021 11:24:32 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6415F60F0F for ; Mon, 27 Sep 2021 11:24:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6415F60F0F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 85B0583630; Mon, 27 Sep 2021 13:24:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="LJkWAs1e"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id ED2EC8362B; Mon, 27 Sep 2021 13:22:40 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2060d.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1a::60d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CDE0A835FC for ; Mon, 27 Sep 2021 13:22:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hlMQPLx9XZzhEgwUMPQb6o4+dPz6sK8WCaTXK1B29kGeCwPUru8TRxeb/KeSgcNL34tRk+B/bmslw2hM45ONqBnLOV9JheIy46jWqrocoLUrWU0qqLRykxWPxMqklp8odTdrmu4V5ujvSirIFTmnbu8WeUluI6DzCT5ABT431oNsdC5NjNH8ELUUvdk2sA578STyHk23zK1HJX/yIik3YMg2CofikVXymy7Kt0c7THs5MkN1BQdsHb5TgoKpPpRC4hR1dRSQygmQVJuS9CBIPErwAxjW56wMAoMwvXdh+oTpQ1MldMLPBgtC0gtJYCBvmQvw8N3qDdIGT/6znJ49xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=AFOyUACTt38zjLFhCNlHiG7KYOedW2GzlP4nJuxCIE8=; b=lVns8SCsA4CIGemzhVsShEZboDWEsnuWmTSZs5hTE9FotT2wu+aAeBSeqk4O2wj+s8IZWbbFrLj4WNDjaqFqR6aWrI9aOKUyVVWquhEho7HDpbL3AvarEhKSt2M/npROZGmtuEGvaG6dSeUDDp+mW/u5iJXIt0DOOlJpRz8hXL+U1iO0jDuQlgWEPVHYOGxVo5A6v97CP40U2fNGYgAlVB62tBvodE92nxYL8YyTBdQfzPcdS8+lSErUvUJbXA9tFJ6DwMtw/s04vxYhU5gLLjEC5ab9QS7K8XYZzeRcjg9ibMmUbH4c8SOtb49VZ/b/WXOQX3enxIjgdCtl2MmLmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AFOyUACTt38zjLFhCNlHiG7KYOedW2GzlP4nJuxCIE8=; b=LJkWAs1eEnN3yUDE5RFybAa44AKsEG7EPjUoamYJeXafMtBQZLkDvbhrexWlFi3O8lG0BMslgU8D8kaGUMcHK5qAI2qZLjkg/g380po7z4RrzehmDMFOzwZQ/WGqsGqPqk0Z2s2HciWphJBI+97Xt8gn8MrtsPWIBTB6y7mmPBc= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR04MB5503.eurprd04.prod.outlook.com (2603:10a6:803:d1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Mon, 27 Sep 2021 11:22:21 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4%5]) with mapi id 15.20.4544.021; Mon, 27 Sep 2021 11:22:21 +0000 From: Vladimir Oltean To: u-boot@lists.denx.de Cc: Joe Hershberger , Ramon Fried Subject: [PATCH 07/25] net: ep93xx: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation Date: Mon, 27 Sep 2021 14:21:47 +0300 Message-Id: <20210927112205.301876-8-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210927112205.301876-1-vladimir.oltean@nxp.com> References: <20210927112205.301876-1-vladimir.oltean@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 Received: from localhost.localdomain (188.26.53.217) by AM3PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:207:2::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13 via Frontend Transport; Mon, 27 Sep 2021 11:22:21 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 02a8b1af-5827-4e38-1291-08d981a912ec X-MS-TrafficTypeDiagnostic: VI1PR04MB5503: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sq6lajvZ7kpcaqQBXDUX8WI4hZpAKQzG/sWOsOSxxZlkfHe0+DoaNUN6V0FgmNYNArj/d+h8zmdgfnKhW1fniFC4caibiLbKoNbmx6l30QQkIUyk17AdaCBpy30NX5Cee3oOl1CgNMLM+Iq5R9Amqn0QVYAi83gXUTEUaVFHPA2SNgXjuC7HINHbPEG6IiKTvRXV6hQGLFOEawuXUy0WIpEYdfz8QrCxQza561MBLnuxTzS81sEBxFkyDaNdg9muVX4OJvizmWSBz7DuK0ShbvtwkA85V5r/aN8wKj9daqCJwIFb+aOVIk7H07Wozcxl6W7QCx/mNADcoN09tZ6Y3+ODa2q7MzTEGAYTQW4nDPqFCIYTHKnCaeLvCF8wtZDWpt7oyRh2MkQ/+/5vH0Pd0PjiG+Lyj6NkCrWopW15lzbW4REYt0V8SnbFIJ1v7jHY1GYWG00WBROAqTXiKRtAf/GLRCIGyAIysVhlrzxYB072f4osqQVEebFDIBHv4dNK7MIKuSMVTwqasJqGpkB7X9lLZ8iO2wLYWO9osE4jYJvCcJFjpK/y08NMtjlq0Tk5XqnqfcYjV3EZIiOAnWwiZlY69ZXjIDGI6ckwBGVeA1wcVwFJffmzjDkTzhpr9kyUH0enpQ+tUDZ699JdLWOjVhTcStAlMdg8YPHvzuODed2W5FTqjFc2M267qfSV3corQID9v6L6aEqFp1Dg32FwSg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6512007)(5660300002)(956004)(6506007)(52116002)(36756003)(316002)(6486002)(54906003)(83380400001)(6916009)(2906002)(26005)(38100700002)(66476007)(4326008)(38350700002)(8676002)(44832011)(66946007)(1076003)(186003)(8936002)(508600001)(66556008)(2616005)(86362001)(6666004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FrwlOaglkAwPADr3W4pPpilKBUCnZ/R5qTQ2pp4t3Y77G4Ou3lHO4etIFiEV?= =?us-ascii?Q?ZLtCpcTaOSXTC/+Nu7G/kaAPNpKXz4C9T0UPKpOuGg489sAn9PAjRIXH9rHQ?= =?us-ascii?Q?8b1s49C3HeeIzFt/iDbSmKRQj0YOBUw+RkqopLiCh9Gyy576kw5zpErf/wjW?= =?us-ascii?Q?mZrfR0SxQv5f83roLt1MwQERWfuQKbZrb2KppOYRY4fR8874/+fQr7CpNUpd?= =?us-ascii?Q?oLndFyyLGleXH0B0Ltz8Y/+4bREX5B+Nt9Jj6KISDlX63vOh22/ffADpo9PO?= =?us-ascii?Q?furMv82kvDXCNj4pbK9ZGVCHCvPNyPpMbgE6sMknpyASN51WxGe/15b5xZEm?= =?us-ascii?Q?/2+cPflUhMSzPzs/TMr1DQfXH7ixPcTYwGCHJQrTqz3A2uv/bzlILGM+YqC8?= =?us-ascii?Q?ltBU8Ubnpa/uwWMFTrrw/5P/1MD34NC5sCM7vuf0dnYtyTf67RtSyj3sqfJg?= =?us-ascii?Q?gl9XftfZ7Jvu9GnTcdbYx4ljjekKNgHV4Ac6Bl1/2t/xibnfdRl+7Tj69TAP?= =?us-ascii?Q?zEnDvr7e6sYwI0jHn6EDthvqx2GnowzOvjW8/ZVpWWhzxu0gXbfx4kKVYoRZ?= =?us-ascii?Q?UvKUtt6i3Z65b9tIx+pUZfs+NbvimL7avB83TmjyQNFVy3AneSETV0osHP5G?= =?us-ascii?Q?rOIrjMtLLMSN3d79xzG/dzjp7Z+ClGRlCIr/DKUAsFTJWJdDGuEYILzhU5Aq?= =?us-ascii?Q?iZWJrRsxFfdd2odPyhn8AlFwzhkX5UvSidLkftbLgpDZ7zBhyqg0u1JfsF1X?= =?us-ascii?Q?j/BFlCjmjNLEhkUTNa6k5/+G693rZq9VOaBLmA1n0ufDpSoQx1tPKwumdc2q?= =?us-ascii?Q?F8I3eTsdiWgBSWEX4B43vgF94Jb54zzkR9E783+870fPqfSNUEb8cDbsKMsb?= =?us-ascii?Q?yhAL8REOcePbi0ithaU318prk/lX/AAi+kqgYh62N199Q8NiBRkjclg113a1?= =?us-ascii?Q?agBqyKJMMpZ629kOeZDd+4CrD/oZGVViG3ZikECWiKLcOUbCknGOkjpHZyh8?= =?us-ascii?Q?rVhjf4/JCzbfhWHYlb+QChKvcA4s+If4svW5kTcsi6BTSwfEzGH5hXDBGs18?= =?us-ascii?Q?vr9u+oOAjEj7mb3g4wEnykxRquMVR4ep6S7Ka1asxSSB1fDTkBydInFFSfQW?= =?us-ascii?Q?9eMEAQix4PwCK6XFT2dc1LQYT3sVoMXAdzgti0VuIvpPUgabl2XKx496sqAI?= =?us-ascii?Q?3t9C1olsd/c+SyUfv6z/n7HlZAmBc3U1lZW/18P1HuRUVptXylsH/fYCyKbq?= =?us-ascii?Q?TiPjjpPn3ZR6mLC1RFs/QsBMo6vH4CvvBXNNb/0iSkscioIxEr7zPM7aNg2O?= =?us-ascii?Q?0ZpuoyhRs++QhA81X1IZw1Be?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02a8b1af-5827-4e38-1291-08d981a912ec X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 11:22:21.8302 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YFqNgjvve41+C42fS2Imqxbx5o6ACEiTrr5kmQXctzvYzmVMP7OfszfvP6xvy5x+J+mo+UWoy+nQ81g96SzwRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5503 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean strncpy() simply bails out when copying a source string whose size exceeds the destination string size, potentially leaving the destination string unterminated. One possible way to address is to pass MDIO_NAME_LEN - 1 and a previously zero-initialized destination string, but this is more difficult to maintain. The chosen alternative is to use strlcpy(), which properly limits the copy len in the (srclen >= size) case to "size - 1", and which is also more efficient than the strncpy() byte-by-byte implementation by using memcpy. The destination string returned by strlcpy() is always NULL terminated. Signed-off-by: Vladimir Oltean --- drivers/net/ep93xx_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ep93xx_eth.c b/drivers/net/ep93xx_eth.c index 0218349b0450..9f8df7de0609 100644 --- a/drivers/net/ep93xx_eth.c +++ b/drivers/net/ep93xx_eth.c @@ -427,7 +427,7 @@ int ep93xx_miiphy_initialize(struct bd_info * const bd) struct mii_dev *mdiodev = mdio_alloc(); if (!mdiodev) return -ENOMEM; - strncpy(mdiodev->name, "ep93xx_eth0", MDIO_NAME_LEN); + strlcpy(mdiodev->name, "ep93xx_eth0", MDIO_NAME_LEN); mdiodev->read = ep93xx_miiphy_read; mdiodev->write = ep93xx_miiphy_write; -- 2.25.1