From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C3C9C433EF for ; Tue, 28 Sep 2021 18:45:58 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD40661246 for ; Tue, 28 Sep 2021 18:45:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CD40661246 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BF06B83143; Tue, 28 Sep 2021 20:45:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="BAHt+J24"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 25CE982E67; Tue, 28 Sep 2021 20:45:23 +0200 (CEST) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 80E918318E for ; Tue, 28 Sep 2021 20:45:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x835.google.com with SMTP id r1so20815356qta.12 for ; Tue, 28 Sep 2021 11:45:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xybcPPbGmX4dJ/eP02RKZNKsd9nto9VbCk045lxnT4k=; b=BAHt+J24MHwYZzsyBLM96wSo0RPgM2Qn5ZisqTAHHB0lvi9KsQ7dN7oNF6FA23Yy4J jd/IJhkOinANAbNXiTpLpClo5S3v8ZhgVowmYqfA5zSRSOZtUgee+NnxZUrO8SXlim9L 8ozLxEaDilgMovPjU2jRpDmneE+yO9Tepcz9k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xybcPPbGmX4dJ/eP02RKZNKsd9nto9VbCk045lxnT4k=; b=AyDj+cqqXXDhiamgupVqA38Dxk8hqX7RA0zn1SgGkPfkRohgU9bTeGIV694JAx4aDk NEWplKgsgIPWJmHb2Z5WgDsTgjoUBPNX1kvMiYwOkuYNanUobD29RPYX3rpM49CARC6R gu+JdLr02l2zBtTt0TUmw0iRMxoFyzGdPbGD/SOaS7XCYy7Ch2+zlG42Mgi1IGXH9HO2 CBru8+QkdP1ck23Np+FlJr1KPxl6Yqv4eu2YIp8hXmN2tyXMMUPDNRY4xpfqgtvWhKQM 35eP1UEPEQTMJQw4in5EdXqpBFg6I1eSj9TcqtkVLbXQ1UmaFMLZA61ThdMFdl+ztszt JuGQ== X-Gm-Message-State: AOAM530luxjGbFq8kcH0nlaRlfD/ns+0oR2jd3s6/xq295vgmMWciXFl ZlkIeJROCYIRcnBZU9vCo6sv1J383nP4NQ== X-Google-Smtp-Source: ABdhPJzSV2Hm1g+ROsZ2xZe6ZIDiDKJ+fXZd02L4UnVvQ1Yf0udm1rcv8i5zz0bL9LYQA5PY+b72DA== X-Received: by 2002:ac8:4046:: with SMTP id j6mr7178459qtl.314.1632854712252; Tue, 28 Sep 2021 11:45:12 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-c022-6242-d139-1392.res6.spectrum.com. [2603:6081:7b01:cbda:c022:6242:d139:1392]) by smtp.gmail.com with ESMTPSA id d14sm6263638qkg.49.2021.09.28.11.45.10 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Sep 2021 11:45:11 -0700 (PDT) Date: Tue, 28 Sep 2021 14:45:09 -0400 From: Tom Rini To: Rasmus Villemoes Cc: u-boot@lists.denx.de, Stefano Babic , Fabio Estevam , uboot-imx@nxp.com, Joris Offouga , Christian =?iso-8859-1?Q?Br=E4uner_S=F8rensen?= Subject: Re: [PATCH] imx: imx7d-sdb: fix ethernet, sync .dts with linux Message-ID: <20210928184509.GV31748@bill-the-cat> References: <20210916145314.1704791-1-rasmus.villemoes@prevas.dk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SorlIzCW0DSU55cr" Content-Disposition: inline In-Reply-To: <20210916145314.1704791-1-rasmus.villemoes@prevas.dk> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --SorlIzCW0DSU55cr Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 16, 2021 at 04:53:14PM +0200, Rasmus Villemoes wrote: > Commit 0d52bab46 (mx7dsabre: Enable DM_ETH) changed these flags from 0 > (aka GPIO_ACTIVE_HIGH) to GPIO_ACTIVE_LOW. It claimed to "Also sync > device tree with v5.5-rc1", but in the linux tree, these gpios have > always been GPIO_ACTIVE_HIGH ever since this node was introduced > around v4.13 (linux commit 184f39b5). >=20 > I'm guessing that the reason for the GPIO_ACTIVE_LOW was to work > around the behaviour of the soft-spi driver back then, which > effectively defaulted to spi-mode 3 and not 0. That was arguably a bug > in the soft-spi driver, which then got fixed in 0e146993bb3 (spi: add > support for all spi modes with soft spi), but that commit then broke > ethernet on this board. >=20 > Fix it by setting the gpios as active high, which as a bonus actually > brings us in sync with the .dts in the linux source tree. >=20 > Without this, one gets >=20 > Net: Could not get PHY for FEC0: addr 0 > No ethernet found. >=20 > With this, ethernet (at least ping and tftp) works as expected from > the U-Boot shell. >=20 > Cc: Fabio Estevam > Cc: Joris Offouga > Cc: "Christian Br=E4uner S=F8rensen" > Signed-off-by: Rasmus Villemoes Applied to u-boot/master, thanks! --=20 Tom --SorlIzCW0DSU55cr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFTYrUACgkQFHw5/5Y0 tyzG3QwAhV/rqgA1DDwcJer8FEUMc1WFSUUEbW/rGIVxMxlBH1yyvW8b2uJZbfN4 gebTw48gNWF2zASZbwktzi3pZ1K6RhdappN2mnm4R5pVVTsxaPRfucOrMRLml9QT +wE/vryAiRKL6r5T6Bko2+F1Crdjt0jAkVoNfW1dWPNxydCGICDAvL1kItai2UoA K8o2gYbwtYiAJmHaQXZFKJ7iwV4H+K1LydP0Z8RwgsYtBlV85JhRJd6RC5iIykV8 2UJdQbZzMnexYDSV2ryiB6c+4u30hpN6GyfKOmAowCr59BC8wZ1lYe5w9mFbUvVn C9Z+tNy37wx4QrFTK7+1EvjBIB3TRhQAoN7rXOD7N0H3g76JgOID0kCpopHt6Iu5 oLaIqLLDQTuEehxE7ddDmXXZTc3tSxcawL3TeazzIu/igMznz9GKnvzZpIva/Fj7 vGuIEPCIdhw98GxZEzEDye4ARl5I5GNX/zuPcT28ecjg9Z/1Md14VrTR23Wj6GiE 1Tu2CJPY =BUGY -----END PGP SIGNATURE----- --SorlIzCW0DSU55cr--