From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: Ramon Fried <rfried.dev@gmail.com>,
"u-boot@lists.denx.de" <u-boot@lists.denx.de>
Subject: Re: [PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call
Date: Wed, 29 Sep 2021 13:32:12 +0000 [thread overview]
Message-ID: <20210929133211.y36cqkfhmpllvvai@skbuf> (raw)
In-Reply-To: <20210929055046.4326-1-bmeng.cn@gmail.com>
On Wed, Sep 29, 2021 at 01:50:44PM +0800, Bin Meng wrote:
> set_promisc() call accepts the parameter of a bool type. Make it
> clear by using true instead of 1.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> net/dsa-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/dsa-uclass.c b/net/dsa-uclass.c
> index 694664d81b..dcefec03f4 100644
> --- a/net/dsa-uclass.c
> +++ b/net/dsa-uclass.c
> @@ -282,7 +282,7 @@ static int dsa_port_probe(struct udevice *pdev)
> struct eth_ops *eth_ops = eth_get_ops(master);
>
> if (eth_ops->set_promisc)
> - eth_ops->set_promisc(master, 1);
> + eth_ops->set_promisc(master, true);
>
> return 0;
> }
> --
> 2.25.1
>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
next prev parent reply other threads:[~2021-09-29 13:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 5:50 [PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call Bin Meng
2021-09-29 5:50 ` [PATCH 2/3] net: fec_mxc: Declare 'promisc' as bool Bin Meng
2021-09-29 13:32 ` Vladimir Oltean
2021-10-16 18:26 ` Ramon Fried
2021-09-29 5:50 ` [PATCH 3/3] net: tsec: Make redundant_init() static Bin Meng
2021-09-29 13:44 ` Vladimir Oltean
2021-10-16 18:27 ` Ramon Fried
2021-09-29 13:32 ` Vladimir Oltean [this message]
2021-10-16 18:26 ` [PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call Ramon Fried
2021-10-27 2:18 ` Bin Meng
2021-10-28 4:53 ` Ramon Fried
2021-10-28 18:41 ` Ramon Fried
2021-10-28 19:29 ` Vladimir Oltean
2021-10-30 13:31 ` Ramon Fried
2021-10-30 13:37 ` Bin Meng
2021-10-30 14:39 ` Ramon Fried
2021-10-31 22:04 ` Vladimir Oltean
2021-11-03 7:13 ` Ramon Fried
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210929133211.y36cqkfhmpllvvai@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=bmeng.cn@gmail.com \
--cc=rfried.dev@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).