From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B008C433F5 for ; Wed, 29 Sep 2021 13:45:06 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0CB46140F for ; Wed, 29 Sep 2021 13:45:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C0CB46140F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CD3AF8028C; Wed, 29 Sep 2021 15:45:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="cQM8Ox6t"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1FB458028C; Wed, 29 Sep 2021 15:45:00 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02on0601.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe05::601]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 25035801B2 for ; Wed, 29 Sep 2021 15:44:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d5KR+bL+axNXd7anNYKoyfIi+iZlw6nNudBkxe0pLrFtsIji3F6IacjzIhvdoNcWmoGJxlDCVoLxPApmmcDIpxz9vN3r+buBsv6vHaZETsI6vn3DxUA+nIjNxSVkPJCO2mCKvmTaHP34ueAeugYsuXCOZs9zIQ4tT20vEtqATCcXsvuL01OLsaavJkz4ZpqdtZNWzFqchfRdYbZgsoUi2f4pV7bBL5eWTbyOyjgFj5P0lVyekIZFP0enddDzKFCFQp5QiP5HE6I81k0tbyvDBQ6e4wIS4tZ+PZkOh7elmbipudYw3gga3dndkiLD/0AnWbq10gR9IYpEQ1ehdd3i8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=kC5ZnCNuehTwBfVd4LUJyhlUaWD9/t/8+ZH1QUs9EeQ=; b=jtaPco4Qotdkhxj2M9tHnwxvdS16Pq+xNQ0rr9MbDzyUPfhoE3OG6SrvI0J4rUMf8h/jKslrXN7Q+Gq5vyBAIMxSM75WqdkOKc3qSCD/XDmJfgDqMcRoCfl9YnlFCCIRvFJMUwvj5Iq5/FnQiUvNWCkZHwD0YQz4juvInOc9hF1ME5V1MZa8PQP6SaBp3P/F6jzAZv9EDc8vgxw6DRFePiMpvaJgsKncOSxGWfIr68rHL7KgDNL/nYXQxZNDx875OOtUVh6r6UHb5Y0YEaDH7pc+vL3GQm/+Pjkkb8fHNuIxa9KT2/6QUAK/sGo4XOhC6tuwgpwX/vaO0JyVey9w7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kC5ZnCNuehTwBfVd4LUJyhlUaWD9/t/8+ZH1QUs9EeQ=; b=cQM8Ox6txEOt13fl5viAiO1fpWRmNsYVJJP5cHiviBvhJKWz+uryn6fc7saoQCcPJZKUN8Xl1+PcAIJTGI6cIS/SV9ZrWyZKwN4XWEXxMVFmOUZGAxWKlybrfCfWZCiGx9rhwuVv56xF/OydLxycZtWGnYvzR7O9jq2ZxAbWX+g= Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR0401MB2303.eurprd04.prod.outlook.com (2603:10a6:800:28::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.13; Wed, 29 Sep 2021 13:44:56 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4%5]) with mapi id 15.20.4544.022; Wed, 29 Sep 2021 13:44:56 +0000 From: Vladimir Oltean To: Bin Meng , Priyanka Jain CC: Ramon Fried , "u-boot@lists.denx.de" Subject: Re: [PATCH 3/3] net: tsec: Make redundant_init() static Thread-Topic: [PATCH 3/3] net: tsec: Make redundant_init() static Thread-Index: AQHXtPX7XqfGXpzMk0yMkfqEMN5Orqu7BnKA Date: Wed, 29 Sep 2021 13:44:55 +0000 Message-ID: <20210929134455.atqzfhsx4bpi7bxf@skbuf> References: <20210929055046.4326-1-bmeng.cn@gmail.com> <20210929055046.4326-3-bmeng.cn@gmail.com> In-Reply-To: <20210929055046.4326-3-bmeng.cn@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8941e8fc-0b2a-42be-8bb3-08d9834f5293 x-ms-traffictypediagnostic: VI1PR0401MB2303: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GSlZtM4IjfpOpo6GGtPMYCj5WByVmHNkmVzqQihjyU6SGSUJl04ZP7MrOPgku9Lyd2xbWEUYeTswd1c+KsFJwfNjW1ctVZ1mZQu+3ImqixE7QuoXuc6Ck2UoTCrARIV9QXor/cOMC0LHBNvIWWvVnVvoVai9tt/MMV6U0VZ5onEtyAjc/BzvK4td9qGuV5JptVbtAUeYUZjDB6oYCtm3MNrujJ+nGozFyDPkBf2JaihA9VnLz8fxXWrC/8nMN1aGHj+XnGX8hoEhfPLrdkiGxUooeHZZPHKL7mVg+gXZrksSPEonUZm5XlQC8Q/0/KiZVadi3/lmfW8a46R//Wt28NOADbNrfElPFpbuPwhf/LmjWTaZbtgho4L43yg59UCokwW6rMXPSwfHcjlhxsBT41k+H4tbv5PZFeiY9OxTsXRGaC36DzcZ0+u2TzxJg+G34b2nBecBDro0onACxIq0HOdb6Tx2jSJhp+TCfDlJrVFQIQLir/7ji2Edcst4WPiqGJzl0fAvBzd5VmYFa9dqKhGWqZ6Xs7lA27RaPHADGwjsW7SGcUZEpXY9c7EKtd267vOd/wDWeolZsnzKiRPABVPWnLLuvg6cCaSc1BbzBcM14BHH3YdVb6SEXC9uireqWQWbAFoQdwjOS9VPhBvfn+287DHHG14AdMERAhYxv4yJ858h7HcwP/vwP91TnxPe5IvOWI55PjqcjlfjBIeCWw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(7916004)(366004)(186003)(33716001)(66476007)(66556008)(91956017)(76116006)(66446008)(64756008)(26005)(66946007)(38070700005)(44832011)(38100700002)(122000001)(2906002)(9686003)(6512007)(110136005)(8676002)(86362001)(1076003)(5660300002)(6486002)(6506007)(316002)(83380400001)(54906003)(8936002)(6636002)(71200400001)(4326008)(508600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fdXYEwIICOXkxNLKsyOYBAHWshPgHXRuR+uSVMcG+e8WwazsKwnb1z0adUUU?= =?us-ascii?Q?duCE0/Z8SFpyLuu0nkA81J0g4pyzNxy4hZ127cZaIkSYYlvj7/TRshIE/IH3?= =?us-ascii?Q?kIhEMfJP0K3Ap7c7JmQfb+ceCuL1tiQop2xiB5SWV0gOh8suGHmdHmEbGKuL?= =?us-ascii?Q?3Lr23Nl7WPwLAmroWMoC1C4yhfhFQs1FfmB1BbjSrbyPlWTJAXczgHD24mnk?= =?us-ascii?Q?Ir/gstZXTaHRAxVdGUbLHLrSR9ZEf9UghIpwwAT6NjjVbQhgstAn6ozy47xf?= =?us-ascii?Q?Cg7fN+rlxfuduVasYJsvXvJCoeYtCqBLgsduE7SKDSCaryfGczi9NLSUFKHQ?= =?us-ascii?Q?KBtbIh40MIuiEVBh6EtP+XT2BxR1BNh+CjxLi3hDl0WZ41hh8aYlQjKk3/R0?= =?us-ascii?Q?c3ZB6/1x+/UegDvceBGwA67EWmsrKfgugBZJjEnNgoiy/QQWBqlgT1KDWmpN?= =?us-ascii?Q?EYQp2Ngnefg5+j/PaVW+3IN5YvTfs/bLip7RP7A52hpcvWDqq4k1ZkdIRKas?= =?us-ascii?Q?bG0FUW62yib3NKncTqiAwshPklIMCLigh7hL+PyK2W8jXnMZUFEuaz+Blzfq?= =?us-ascii?Q?zxfsu6tcQChvgdBWw5/dsxyDXNm4VNKM5mSq0gk4o70vsXEGojzCmS0nAgFe?= =?us-ascii?Q?9/dorERL1YEo39M+TLsmbtdVr5EsY3T4KiGEBkvqOazmpCH8KMhiNfbuRkPU?= =?us-ascii?Q?lZeMzPr5b1WL6wV0ofryIzgbufaYxPe7RjOWJ4gXhJm8ncqdzzj4D2FQQ75w?= =?us-ascii?Q?eU/6MHSO6Q4v2I2VSBrDOnrIQs92H3fU4i9pw+hbZg5tuaM7LgbZbBU3ERFR?= =?us-ascii?Q?6AnWmz4ohk7gkZ5gNtLjCbntc6+oIj15AUzkhOxsQFNuKHpByi7INeG1nQZf?= =?us-ascii?Q?ednrB0iHJXrVm8zyOGSPtSzwTixp2gs8ssyMS3zRZqh2ChTH3YW+OOyGpB9/?= =?us-ascii?Q?sEM9WEmEkARgqskgmdZ8JpvN5BPztFbNVoUu9P48IQLPuW9NHGDVhZEkaV6T?= =?us-ascii?Q?n8nLcaTIwstY5pKgghsDDMg+u7AUrclQ/dXoflKC7ZHRaAhTcwp03RlV8Y22?= =?us-ascii?Q?lmVrHDnyjwXjTa81YjrMuICnPujxJ5QSWOECB+UXI4R4DbvFAPPySGN1bRqp?= =?us-ascii?Q?elA03dcgHPKbejtlX1OkB9v3tuWs07d2RLjFT8E7LITsKuoPj05oZZruH3va?= =?us-ascii?Q?Padx9bJtlSpLx6sVGNYAxnEeFX6k1/1kRsaCwGyaIGYU77IkqCeL8wO9vS/0?= =?us-ascii?Q?E/NGsJaM5V3qtUrNRCYaB8Ah97cNiTKZ74PcH978Nssfoxr3a/kEpYOuZSG7?= =?us-ascii?Q?IdZHIIhlAaxlBf/uRnoh9kyP/lxeV8agnq33GvYZQIxvQw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8941e8fc-0b2a-42be-8bb3-08d9834f5293 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2021 13:44:55.9702 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UAvJDOdr7As67gjOd3mmi2E+SaHHHUnxLOt0Ndrr2gKTuhWtNfS4Zua8sIDRZJjyrkYdsiNqyf2DEfoZ9j+SGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2303 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, Sep 29, 2021 at 01:50:46PM +0800, Bin Meng wrote: > redundant_init() is only called in the tsec driver. Make it static. >=20 > Signed-off-by: Bin Meng > --- >=20 > drivers/net/tsec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c > index ee820aae15..b433e411bd 100644 > --- a/drivers/net/tsec.c > +++ b/drivers/net/tsec.c > @@ -432,7 +432,7 @@ static void tsec_halt(struct udevice *dev) > * of the eTSEC port initialization sequence, > * the eTSEC Rx logic may not be properly initialized. > */ > -void redundant_init(struct tsec_private *priv) > +static void redundant_init(struct tsec_private *priv) > { > struct tsec __iomem *regs =3D priv->regs; > uint t, count =3D 0; > --=20 > 2.25.1 >=20 Reviewed-by: Vladimir Oltean About this whole redundant_init thing... the Linux gianfar driver doesn't do it, and it was added by this commit: commit aada81de703e0fb26ae1a8dc8fc8d6a7a37fa3c9 Author: chenhui zhao Date: Mon Oct 3 08:38:50 2011 -0500 powerpc/mpc8548: Add workaround for erratum NMG_eTSEC129 Erratum NMG_eTSEC129 (eTSEC86 in MPC8548 document) applies to some earl= y verion silicons. This workaround detects if the eTSEC Rx logic is prope= rly initialized, and reinitialize the eTSEC Rx logic. Signed-off-by: Gong Chen Signed-off-by: Zhao Chenhui Signed-off-by: Kumar Gala Internally I could find a single reference to the eTSEC 86 erratum ("eTSEC receivers may not be properly initialized"), dated 08/2007, and it says it was fixed in MPC8548 silicon version 2.1. On the other hand it consumes 90 lines of code (10%) of the tsec driver. It would be nice if we could just remove it, I am not sure if anyone would even notice. Priyanka?=