From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>, Heiko Schocher <hs@denx.de>
Subject: Re: [PATCH 19/23] i2c: Convert CONFIG_POWER_I2C et al to Kconfig
Date: Thu, 30 Sep 2021 07:31:31 -0400 [thread overview]
Message-ID: <20210930113131.GU31748@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ2AKZH7GKxKarF8-E-LTBd05LgqpXV2Yp3VaCvXYu+eTA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1472 bytes --]
On Wed, Sep 29, 2021 at 10:08:46PM -0600, Simon Glass wrote:
> Hi Tom,
>
> On Sat, 4 Sept 2021 at 09:08, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Sun, Aug 08, 2021 at 12:20:27PM -0600, Simon Glass wrote:
> >
> > > This converts the following to Kconfig:
> > > CONFIG_POWER_I2C
> > > CONFIG_POWER_LEGACY
> > >
> > > They are handled at the same time due to a dependency between them.
> > > Update the Makefile rule to use legacy power only in U-Boot proper.
> > >
> > > Unfortunately a separate rule is needed in SPL to be able to build legacy
> > > power. All of this can be cleaned up when boards are migrated or removed.
> > >
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> > > Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
> >
> > I'm taking care of this now, but JFYI, this is actually a tricky
> > conversion where the "hack print" tool I've posted before is required,
> > along with running it with and without CONFIG_SPL_BUILD defined. At
> > issue here is that a number of platforms play games with only setting
> > CONFIG_POWER in SPL, really but moveconfig.py doesn't catch it. You can
> > see this with the buildman size/bloat functions and that main U-Boot
> > nows includes drivers/power/power_core.c and its non-DM non-configurable
> > pmic cmd.
>
> What is the 'hack print' tool?
https://patchwork.ozlabs.org/project/uboot/patch/1500407318-7977-1-git-send-email-trini@konsulko.com/
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-09-30 11:31 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-08 18:20 [PATCH 00/23] Makefile: Continue simplifying Makefile rules (Part B) Simon Glass
2021-08-08 18:20 ` [PATCH 01/23] mmc: Rename MMC_SUPPORT to MMC Simon Glass
2021-08-12 22:22 ` Jaehoon Chung
2021-09-04 19:58 ` Tom Rini
2021-08-08 18:20 ` [PATCH 02/23] pch: Rename PCH_SUPPORT to PCH Simon Glass
2021-08-08 18:20 ` [PATCH 03/23] rtc: Rename RTC_SUPPORT to RTC Simon Glass
2021-08-08 18:20 ` [PATCH 04/23] serial: Rename SERIAL_SUPPORT to SERIAL Simon Glass
2021-08-08 18:20 ` [PATCH 05/23] serial: Add a SERIAL config Simon Glass
2021-08-13 1:11 ` Sean Anderson
2021-08-08 18:20 ` [PATCH 06/23] spi: Rename SPI_SUPPORT to SPI Simon Glass
2021-08-08 18:20 ` [PATCH 07/23] Rename CACHE_SUPPORT to CACHE Simon Glass
2021-08-08 18:20 ` [PATCH 08/23] ppc: Rename MPC8XXX_INIT_DDR_SUPPORT to MPC8XXX_INIT_DDR Simon Glass
2021-08-08 18:20 ` [PATCH 09/23] sata: Rename SATA_SUPPORT to SATA Simon Glass
2021-08-08 18:20 ` [PATCH 10/23] Makefile: Unify the rules for BOOTCOUNT_LIMIT Simon Glass
2021-08-08 18:20 ` [PATCH 11/23] dma: Add a Kconfig for legacy DMA Simon Glass
2021-08-08 18:20 ` [PATCH 12/23] ti: Convert CONFIG_TI_EDMA3 to Kconfig Simon Glass
2021-08-11 12:22 ` Lokesh Vutla
2021-08-08 18:20 ` [PATCH 13/23] Convert CONFIG_DMA_LPC32XX " Simon Glass
2021-08-08 18:20 ` [PATCH 14/23] Makefile: Move drivers/dma/ into drivers/Makefile Simon Glass
2021-08-08 18:20 ` [PATCH 15/23] tegra: gpio: Drop use of CONFIG_xxx variables Simon Glass
2021-08-08 18:20 ` [PATCH 16/23] gpio: Add a GPIO config Simon Glass
2021-08-08 18:20 ` [PATCH 17/23] power: Tidy up #undef of CONFIG_DM_PMIC Simon Glass
2021-08-12 22:19 ` Jaehoon Chung
2021-08-08 18:20 ` [PATCH 18/23] power: Rename CONFIG_POWER to CONFIG_POWER_LEGACY Simon Glass
2021-08-12 22:20 ` Jaehoon Chung
2021-08-08 18:20 ` [PATCH 19/23] i2c: Convert CONFIG_POWER_I2C et al to Kconfig Simon Glass
2021-08-12 22:20 ` Jaehoon Chung
2021-09-04 15:08 ` Tom Rini
2021-09-30 4:08 ` Simon Glass
2021-09-30 11:31 ` Tom Rini [this message]
2021-08-08 18:20 ` [PATCH 20/23] power: Add a POWER config Simon Glass
2021-08-08 18:20 ` [PATCH 21/23] power: Refactor Makefile rules Simon Glass
2021-08-12 22:21 ` Jaehoon Chung
2021-08-08 18:20 ` [PATCH 22/23] net: Rename SPL_NET_SUPPORT to SPL_NET Simon Glass
2021-08-08 18:20 ` [PATCH 23/23] net: Move network rules to drivers/net Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210930113131.GU31748@bill-the-cat \
--to=trini@konsulko.com \
--cc=hs@denx.de \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).