From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E400AC433EF for ; Thu, 7 Oct 2021 00:27:00 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A74560F4C for ; Thu, 7 Oct 2021 00:26:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0A74560F4C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BC2C683310; Thu, 7 Oct 2021 02:26:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="FJ/c4t69"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D42B783310; Thu, 7 Oct 2021 02:26:54 +0200 (CEST) Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8799D83270 for ; Thu, 7 Oct 2021 02:26:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72a.google.com with SMTP id x12so4404953qkf.9 for ; Wed, 06 Oct 2021 17:26:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bYYDunyGfuvBUqZLqRF0JeWR6iQ9P5+2u5g+3Wsi3lA=; b=FJ/c4t690EjH14pNnJYvwQv2KX/gWv2AT0MCs6gusowg1T0fkDnxsRJ3E58hXoXFVk 6tjs1+b03XIioXpHWmW1AXd0nHud/6PIUJsAFNptLaN1WtWoyQEag/9r/e2mmd8A27fQ 3vznvDDmZTg6b2Gf4D7u3uLexNObXPpf7ZM8U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bYYDunyGfuvBUqZLqRF0JeWR6iQ9P5+2u5g+3Wsi3lA=; b=cpxoZDNuywxSX2CwaGvEfprmGWDG2mmk2SrOacO8JE8dOsmbv9z92cNlLcDyqP2Z5b fCXJMTaKgSOXB1vMvAuaLKcoVf/4auffDGPvbKlp/8mG3fL5Zw36W21ysJtAJbRsn02z Pf8VcLfFI8evl7WwTzE4l3NtllOu2t+QnLda5BFDU9XbYQBlu44e+txTNNdaBb5TpYFY 0/Rtt7Q18t/l9Ythd9eOi43qxxUvSWTyQpMg9RMjVfEkRpji/UT07fj7GrRqfVqyvwHv 9v+crg/h+hQ3v2s9uN5I2opKhYPaPc+JJuVHpkMlgYLNXs6q62Acbu8TNlNuvhOFdrHw JJ3Q== X-Gm-Message-State: AOAM531qVM/G3CR2rU2WkNJWufLKjIhmupUzH3e3HV8NCWtEhnnz8nxz RJKuWC0Bxz3FVPMeW8Lok8Rpsg== X-Google-Smtp-Source: ABdhPJzD1OaIGuZSkinF6njjCBkiHRVj7S8yomOwbtzyvWaAsPKXtffwys/i02hjC+Nqx1ZPQ24eHA== X-Received: by 2002:a37:4593:: with SMTP id s141mr973314qka.368.1633566410287; Wed, 06 Oct 2021 17:26:50 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-111d-c769-9689-befa.res6.spectrum.com. [2603:6081:7b01:cbda:111d:c769:9689:befa]) by smtp.gmail.com with ESMTPSA id a3sm12673251qkh.67.2021.10.06.17.26.49 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Oct 2021 17:26:49 -0700 (PDT) Date: Wed, 6 Oct 2021 20:26:47 -0400 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Alexandru Gagniuc , Andre Przywara , Rasmus Villemoes , Robert Marko , Masahiro Yamada , Masahiro Yamada Subject: Re: [PATCH v5 02/29] kconfig: Add tools support to CONFIG_IS_ENABLED() Message-ID: <20211007002647.GA11424@bill-the-cat> References: <20210926014342.127913-1-sjg@chromium.org> <20210926014342.127913-3-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yrj/dFKFPuw6o+aM" Content-Disposition: inline In-Reply-To: <20210926014342.127913-3-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --yrj/dFKFPuw6o+aM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 25, 2021 at 07:43:15PM -0600, Simon Glass wrote: > At present we must separately test for the host build for many options, > since we force them to be enabled. For example, CONFIG_FIT is always > enabled in the host tools, even if CONFIG_FIT is not enabled by the > board itself. >=20 > It would be more convenient if we could use, for example, > CONFIG_IS_ENABLED(FIT) and get CONFIG_HOST_FIT, when building for the > host. Add support for this. >=20 > With this and the tools_build() function, we should be able to remove all > the #ifdefs currently needed in code that is build by tools and targets. >=20 > This will be even nicer when we move to using CONFIG(xxx) everywhere, > since all the #ifdef and IS_ENABLED/CONFIG_IS_ENABLED stuff will go away. >=20 > Signed-off-by: Simon Glass > Suggested-by: Rasmus Villemoes # b4f73886 > Reviewed-by: Alexandru Gagniuc The problem here is we don't include automatically when building host stuff, I believe. This is why doing this breaks test_mkimage_hashes for me on am335x_evm with: /tmp/.bm-work/am335x_evm/tools/mkimage -D -I dts -O dtb -i /tmp/.bm-work/am= 335x_evm -f /home/trini/work/u-boot/u-boot/test/py/tests/vboot//hash-images= =2Eits /tmp/.bm-work/am335x_evm/test.fit *** stack smashing detected ***: terminated --=20 Tom --yrj/dFKFPuw6o+aM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFePsMACgkQFHw5/5Y0 tywUSAwAof69YwJR8YDSxbRiG9BJnnEWw7MBoTIhakPrFZk18DtjYJlWPv/xEoW3 jNGJo1+F8VilVAPZEK2B+ljq0Ai7lDiNbj0p+dxOZmgQ5yUrId+TUXvjz8lKqIle cEYt2jCIAF3ZpFkOBBGpjgm9jSLWLTj67pWYNTDk7d7T/LkocJvCg4awyQfClYf6 U1ZI/8X2yJL5jy3ON5dDAoHsKHBhpPQ3BlpqlZjGVpLMR6567xzkdbJ1VYSM2tw8 /chjPhusEbwNl1SNUYJz6BbwpWGvlRiYySfhfny+RcW54KE7+N+Nq6gNmODDD4bn DRH/jUNR4AAWOhl7k6rINcvB4VW1Wk9OUhPRgrbfhli/h36sFfXKrwe9QkZMWqtY BcRYPFO99KjgeAAzr86wLO+WJ4MfGU1GUIOT7dTPKk9+idEugKTdFo34sAP6DcDa eP/8T7nl3VMyVeMngZfz5W4DuFGxGc1LqeMku4S/gGZmgTZZDvTFHXly/acckjcB d0lPDDI8 =wwk/ -----END PGP SIGNATURE----- --yrj/dFKFPuw6o+aM--