From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE228C433EF for ; Sat, 9 Oct 2021 01:39:38 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F60A60EE7 for ; Sat, 9 Oct 2021 01:39:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2F60A60EE7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 45A5183649; Sat, 9 Oct 2021 03:39:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="skYDff5d"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0EE738364D; Sat, 9 Oct 2021 03:38:47 +0200 (CEST) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2439483653 for ; Sat, 9 Oct 2021 03:38:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x731.google.com with SMTP id 77so10098205qkh.6 for ; Fri, 08 Oct 2021 18:38:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5DtKwQXK7/u7+1LC9s6g4rU3NuIcQBz05uigDXka7H4=; b=skYDff5dIGV4QvgM1XegDvSBYIJrEq90Y8qj+MtDZLowTZ6mUpffhR9DsHfQUJi85g 3sRH4kxS/uVRr6Djfikkce1pd4bjgkYmmC01ZZg+maFHZ+EEY99WwvtuLUSAZY0HVMLp dDXfBh1i5Od9F62zH3tJHVndlNry0gT2mHNlc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5DtKwQXK7/u7+1LC9s6g4rU3NuIcQBz05uigDXka7H4=; b=0N5BdLDhMOEZ6YbypiKSNrAZ2Os4LW2eyhnVbKhLz0ynEcjX15VIcDlwNLSijNy+fB 1CT7tg2f18dP7e6hC0A+2/4sgIeUFS8shqQdLxfC/sYStqXB2ISTvSjd+4Zil19qX8Tu GlBcGd4Q+dSoDLh0OVqJoaiNCd6uMcZeBfTSWZ5Arp3ZuIapq+iVPxDU1xDYXxIg43PI rQHw0kAoovgOq3winumFVaV7EfTEa5XYU8rbDTx7qs40OcdruBQ4/6gVv8Xt/w12xxz7 37FAGZIGN3NB1pliWtpVLKjiAuzNXDbvuUEML+kl1hN/dE/qHZEMYqUoqcwnkHU8+4F7 kKzw== X-Gm-Message-State: AOAM532lxWDiz3o+fYIJmlOBnbgjAn+lM0dP7NATCn1en/mCUKy+Bv/n oKPCmJbmm5zP+lDV3/4tSA02XqBqiP5Smg== X-Google-Smtp-Source: ABdhPJzMB828t69k9IjB+3ZHfsRPsWxe6JkynuQFgeXD4BPst7ou08k5dSnG94dLYyCOVLcSabN3bA== X-Received: by 2002:a37:be83:: with SMTP id o125mr5724867qkf.161.1633743520000; Fri, 08 Oct 2021 18:38:40 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-1c00-ef41-79c3-ef5b.res6.spectrum.com. [2603:6081:7b01:cbda:1c00:ef41:79c3:ef5b]) by smtp.gmail.com with ESMTPSA id q184sm817645qkd.35.2021.10.08.18.38.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 18:38:39 -0700 (PDT) Date: Fri, 8 Oct 2021 21:38:37 -0400 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Heinrich Schuchardt , Alexandru Gagniuc , Bin Meng Subject: Re: [PATCH v4 08/15] gzip: Avoid use of u64 Message-ID: <20211009013837.GH7964@bill-the-cat> References: <20210925130320.7824-1-sjg@chromium.org> <20210925070255.v4.8.Ib3e1a50fbabc883786620b5f26dba460364883d1@changeid> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Enx9fNJ0XV5HaWRu" Content-Disposition: inline In-Reply-To: <20210925070255.v4.8.Ib3e1a50fbabc883786620b5f26dba460364883d1@changeid> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --Enx9fNJ0XV5HaWRu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 25, 2021 at 07:03:13AM -0600, Simon Glass wrote: > The gzip API uses the u64 type in it, which is not available in the host > build. This makes it impossible to include the header file. >=20 > We could make this type available, but it seems unnecessary. Limiting the > compression size to that of the 'unsigned long' type seems good enough. On > 32-bit machines the limit then becomes 4GB, which likely exceeds available > RAM anyway, therefore it should be sufficient. On 64-bit machines this is > effectively u64 anyway. >=20 > Update the header file and implementation to use 'ulong' instead of 'u64'. >=20 > Add a definition of u32 for the cases that seem to need exactly that > length. This should be safe enough. >=20 > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! --=20 Tom --Enx9fNJ0XV5HaWRu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFg8p0ACgkQFHw5/5Y0 tyx59wv+LAeDGbonDXRarMdP9XiCepu1z8Zy/LWlvj8T7p+hbV0BolSnptxP2xik P/K/FjGoYOIfW1VbkvK/LvHLhdTXRG5wIa3cvTJmovW/94o0dR9FetQX/A6Kyopy ViEG+IgWr7Q6DgHaXMCs35pcWGtikTonZDaaaBThA/dSLUtaS7lwTY2ySC1HrZ90 vd5wID2xc6icVK/od5wnkznMrIg0cWjV6EdQWHbI0JoAP+VPEn73WfdBWTxNqFh3 JsEDQeWEFCqhzs1Qux40qd3OiTfLYa93znzfl0KOr0ZO7seerKjjOLA89KLbe3IO J7XQOMFGwO/nX3vM+yR9O0f4xSEUrEbTNh4SJZElGidjNwgcLmkmjqHxylkDPjoc X2RuS6LhpQ+rsPjuF1q/g2tPDpchlEIAmuBbInR+0qqroqezjEGzA5xGxaszZt7G apRiYFoEQReJc5shVp0LKGfSnnLJ13cJim3Acr4fU8LOaoT9FdxyWch/172UntxH atrxZMxZ =R4eu -----END PGP SIGNATURE----- --Enx9fNJ0XV5HaWRu--