From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2EB6C433EF for ; Sat, 9 Oct 2021 01:42:50 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49F8B61027 for ; Sat, 9 Oct 2021 01:42:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 49F8B61027 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0241E836A7; Sat, 9 Oct 2021 03:41:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="nRjHbcqR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 382E883679; Sat, 9 Oct 2021 03:40:06 +0200 (CEST) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 31C6083663 for ; Sat, 9 Oct 2021 03:39:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x733.google.com with SMTP id w14so11326510qkf.5 for ; Fri, 08 Oct 2021 18:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bVcIXsXIe+Sw87FcYYPAwjQ/M8rAt+IAOJvh5he3GOg=; b=nRjHbcqRHqQpxRYNZ6dYmogwl1xB1cwnPXO9xTH7rM96lXCnf0SUPSvs+9ZKOpLxO3 AZOywvsc6LXhOLCVgURaIQQPRf/ClwObiqR8FSAtRSDV0oXo2QdlmZxl3yOo1NIevzYg kj2JoJZAPdQiP17mbIN2vYcD7GCI+c1PIUJB4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bVcIXsXIe+Sw87FcYYPAwjQ/M8rAt+IAOJvh5he3GOg=; b=Y3DYOIseyI00+2rA3mfRwI3qyWZwac+36vpvQ+FpdcVQdkvmkD1G0ph6OcNg6DEYRE SkTAIa3t33TSmN6wR4Sb1AcnRUb6s7x1jw9HWnY1cpaJSb3j5QmA9e3ZiNm65I2pHHMa kq1F+b3AoMi3QUIHkcMmqCIofEiRCA5Y/D9cfEMs8fOeRbRPGouM3upy3MDS+WPEVx8t BizHQ7n/hH8y2wPFoxKwnVxUyeUKYPlIaYJLOubz4FWANfKyoEMNALXq6EZc+ssGPYpK QA4ZvCe5LE2wLVTn9O4IsS3+pBOgea/Vx7qz3kxt//aCIlLsVh75q6OLnVfbWj7V4DKy Nl6Q== X-Gm-Message-State: AOAM531KEVphSLvIVTO/BABT1u3/T5zLq6NPQ2zEGOo5Xwmuekpo3w9C zlXYeX9b4wNaatssWB3QImKRPA== X-Google-Smtp-Source: ABdhPJznu08X0Ul2jPAQp4gC62mmIbfJL4/vhxI7YmucLJWHyjHA+f6SThPJqE+NpVjH+0rYWwrXrQ== X-Received: by 2002:ae9:dc47:: with SMTP id q68mr5776759qkf.437.1633743593037; Fri, 08 Oct 2021 18:39:53 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-1c00-ef41-79c3-ef5b.res6.spectrum.com. [2603:6081:7b01:cbda:1c00:ef41:79c3:ef5b]) by smtp.gmail.com with ESMTPSA id g4sm734284qtp.43.2021.10.08.18.39.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 18:39:52 -0700 (PDT) Date: Fri, 8 Oct 2021 21:39:50 -0400 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Alexandru Gagniuc , Andre Przywara , Rasmus Villemoes , Robert Marko , Masahiro Yamada , Joe Hershberger Subject: Re: [PATCH v5 06/29] hash: Drop some #ifdefs in hash.c Message-ID: <20211009013950.GU7964@bill-the-cat> References: <20210926014342.127913-1-sjg@chromium.org> <20210926014342.127913-5-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="czRehjsqUdpaVUeF" Content-Disposition: inline In-Reply-To: <20210926014342.127913-5-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --czRehjsqUdpaVUeF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 25, 2021 at 07:43:19PM -0600, Simon Glass wrote: > We can use the __maybe_unused attribute to avoid some of the #ifdefs in > this file. Update the functions accordingly. >=20 > Note: The actual hashing interface is still a mess, with four separate > combinations and lots of #ifdefs. This should really use a driver > approach, e.g. as is done with partition drivers. >=20 > Signed-off-by: Simon Glass > Reviewed-by: Alexandru Gagniuc Applied to u-boot/master, thanks! --=20 Tom --czRehjsqUdpaVUeF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFg8uYACgkQFHw5/5Y0 tyx3+wv/Wmh3WTPU8QZ4P06qkuu0FYrIafSaDnqI1CBgH0WM7Q4ySe+IRnKHFeXS 14LYgbCq26AGeSUueeCgM6I2heGnqE1+giNQiKHOJF2ak3tFHG8w9mi17dp39ne6 +jsXD9PLSgVopr2/yY0D4eLGQ1W5y4eu3f+WL17OuJmQqFZj+ZRqHWu/CFecbYsO u0rUlgcIPo0J5fsYBh4EnccdOU/VbILGmD78/1kuI86u0RATcbuMRGYhADrmC+xH 1kP9d6FkOFs7XAgkYWDGBq4HYynIJZ3K3Wc7yJy88CbKBFecI6/pkOxZous9cs8G f717EsOkT64akSLySr1n/uSTqG1swN2yHGMeiR2rJ10BLbVP25GwI4oCh2mEuFFu 6dJE7feRpzYr74yG75iODAc3kkJ09AHlLc7r0afRTMlkloNG2PBtXnjwJhZSKifQ QLTnWDOwamL00sDYoiins99OTNkOURu7e/j5mCdljmRqKhlv1mJGbCTguoS8JBQ1 vnFVCqg5 =oNdk -----END PGP SIGNATURE----- --czRehjsqUdpaVUeF--