From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43421C433EF for ; Sat, 9 Oct 2021 01:45:10 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B80AA60FE8 for ; Sat, 9 Oct 2021 01:45:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B80AA60FE8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 18890836DA; Sat, 9 Oct 2021 03:42:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="s09xW5yZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 361DC836C3; Sat, 9 Oct 2021 03:41:36 +0200 (CEST) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C7C8C836B3 for ; Sat, 9 Oct 2021 03:41:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x731.google.com with SMTP id l7so11394135qkk.0 for ; Fri, 08 Oct 2021 18:41:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QYcLjL0BsZuijoYYazenhdENCTRyA8BmIT4o99b90Ug=; b=s09xW5yZYIpe/CyWHlZgkxnePpLw1LCrJg3jHCWmDWrBjqs4myQ/wuOHc8zPAQREv3 pPBptl0INeHLOsqayvYbFTnl+TWitJSBRb+RzNv8UK18moeosqfblu6xpNaOIV2KGUM8 fSml2lqEBrUwOq1Vu18TSqzGTWzpQPugdoTac= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QYcLjL0BsZuijoYYazenhdENCTRyA8BmIT4o99b90Ug=; b=RUSc1wq7X5qx7I3muKPKEIMhpMDQC1YZgAVzSCjbGxV/+2+JEAl8rngcbyHiqN/Qd+ 5bQpTEsQ6CNF7LcjhmHEzz86N+OTV1ZjF2BKowFWu39TDhBU5pQbEcFqhSG3pba/zbWF ITcpkE+KBvFDQJOUxCRTP3ndJLzs0Z4Z23SUECKRLjHvAwjDSt5FGYryy6yDWmX8Puyy qJRu8bJpKQu1C1D8fq7Q4X8CovgWompBTdX2z+aI17fD2VyEBT/5WAmLg5MPH9nWAbJd 2IiPIJqk7q3hCTEqkYbxwgUN4DarVJC8fMuCt3csqZzz5Y1eye06BnfKr+BdCdbHQFDq d2aQ== X-Gm-Message-State: AOAM533ogggxeNqrrp2Sbaw5jScdw/4bPKfu/lcWz6ZdBjL0t0bM/Uv2 1wfp7VpQ6sGCVSOxpuCzpntS7A== X-Google-Smtp-Source: ABdhPJw1gsTyxkh28K8ON/24dnCtuIVfFkKnFJUAB51VTCUNj++RGCxw76qw978rdaGgFT5l2OesRg== X-Received: by 2002:a37:5884:: with SMTP id m126mr5560867qkb.460.1633743687652; Fri, 08 Oct 2021 18:41:27 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-1c00-ef41-79c3-ef5b.res6.spectrum.com. [2603:6081:7b01:cbda:1c00:ef41:79c3:ef5b]) by smtp.gmail.com with ESMTPSA id b14sm756472qtk.64.2021.10.08.18.41.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 18:41:27 -0700 (PDT) Date: Fri, 8 Oct 2021 21:41:25 -0400 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Alexandru Gagniuc , Andre Przywara , Rasmus Villemoes , Robert Marko , Masahiro Yamada , Joe Hershberger , Marek Vasut Subject: Re: [PATCH v5 24/29] image: Split up boot_get_ramdisk() Message-ID: <20211009014125.GK7964@bill-the-cat> References: <20210926014342.127913-1-sjg@chromium.org> <20210926014342.127913-18-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jAJnlX6Iz2QeVWJH" Content-Disposition: inline In-Reply-To: <20210926014342.127913-18-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --jAJnlX6Iz2QeVWJH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 25, 2021 at 07:43:37PM -0600, Simon Glass wrote: > This function is far too long. Before trying to remove #ifdefs, split out > the code that deals with selecting the ramdisk into a separate function. >=20 > Leave the code indented as it was for easier review. The next patch cleans > this up along with checkpatch violations. >=20 > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! --=20 Tom --jAJnlX6Iz2QeVWJH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFg80UACgkQFHw5/5Y0 tyzmBwv/TkV7jR9QJrqt9bt+H0Ob8o4ZIO4pfHoT5GhLbILY8Y72YcNtz1xN9qd5 6d84p4S9XipNykGAlerb9wbQIeCV3dOvp99pV29eoZdu0yAmIkUl3sgBoMav38hV R+M56nTqE6ISZ8Z8TqtpiTMX/yOT2pjJh1VpQnlnjx7s9DUNlGLfkZ1xIljBtYaZ G2wJkajoaBTaIMXyHoH5dWOXR+gG7GQJUbLdO/XD5P495CVWqM4YG/Go/vU6ehM6 yA3FvxYZFztW1oJ1IV68GsuF2UkeDNy4k1OLa3UGRkvUDBw8R6cXh1KjuX8bIgWO 4gk/nVwjoXKRi74Eg4exbdcRkZHjQKf8rUqtlfhUd5WPnJItY5obBRE/T8Tw8N2X MM1H/4kyDbghF+dp55/eqgdDIH1iPsYOy5YL1HCPgX1p7G+B8NRf9O6KXHrL7g5c sOBfYqYFxLNAWRqO6lx9HAUOGiBhl9r1WXfCS8bpj01lNEOjUAsenbhrmaTQ4f0g TEvSmrQm =TskZ -----END PGP SIGNATURE----- --jAJnlX6Iz2QeVWJH--