From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6273C433EF for ; Sat, 9 Oct 2021 01:45:50 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51CE260FE8 for ; Sat, 9 Oct 2021 01:45:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 51CE260FE8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 52ECE836F4; Sat, 9 Oct 2021 03:42:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ooPRXW4S"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6D3F083661; Sat, 9 Oct 2021 03:42:05 +0200 (CEST) Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 11FEB836C1 for ; Sat, 9 Oct 2021 03:41:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf31.google.com with SMTP id z15so7528529qvj.7 for ; Fri, 08 Oct 2021 18:41:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qmOahdr+d9gdB/Lx1IbrTzN/aYriljvSzIMoElHQprQ=; b=ooPRXW4S9lfAPTFvx32mfnKpYocgxN2dYqmEV62Ly85jJF+JzNIzplFQTPS9gplXIU y9funoFz+bCnxxWwxYTeH4CDhwsA9hYvEKmvZqmgR1kuMsFC8d1vU31EU1M6Yz8q4Otd /2KcYXC+gZ9PZRQVVWjbwAsc9ObxKL8DTS6wY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qmOahdr+d9gdB/Lx1IbrTzN/aYriljvSzIMoElHQprQ=; b=HoL13XM1d+zutR+/yyEpHjQRKuO9l+3wB+ZYzPKqUgR/XTnhW4spjmzjTInuXc/9OV R3D44jTkFDINM81mz8qbpwtM43FihOc56dyx5n7sZjpe4FiCUj22l2TeNHf6DNe65P8t ozH0jAg08O6Yl5uD7KsvPJ6ASwtoPaTY+Rm2o6bmzyuIVkUFparPJHmM/9Wpi3gQIuGq rSPrO3BLWIa0qMVXDDyVEsnuV8ESpUy96w2rFfejNYvqxqat15dXPOYo9j+07IGOn6dP vMPEvZR+c2j/r5YW89Z5DWCzyi3cYctF9hhGqVJRepdQvaZz+p88RSfBfQ5WR1pdnHjW YXtw== X-Gm-Message-State: AOAM53363a43v8pUOAHxfz15Tdjq6c0UUfuv/ktVeYNcrDvFMHJPmjHM 4M/cPW7jI1hVW+mZvN184NJtCQ== X-Google-Smtp-Source: ABdhPJzIdi4zwWW8AhXK9Tc4B8aYKZhVHoqvKeNUgusgyt1SALABJXPnL5+2oyONu0HWywxjWFf2dA== X-Received: by 2002:a0c:ead1:: with SMTP id y17mr2928084qvp.3.1633743715971; Fri, 08 Oct 2021 18:41:55 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-1c00-ef41-79c3-ef5b.res6.spectrum.com. [2603:6081:7b01:cbda:1c00:ef41:79c3:ef5b]) by smtp.gmail.com with ESMTPSA id o21sm705816qtt.12.2021.10.08.18.41.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 18:41:55 -0700 (PDT) Date: Fri, 8 Oct 2021 21:41:53 -0400 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Alexandru Gagniuc , Andre Przywara , Rasmus Villemoes , Robert Marko , Masahiro Yamada , Joe Hershberger , Marek Vasut Subject: Re: [PATCH v5 28/29] image: Split up boot_get_fdt() Message-ID: <20211009014153.GO7964@bill-the-cat> References: <20210926014342.127913-1-sjg@chromium.org> <20210926014342.127913-22-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="53t+yOlxgLCdk6tE" Content-Disposition: inline In-Reply-To: <20210926014342.127913-22-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --53t+yOlxgLCdk6tE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 25, 2021 at 07:43:41PM -0600, Simon Glass wrote: > This function is far too long. Before trying to remove #ifdefs, split out > the code that deals with selecting the FDT into a separate function. >=20 > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! --=20 Tom --53t+yOlxgLCdk6tE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFg82EACgkQFHw5/5Y0 tyyGpAv/b+TehmNkXLpL7qotEJudvPIKvCNqIkSClNQYE80ZkN1khhUbF35iPguB ANMfJ0K+ixePXrspfN2lH44TZgHrg329U5s7eTe0v9uMl3pWdaOuvjhwscHDlWbQ 0CB6khbhmcPGbfe1NxvjlGdpslzdHKFXGNCTdN9ldH2aUjqktJEIfd6I+98pQDM+ EpBjXejrmWQtsQJArTWE3ImiZ5c7Mq8rtpKVrTEiObXdVSVFihqfW6Cpw2t0L8AJ /TFJUrFXQdq7SFR0bMqyN20XX0T5+UuQ3aNlLB0YOtQwT9S287IRNXua8q25c2zM 8nWha2enJfdvHd772Pz3yZhX8XqGw+SFmkF6Rsf9wLMKBFb4EV2fjkoKIRp/HXAP GHbm/kY/Lu2ovmcMjOmz/8miyarSE5C0XR/J4E1unLa7ggtBcT6wpMN+MGUVypuw Fs24LUH2QPGnxAymeve0NQN3lkPY+wUtmcabpefpAocRSYT4MJSQRa9S651oL4qM z2rIuLhP =3GGf -----END PGP SIGNATURE----- --53t+yOlxgLCdk6tE--