From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B10BC433F5 for ; Tue, 12 Oct 2021 01:42:28 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 616DC60D43 for ; Tue, 12 Oct 2021 01:42:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 616DC60D43 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 42ED4832CD; Tue, 12 Oct 2021 03:42:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="j44y+eG+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 34694832CF; Tue, 12 Oct 2021 03:42:22 +0200 (CEST) Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A710182DF9 for ; Tue, 12 Oct 2021 03:42:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pj1-x102c.google.com with SMTP id nn3-20020a17090b38c300b001a03bb6c4ebso1317099pjb.1 for ; Mon, 11 Oct 2021 18:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=l7xTZY+krOb25RvX8d7HNuf6gBkd1W+yNGjfmhBTD+k=; b=j44y+eG+c9icI+egJ/Swv/6ymmzLP5AuSAhj5bt2mWG3CjiqlibJDNX0t2+/Ej916P 7Wj5Htcebsyzc+PmnUHYqTs2ynQCo75G76ouRkSIn1d4dfBIe2rr22Nm4tyqsBDSu/Es cXMeUAF6KuBY80b6Hyj0K73KSclpacG93yg+/I5hHOzaxKQpuUAYRbFySBftl36OtvGx lb3etSzB1CtHKHz91shvcBSk/Puiw4k3hr6MjHTE4KRqqERKry7gU/totYdv91DAqaw+ f93LWQNfW46Jngouax1ntRqvVFeskJ3wSORMdPNbZrT2GTwMNHli0yUVDp7SL5cTvyhK G5kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=l7xTZY+krOb25RvX8d7HNuf6gBkd1W+yNGjfmhBTD+k=; b=Ay4wHl/8XUhKUbdGoXOHaTzaDtAavzfy7L28LZldDhFcqPy4f7YNr/DvLYcBJdg/hQ PCoI3XoJ7tahP1n23SRwJcuxqWQgZPVGzIAJujeaoMlLrTNb16AEU0YgLKtIOJYoS1zC gwMUf14JS/OzrfbdbYKy6aJIcpK95GD0xiPoiVx3Y4qx6trvbJ8T00E1WBdh20agXrZK c5XUdly/3xzTwFE0bx70aw2+opC3bWMRgsWmfFuoRxeJJrAD2YSqXHwx7MHpPkq+C7N6 Q1kwctVS/6vO3Ft7P2lWAYJBP5jYbheoYk/IMld1zxsPCIeFo9uSCFfNpxtTpo7GS19X YVTQ== X-Gm-Message-State: AOAM532s9CYoVwe3tl9hNjH01sOqJBO625b15LRHxJSA9z7LIKUIgUJP EyHK/Fhq8vfAUgkfpNnkvHXD4w== X-Google-Smtp-Source: ABdhPJwXUv5+nIEIkT/GbHTVADdr5Lvs6NnWwZzdrQgHKCIIjtThMLtRgWCVr9ioIs1m5QzMmLL6TA== X-Received: by 2002:a17:90a:bd08:: with SMTP id y8mr2737911pjr.123.1634002936716; Mon, 11 Oct 2021 18:42:16 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:dbc:a6fe:8374:7fdb]) by smtp.gmail.com with ESMTPSA id 197sm8869269pfv.6.2021.10.11.18.42.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Oct 2021 18:42:16 -0700 (PDT) Date: Tue, 12 Oct 2021 10:42:12 +0900 From: AKASHI Takahiro To: Simon Glass Cc: Heinrich Schuchardt , Alex Graf , Ilias Apalodimas , Sughosh Ganu , Masami Hiramatsu , U-Boot Mailing List Subject: Re: [PATCH v4 04/11] tools: add fdtsig.sh Message-ID: <20211012014212.GC38222@laputa> Mail-Followup-To: AKASHI Takahiro , Simon Glass , Heinrich Schuchardt , Alex Graf , Ilias Apalodimas , Sughosh Ganu , Masami Hiramatsu , U-Boot Mailing List References: <20211007062340.72207-1-takahiro.akashi@linaro.org> <20211007062340.72207-5-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Simon, On Mon, Oct 11, 2021 at 08:54:09AM -0600, Simon Glass wrote: > Hi Takahiro, > > On Thu, 7 Oct 2021 at 00:25, AKASHI Takahiro wrote: > > > > With this script, a public key is added to a device tree blob > > as the default efi_get_public_key_data() expects. > > > > Signed-off-by: AKASHI Takahiro > > --- > > MAINTAINERS | 1 + > > tools/fdtsig.sh | 40 ++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 41 insertions(+) > > create mode 100755 tools/fdtsig.sh > > Instead of an ad-hoc script with no tests, Basically I intended to provide fdtsig.sh as a *sample* script so that people may want to integrate the logic into their own build rule/systems. But I could use this script in my 'capsule authentication' test that is also added in patch#22. > could we use binman for > putting the image together and inserting it? First, as you can see, the script is quite simple and secondly, the purpose of binman, IIUC, is to help handle/manipulate U-Boot image binaries. So I'm not sure whether it is really useful to add such a feature to binman. -Takahiro Akashi > Regards, > Simon