From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 214A1C433EF for ; Fri, 22 Oct 2021 16:22:33 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75F2660F9E for ; Fri, 22 Oct 2021 16:22:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 75F2660F9E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9A67C834C1; Fri, 22 Oct 2021 18:22:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="R/EFZlI9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 476B9834D0; Fri, 22 Oct 2021 18:22:27 +0200 (CEST) Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 04B1483311 for ; Fri, 22 Oct 2021 18:22:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf29.google.com with SMTP id v10so2750195qvb.10 for ; Fri, 22 Oct 2021 09:22:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ipmfoFUA1VGFrJj2yWw+7JVU0LS7Xfzcywbb7sY4vhM=; b=R/EFZlI9p/rcDDZJIJdivHe4nDWbn7VvlzpTo6v0bigPLGbpBGf0HD+oAuvVSLiR5l QGdUsgPNor0RIJdW2G/XqSbvkxqpAoqkgUJAfmYS7ofezmXHcl8lsipeRIHIh5zrJw+M Z5SvLTdneFaqeKLnTbMP+PkrtBAECF1URf/bQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ipmfoFUA1VGFrJj2yWw+7JVU0LS7Xfzcywbb7sY4vhM=; b=L1zeR2Zytu5VeSwSM8o7BzyNIdVf3sjZ7TrNSiFsPodsmtQU3Lxi5xmj4+dzX/A0Ri aJp4Fye/NdSCy+FDVWNNKzsYZZ7nXvaRNGoFW7wcxNv0kvSgi0/1tE5uyXAPy4xEmyzK Azn1UIh6ku+EDarj3wXeH+UE2165yU3QKcqmQE2aPGkYx0p2QFXWUZWUFu97C71TmfXk eLxCyV3pQoCjx6fxUIpOGApwY7ZBwnhzQiBPIFlPat8Te2yp9A5Un1P9xiaod5vMM+lD V83g+cqsWhxkwJOCWuqIgxYg7zugQMb3xqPamX2Dc7AbLzDWSdH/KhiZ+GIzZ4g72Fs0 rexA== X-Gm-Message-State: AOAM531oZpYFYyzu7EKcbSy5M5HtHid7Fnj9hqcDJCQqH2c38eSgjPc7 RKWJBGJFnaNkolGK51aZbXLlYA== X-Google-Smtp-Source: ABdhPJyz983QLA9KzPLLIp5TqPeiJLpdeEQHEYeK0oiaXiv/3q9OCzNahY/DgqsiVRqj+CTNlEkJ2A== X-Received: by 2002:a05:6214:224d:: with SMTP id c13mr970048qvc.37.1634919741755; Fri, 22 Oct 2021 09:22:21 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-f084-0129-62d8-869d.res6.spectrum.com. [2603:6081:7b01:cbda:f084:129:62d8:869d]) by smtp.gmail.com with ESMTPSA id d64sm4319252qke.62.2021.10.22.09.22.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Oct 2021 09:22:21 -0700 (PDT) Date: Fri, 22 Oct 2021 12:22:19 -0400 From: Tom Rini To: Andre Przywara Cc: Marek =?iso-8859-1?Q?Beh=FAn?= , Vagrant Cascadian , Peter Robinson , Matthias Brugger , Heinrich Schuchardt , Samuel Holland , Pali =?iso-8859-1?Q?Roh=E1r?= , u-boot@lists.denx.de, Jagan Teki , "Alex G ." , Artem Lapkin , Priyanka Jain , Sughosh Ganu Subject: Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL Message-ID: <20211022162219.GK3577824@bill-the-cat> References: <20211020024455.48136-2-samuel@sholland.org> <20211020072925.drf6622qhq4yykg6@pali> <20211020142902.12219c45@donnerap.cambridge.arm.com> <20211020134752.62k4fxukucj5rodh@pali> <20211021150048.59bb90d6@thinkpad> <20211022165922.22164ef8@thinkpad> <20211022150927.GJ3577824@bill-the-cat> <20211022165609.1725e93b@donnerap.cambridge.arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PEfPc/DjvCj+JzNg" Content-Disposition: inline In-Reply-To: <20211022165609.1725e93b@donnerap.cambridge.arm.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --PEfPc/DjvCj+JzNg Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 22, 2021 at 04:56:09PM +0100, Andre Przywara wrote: > On Fri, 22 Oct 2021 11:09:27 -0400 > Tom Rini wrote: >=20 > Hi, >=20 > > On Fri, Oct 22, 2021 at 04:59:22PM +0200, Marek Beh=FAn wrote: > > > On Fri, 22 Oct 2021 12:09:19 +0200 > > > Heinrich Schuchardt wrote: > > > =20 > > > > On 10/21/21 15:00, Marek Beh=FAn wrote: =20 > > > > > BTW, wouldn't it be enough to simply imply TOOLS_LIBCRYPTO for mv= ebu > > > > > platform in Kconfig? > > > > > =20 > > > >=20 > > > > We should only use 'imply' for suggested settings and never for har= d=20 > > > > requirements. TOOLS_LIBCRYPTO already defaults to 'Y'. So implying = it=20 > > > > for mvebu would be redundant. > > > >=20 > > > > In an OS distribution we only want to ship a single version of mkim= age.=20 > > > > So it is good to elimate symbol CONFIG_MXS. > > > >=20 > > > > How mkimage is built should not depend on CONFIG_TOOLS_LIBCRYPTO. > > > >=20 > > > > Tom wrote regarding this aspect in=20 > > > > https://lists.denx.de/pipermail/u-boot/2021-September/460251.html: > > > >=20 > > > > "if we're building a generically useful tool, we don't want another > > > > symbol for it." =20 > > >=20 > > > OK, so mkimage and dumpimage should be always generic and always > > > support all platforms, that makes sense, since the tools can be > > > installed as a distribution package. > > >=20 > > > But I still think it should be possible to cripple these tools if the > > > developer wants to disable libcrypto due to embedded environment. =20 >=20 > Well, I don't think this is the real question here, is it? > I think the tools part is clear: distros want to build just mkimage, > supporting as many platforms as possible, and might need to avoid OpenSSL. > This should be covered by TOOLS_LIBCRYPTO=3D[yn] and "make > tools-only_defconfg && make tools", and Samuel's patch actually fixes the > build (at least somewhat, I still get link errors). The problem is, are distros doing a tools-only build, for tools, or are they doing it per board? Like, hey, ugh, OpenEmbedded uses sandbox_defconfig and cross_tools as the targets. That's not quite what I was hoping to see. So I want to know everyone else is doing, rather than we hope they're doing. --=20 Tom --PEfPc/DjvCj+JzNg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFy5TEACgkQFHw5/5Y0 tyzuHgv+N3LCzUzVNI96xAcsbefIuy1AfNMfUthAOmU9yW93nCRqV9hF82liSnZE 8hObj7HI2bPN8Vsyn5rSuAfr+tW1qCQPf9m/8XVfcVphBlY/Hd3FNmczbU3CFhHR QrW9MetJd0oPSE5FwULPgF6U/E8LRSyFXMiKlgtcwwnQSSXKsaalDKmfDNjuTgKv BkrAUx4b7F7EUZSjlwkZJm1Z9KE56KA/6QoHIXRPu0Z7HxFSIHT8lZCB9qsvWKaB Zan3XsoFIiby2caEkeNbk9GcDSNl9+Qm7tqKvHW0fK4XVEXqojRu6V/BWpHm9MXQ rJyTymu2/LkgGkNbka1PFC30QvQZjMv5QqiR92fqCJTlYlvaGETBoCEKvmvUVO9R +DvrRJb/oGki6H5Es4wNQZBGZOJ35Js+s+UT8o4D6M/pY6uYyd/ipqtlPfAXXVOa UI+AqbQQ/Qz0wQFgnl15twmkwhGKNTRKJ9vnUOkKnRZMUoXsARl+zspIleBqNljL lMsPed93 =zCfw -----END PGP SIGNATURE----- --PEfPc/DjvCj+JzNg--