From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Patrice Chotard <patrice.chotard@foss.st.com>,
Artem Lapkin <email2tema@gmail.com>,
Joe Hershberger <joe.hershberger@ni.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Peter Hoyes <Peter.Hoyes@arm.com>
Subject: Re: [PATCH v3 09/18] pxe: Tidy up code style a little in pxe_utils
Date: Fri, 12 Nov 2021 10:39:39 -0500 [thread overview]
Message-ID: <20211112153939.GH24579@bill-the-cat> (raw)
In-Reply-To: <20211014124803.v3.9.Ib56ccfab71a5b43d9d35c5d9bd88813e6dfd9ffb@changeid>
[-- Attachment #1: Type: text/plain, Size: 458 bytes --]
On Thu, Oct 14, 2021 at 12:48:02PM -0600, Simon Glass wrote:
> There are a few more blank lines than makes sense for readability. Also
> free() handles a NULL pointer so drop the pointless checks.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Artem Lapkin <email2tema@gmail.com>
> Tested-by: Artem Lapkin <email2tema@gmail.com>
> Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-11-12 15:40 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 18:47 [PATCH v3 00/18] pxe: Refactoring to tidy up and prepare for bootflow Simon Glass
2021-10-14 18:47 ` [PATCH v3 01/18] Create a new boot/ directory Simon Glass
2021-10-16 5:31 ` Art Nikpal
2021-10-18 8:41 ` art
2021-11-12 15:38 ` Tom Rini
2021-10-14 18:47 ` [PATCH v3 02/18] pxe: Move API comments to the header files Simon Glass
2021-10-18 8:42 ` art
2021-11-09 8:07 ` Ramon Fried
2021-11-09 8:52 ` Heinrich Schuchardt
2021-11-12 15:38 ` Tom Rini
2021-10-14 18:47 ` [PATCH v3 03/18] pxe: Use a context pointer Simon Glass
2021-10-18 8:45 ` art
2021-11-09 8:08 ` Ramon Fried
2021-11-12 15:39 ` Tom Rini
2021-10-14 18:47 ` [PATCH v3 04/18] pxe: Move do_getfile() into the context Simon Glass
2021-10-18 8:46 ` art
2021-11-09 8:11 ` Ramon Fried
2021-11-12 15:39 ` Tom Rini
2021-10-14 18:47 ` [PATCH v3 05/18] pxe: Add a userdata field to " Simon Glass
2021-10-18 8:46 ` art
2021-11-09 8:10 ` Ramon Fried
2021-11-12 15:39 ` Tom Rini
2021-10-14 18:47 ` [PATCH v3 06/18] pxe: Tidy up the is_pxe global Simon Glass
2021-10-18 8:47 ` art
2021-11-09 8:10 ` Ramon Fried
2021-11-12 15:39 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 07/18] pxe: Move pxe_utils files Simon Glass
2021-10-18 8:47 ` art
2021-11-09 8:10 ` Ramon Fried
2021-11-12 15:39 ` Tom Rini
2022-02-09 11:40 ` Adam Ford
2022-02-09 12:32 ` Tom Rini
2022-02-09 17:16 ` Simon Glass
2022-02-10 13:56 ` Adam Ford
2022-02-10 13:57 ` Adam Ford
2022-02-10 14:32 ` Simon Glass
2022-02-10 14:41 ` Adam Ford
2022-02-10 14:57 ` Tom Rini
2022-02-11 15:50 ` Adam Ford
2022-02-11 16:12 ` Tom Rini
2022-02-11 16:39 ` Adam Ford
2022-02-11 16:44 ` Tom Rini
2022-02-11 17:10 ` Adam Ford
2022-02-11 17:13 ` Tom Rini
2022-02-12 1:09 ` Adam Ford
2022-02-12 1:43 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 08/18] pxe: Tidy up some comments in pxe_utils Simon Glass
2021-10-18 8:48 ` art
2021-11-09 8:10 ` Ramon Fried
2021-11-12 15:39 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 09/18] pxe: Tidy up code style a little " Simon Glass
2021-10-18 8:48 ` art
2021-11-09 8:10 ` Ramon Fried
2021-11-12 15:39 ` Tom Rini [this message]
2021-10-14 18:48 ` [PATCH v3 10/18] pxe: Move common parsing coding into pxe_util Simon Glass
2021-10-18 8:49 ` art
2021-11-09 8:09 ` Ramon Fried
2021-11-12 15:39 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 11/18] pxe: Clean up the use of bootfile Simon Glass
2021-10-18 8:51 ` art
2021-11-09 8:09 ` Ramon Fried
2021-11-12 15:39 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 12/18] pxe: Drop get_bootfile_path() Simon Glass
2021-10-18 8:51 ` art
2021-11-09 8:09 ` Ramon Fried
2021-11-12 15:40 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 13/18] lib: Add tests for simple_itoa() Simon Glass
2021-10-18 8:30 ` art
2021-11-12 15:40 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 14/18] lib: Add a function to convert a string to a hex value Simon Glass
2021-10-18 8:52 ` art
2021-11-12 15:40 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 15/18] pxe: Return the file size from the getfile() function Simon Glass
2021-10-18 8:53 ` art
2021-11-09 8:09 ` Ramon Fried
2021-11-12 15:40 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 16/18] pxe: Refactor sysboot to have one helper Simon Glass
2021-10-18 8:54 ` art
2021-11-09 8:09 ` Ramon Fried
2021-11-12 15:40 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 17/18] doc: Move distro boot doc to rST Simon Glass
2021-10-18 8:55 ` art
2021-11-09 8:08 ` Ramon Fried
2021-11-12 15:40 ` Tom Rini
2021-10-14 18:48 ` [PATCH v3 18/18] pxe: Allow calling the pxe_get logic directly Simon Glass
2021-10-18 8:56 ` art
2021-11-09 8:07 ` Ramon Fried
2021-11-12 15:40 ` Tom Rini
2021-10-15 10:27 ` [PATCH v3 00/18] pxe: Refactoring to tidy up and prepare for bootflow Art Nikpal
2021-10-26 1:28 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211112153939.GH24579@bill-the-cat \
--to=trini@konsulko.com \
--cc=Peter.Hoyes@arm.com \
--cc=email2tema@gmail.com \
--cc=joe.hershberger@ni.com \
--cc=patrice.chotard@foss.st.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).