From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3245AC433F5 for ; Sat, 20 Nov 2021 15:25:43 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8D55982FED; Sat, 20 Nov 2021 16:25:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="YPo+FjQN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 783F182F3E; Sat, 20 Nov 2021 16:25:37 +0100 (CET) Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 21D7A82B68 for ; Sat, 20 Nov 2021 16:25:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf34.google.com with SMTP id v2so9164966qve.11 for ; Sat, 20 Nov 2021 07:25:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5uMSRX5yxiWVZDimTxYu2z3Y+H8A+y0iYkAmJsYQUuQ=; b=YPo+FjQNiy4JFn4nua75+OMKwICciYy0UgwO4I5x9G3JTAHUq43XOMBTxiODE4a3Vt 8cxKNIgbqRmNNR7H1VcFXuDcbYPnHMqXlUM32LWfYlXehsHtVSneobxe203LRRuuSb56 mxaf7AJAnfNBGZPCLLOjAho0Uy78hl6qjqfHQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5uMSRX5yxiWVZDimTxYu2z3Y+H8A+y0iYkAmJsYQUuQ=; b=J3ods/nFpC6eBkINOMuSS+WHFWIj97dYn6mD05XK8B1c0gWsEjXpWARw/+CZcqfv73 GR8Yf/8MdSN3xc4B/wulrKSBfdxjBFx42sMKE4a8UBowWz9QR92RZnNWDy3j0zeqB4e2 wkdfTzTkTZj2P3d6FJkG6iDcXVwFg6AdqxBf84eI1oNmUF5hTFmaFhJsdLBbllwMq7Gv PSojYUSOAz6EF35HWeFOYspfQz844Zk5vQoxHwigTCNBBN14B0edsnfetd0w+PhjmTtW Jg+2X4Ft81mCcdvk9YsuFdJBLPCs+qFB429erctUxbacelLfNJ6krOBb0oN25CQ06HQc pDgA== X-Gm-Message-State: AOAM532wYXeyxS09WuEslywzN9DacblJBVs0gS1xXj/gNlveIZkwhpD3 6YwGGU6G2bTHh8hRME8pyend5w== X-Google-Smtp-Source: ABdhPJwj5tQPqDiH2qrX7+Uk2gLJGnWL64wciFtsELIIvD8ItogXZxzo65n7QpJH3PUXguhuM3rHYA== X-Received: by 2002:a05:6214:cc7:: with SMTP id 7mr83620926qvx.55.1637421930054; Sat, 20 Nov 2021 07:25:30 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-d980-7ed6-84cb-4d93.res6.spectrum.com. [2603:6081:7b01:cbda:d980:7ed6:84cb:4d93]) by smtp.gmail.com with ESMTPSA id e7sm1620936qtx.72.2021.11.20.07.25.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Nov 2021 07:25:29 -0800 (PST) Date: Sat, 20 Nov 2021 10:25:27 -0500 From: Tom Rini To: Mark Kettenis Cc: Sean Anderson , peng.fan@oss.nxp.com, peng.fan@nxp.com, lukma@denx.de, sjg@chromium.org, u-boot@lists.denx.de Subject: Re: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults Message-ID: <20211120152527.GR24579@bill-the-cat> References: <20211029012801.15193-1-peng.fan@oss.nxp.com> <20211120125711.GO24579@bill-the-cat> <3d3603ac-d949-ab9b-3045-6f8a6aa25127@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VGTeRqy79G1sBQce" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --VGTeRqy79G1sBQce Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 20, 2021 at 04:21:12PM +0100, Mark Kettenis wrote: > > From: Sean Anderson > > Date: Sat, 20 Nov 2021 10:06:55 -0500 > >=20 > > On 11/20/21 7:57 AM, Tom Rini wrote: > > > On Sat, Nov 20, 2021 at 12:10:54PM +0000, Peng Fan (OSS) wrote: > > >>> Subject: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults > > >>> > > >>> From: Peng Fan > > >>> > > >>> Current code has a force clk_set_defaults in multiple stages, U-Boo= t reuse the > > >>> same device tree and Linux Kernel device tree, but we not register = all the clks > > >>> as Linux Kernel, so clk_set_defaults will fail and cause the clk pr= ovider > > >>> registeration fail. > > >>> > > >>> So introduce a new property to ignore the default settings which co= uld be > > >>> used by any node that wanna ignore default settings. > > >>> > > >>> Reviewed-by: Simon Glass > > >>> Signed-off-by: Peng Fan > > >>> --- > > >>> > > >>> V2: > > >>> Add R-b tag > > >>> Tom, Simon > > >>> After a thought, I think still put it as a u-boot thing. assign= ed-clock-x is > > >>> actually Linux specific, however I could not add the new proper= ty to Linux, > > >>> because we are supporting SystemReady-IR, we need the > > >>> assigned-clock-x property > > >>> in linux working and ignore it in U-Boot. > > >> > > >> Any more thoughts? > > >=20 > > > Just my continued request that you treat this as generic and submit t= he > > > binding upstream so it can be in the device tree for the platform. > > >=20 > >=20 > > Hmm. > >=20 > > Could we just do > >=20 > > /delete-property/ assigned-clocks; > >=20 > > in our u-boot dtsi? >=20 > No! Those properties are needed by the OS loaded by U-Boot. >=20 > The right answer is probably that U-Boot should use these properties > to set up the clocks correctly. Paradoxically that means the OS would > no longer have to worry about them and the properties could be deleted ;). Yeah, so this needs a better commit message to explain what the reasoning / logic is, in a positive manner, rather than negative. And the binding portion needs a longer explanation. And it needs to be sent upstream. --=20 Tom --VGTeRqy79G1sBQce Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGZE2cACgkQFHw5/5Y0 tyyMqwv9GRrtswRA23keJ/WMucNR6rSczCP10oseQsE5QPgMurZMYR5wXGDuRvcH oLlcogtJqZZw8kmK8b1JjkxhKrG7trbbJEP0QCq7jsZOsJHrfX/I2aUehXJLksb5 7RNpMcbn88qsl7HJ0BDk7urhHGQD/T5/ECS6gsp4ubxqPxSizehndXo1Wi9c7VpN k4T5xeL1wE912r+TxdAJF/TEtq2Q4NKfmuN/kP34gxCFbg5VkgLeCMM8znWV3YKx CldHY7oMRVld55hhoRLRd16YNFlPVXXI2+r6KIrNz2akOxjbnqPelTKzqdtE+J4k pf7vuVyxM7QxGgF31SvScdGc0bfAJFQT0d/I1f7m4US/RMxyYPn9V62TvOPj+chb nwxjjIK5mJHuayeSMsfUWLJLts4NJUpTpWZs3v/lMGgHHE/n7NzTI9R7enLnebCZ WhaZsK3ZKJNVIos9cIlmDItLgGNR8jAi+GKbHUgEqPCvd4BRg6ooGdro+VQuKNDw jTZY6nvA =H0+M -----END PGP SIGNATURE----- --VGTeRqy79G1sBQce--