From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B559C433F5 for ; Tue, 14 Dec 2021 13:11:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B16D88129B; Tue, 14 Dec 2021 14:11:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="c5qMFdwM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3B1598129B; Tue, 14 Dec 2021 14:11:51 +0100 (CET) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 535F6811A7 for ; Tue, 14 Dec 2021 14:11:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kabel@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 6F304CE1720; Tue, 14 Dec 2021 13:11:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CCDEC34601; Tue, 14 Dec 2021 13:11:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639487501; bh=ZZeCHr8ghcZyK/zVUA4aeaLBIJXUvqVJ5SndWXQ/INA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=c5qMFdwMqsbBWEzo5oFapozO07BcG/u7X+3ZsQK7ePxAdI4Tcj0AAKauNeBfcS7ot eovqP0cOhFlkfEGbf6zsmxXurTJQX1O+Cs84COgwv4M57DXlW9au+9IJYIYG6vgagt xd5AgtXwCbrNeQjhXA3VorNo4AHP3fOtp2Z9lN28X/3NFhAbKUiaVd4z3uXZhLim9C M97U2Ca21iz6j/C/ErluF/xg9C3InhdzZo82uwnch5US+6jhDZ6dE8NGgM3NyDRSzr vK3v67zcXE/EEZ+xO7pMci5iTqCrq8BXyBBIsVsGNdZp/lVan51ixxTQk4ZNCiSLlf QhuCMvhST2wuQ== Date: Tue, 14 Dec 2021 14:11:37 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Stefan Roese , u-boot@lists.denx.de, Marek =?UTF-8?B?QmVo?= =?UTF-8?B?w7pu?= Subject: Re: [PATCH u-boot-marvell v2 6/9] arm: mvebu: spl: Print srcaddr in error message Message-ID: <20211214141137.3ecb53c9@thinkpad> In-Reply-To: <20211214111030.p44erpox4jicvykr@pali> References: <20211126143738.23830-1-kabel@kernel.org> <20211126143738.23830-7-kabel@kernel.org> <20211214111030.p44erpox4jicvykr@pali> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, 14 Dec 2021 12:10:30 +0100 Pali Roh=C3=A1r wrote: > On Friday 26 November 2021 15:37:35 Marek Beh=C3=BAn wrote: > > From: Marek Beh=C3=BAn > >=20 > > Print the wrong srcaddr (spl_image->offset) in error message also for > > SATA case. > >=20 > > Signed-off-by: Marek Beh=C3=BAn > > --- > > arch/arm/mach-mvebu/spl.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > >=20 > > diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c > > index af9e45ac7a..8c8cbc833f 100644 > > --- a/arch/arm/mach-mvebu/spl.c > > +++ b/arch/arm/mach-mvebu/spl.c > > @@ -190,7 +190,8 @@ int spl_parse_board_header(struct spl_image_info *s= pl_image, > > */ > > if (mhdr->blockid =3D=3D IBR_HDR_SATA_ID) { > > if (spl_image->offset < 1) { > > - printf("ERROR: Wrong SATA srcaddr in kwbimage\n"); > > + printf("ERROR: Wrong SATA srcaddr (%u) in kwbimage\n", =20 >=20 > Maybe change message to "ERROR: Wrong srcaddr (%u) in SATA kwbimage" for > consistency with other newly added error messages in this patch series? OK I'll send v3