From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DA97C433EF for ; Thu, 13 Jan 2022 01:54:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C167D834DC; Thu, 13 Jan 2022 02:52:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="IsKNjUeE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 81FB88350D; Thu, 13 Jan 2022 02:52:44 +0100 (CET) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7F9AA834B9 for ; Thu, 13 Jan 2022 02:52:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x830.google.com with SMTP id bp39so5297721qtb.6 for ; Wed, 12 Jan 2022 17:52:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uZ9OJRhheoLzOJubTf4r62J8o3H+osz19R1TOeKoFvM=; b=IsKNjUeEuXzg0vQVbv/pPnznevSo192ZsLeufUkBllidx+Zps3N05DCessxkYNVwBe 0/IPQaT5gILeEnUBOLk9puC3yj0mK6Gklp+3qQxYv1/GmrGe9p00BkCFjNcxN0AE2c9O YZmUpRd/yoX+HTqhWwdRMRvoPErl8ln0LQZWo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uZ9OJRhheoLzOJubTf4r62J8o3H+osz19R1TOeKoFvM=; b=B1OLVnamRtq7I9Fw0dYUQIWVH1DdWiXJ18l2jiODtT5I0XETsy3aM38+MEAaocKQ+b zpsVT7bl5KIeGj510ekOItiqJf4a4p9z+t66M5ouDNLBYI7NLHbYxvCaTzcLu8oZuntd lgoNdTyNWNJloQpKyu/huGojwUyzqxWEPT/RdbE3ohc3FAdCqF4QSnldhhPOw7PfuQkP YpRFMbS77xqCfYiggHed3bnuzU8nkbVwEDxAxu9rh2k/Ajy1AX/XX81vWIpjfWXuNyge JtnBQtlYDnk8S5y4hktxcMeo/uHJpW9jxJKJ9hz8xzu4RoyCs6mqbYhuSSqklvleYjca TzvA== X-Gm-Message-State: AOAM530ycyALYjmWjN/DkhWvWlx7aCVPyupVFAVgx/shpx8gd4zkA55O TG26VQlEc6Hkw9wG9R1m9cZvpQ== X-Google-Smtp-Source: ABdhPJzH6AuM/1PeiR50PykyWwsVgqgnkpGaXafcQy6fdlc309H3n5lL1656U/79iFC8MWFSEc8WyQ== X-Received: by 2002:ac8:7d8d:: with SMTP id c13mr1971916qtd.609.1642038756423; Wed, 12 Jan 2022 17:52:36 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2440-966a-5ce3-c6d0.res6.spectrum.com. [2603:6081:7b01:cbda:2440:966a:5ce3:c6d0]) by smtp.gmail.com with ESMTPSA id w63sm925216qkd.88.2022.01.12.17.52.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jan 2022 17:52:35 -0800 (PST) Date: Wed, 12 Jan 2022 20:52:34 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Stefan Roese , Simon Glass , Bin Meng , Marek Vasut , u-boot@lists.denx.de Subject: Re: [PATCH u-boot-next 12/12] pci: sh7751: Fix access to config space via PCI_CONF1_ADDRESS() macro Message-ID: <20220113015234.GA9207@bill-the-cat> References: <20211126104252.5443-1-pali@kernel.org> <20211126104252.5443-13-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DQpa7ozeLWh50je8" Content-Disposition: inline In-Reply-To: <20211126104252.5443-13-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --DQpa7ozeLWh50je8 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 26, 2021 at 11:42:52AM +0100, Pali Roh=E1r wrote: > sh7751 platform uses standard format of Config Address for PCI > Configuration Mechanism #1. >=20 > Commit 72c2f4acd76f ("pci: sh7751: Convert to DM and DT probing") which d= id > conversion of PCI sh7751 driver to DM, broke access to config space as th= at > commit somehow swapped device and function bits in config address. >=20 > Fix all these issues by using new U-Boot macro PCI_CONF1_ADDRESS() which > calculates Config Address correctly. >=20 > Also remove nonsense function sh7751_pci_addr_valid() which was introduced > in commit 72c2f4acd76f ("pci: sh7751: Convert to DM and DT probing") > probably due to workarounded issues with mixing/swapping device and > function bits of config address which probably resulted in non-working > access to some devices. With correct composing of config address there > should not be such issue anymore. >=20 > Signed-off-by: Pali Roh=E1r > Fixes: 72c2f4acd76f ("pci: sh7751: Convert to DM and DT probing") > Cc: Marek Vasut > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! --=20 Tom --DQpa7ozeLWh50je8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHfheIACgkQFHw5/5Y0 tyy3Kwv+J+DW9G8L5udx21WVWVaY5JS7zpOAQbJAHPLDjnABgSCPvHfzRV8i1iJE XR0DOrs/aJgDIEQcRUeTg/UuxVNFG4dBP8udPKXqWaHOa7tkXvmka2Z02DtMScAW XQGhjI3pBw+2yVQYrehiCxjGYYP3Tb5VRPA1W/WNLLKcT1DEaMnZirRFiLOQcyZN Y2oCwgB7yVTSUU03zwBGoujUkd9wLKUbMiUXBISYupEwECF7+n661QpIMHj/T+QH o14tpEzSMEAiPN+H9tIkbfpl4WJz6/mCunAODN0cFzKO4QhM39v48L7uDsgORjxZ qB2pDL03aHrES1igVAh4+pQJA0hAP1PsVscKINJ2W1qktoebe9wU3JqfqmZ3WbjV xLD7fb99UoDiomZDqYk4U+mM+xq4+GXFTakwTCmjlYfYCQF0SGLcQB0vLWkb6ahU ReA1cwNWDMlHOb6hkNfVRNSYUXLYeBmnLxSBKDUCvSbqfPsnLWGrSBk4q2uudbE4 ksShbqj8 =5ZDT -----END PGP SIGNATURE----- --DQpa7ozeLWh50je8--