* [PATCH 1/2] armv8: fsl-layerscape: Respect Kconfig for erratum A009007 @ 2022-02-22 18:38 Sean Anderson 2022-02-22 18:38 ` [PATCH 2/2] arm: layerscape: Disable erratum A009007 on LS1021A, LS1043A, and LS1046A Sean Anderson 0 siblings, 1 reply; 4+ messages in thread From: Sean Anderson @ 2022-02-22 18:38 UTC (permalink / raw) To: u-boot, Priyanka Jain Cc: Yinbo Zhu, Ran Wang, Prabhakar Kushwaha, Sean Anderson There is a Kconfig for this erratum, but it is ignored for armv8. Respect it. Signed-off-by: Sean Anderson <sean.anderson@seco.com> --- arch/arm/cpu/armv8/fsl-layerscape/soc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c b/arch/arm/cpu/armv8/fsl-layerscape/soc.c index d3a5cfaac1..926f8f21b6 100644 --- a/arch/arm/cpu/armv8/fsl-layerscape/soc.c +++ b/arch/arm/cpu/armv8/fsl-layerscape/soc.c @@ -206,6 +206,9 @@ static void erratum_a008997(void) static void erratum_a009007(void) { + if (!IS_ENABLED(CONFIG_SYS_FSL_ERRATUM_A009007)) + return; + #if defined(CONFIG_ARCH_LS1043A) || defined(CONFIG_ARCH_LS1046A) || \ defined(CONFIG_ARCH_LS1012A) void __iomem *usb_phy = (void __iomem *)SCFG_USB_PHY1; -- 2.25.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] arm: layerscape: Disable erratum A009007 on LS1021A, LS1043A, and LS1046A 2022-02-22 18:38 [PATCH 1/2] armv8: fsl-layerscape: Respect Kconfig for erratum A009007 Sean Anderson @ 2022-02-22 18:38 ` Sean Anderson 2022-04-19 19:31 ` Sean Anderson 0 siblings, 1 reply; 4+ messages in thread From: Sean Anderson @ 2022-02-22 18:38 UTC (permalink / raw) To: u-boot, Priyanka Jain Cc: Yinbo Zhu, Ran Wang, Prabhakar Kushwaha, Sean Anderson, Tom Rini This erratum is reported to cause problems on these processors [1-3]. The problem is usually with the clocking, which is supposed to be configured by the RCW [4]. However, if it is not set, or if the default clocking is not correct, then this erratum will cause an SError. However, according to Ran Wang in [1]: > ... this erratum is used to pass USB compliance test only, you could > disable this workaround on your board if you don't any USB issue on > normal use case, I think it's fine. So just disable this erratum by default for these processors. [1] https://lore.kernel.org/all/761ddd61-05c1-d9b8-ac90-b8f425afde6c@denx.de/ [2] https://community.nxp.com/t5/Layerscape/LS1046A-U-BOOT-HALT-AT-ERRATUM-A0090078/m-p/742993 [3] https://community.nxp.com/t5/QorIQ/Why-does-the-LS1043A-U-Boot-hang-at-code-that-fixes-erratum/m-p/644412 [4] https://source.codeaurora.org/external/qoriq/qoriq-components/rcw/tree/ls1046ardb/usb_phy_freq.rcw Signed-off-by: Sean Anderson <sean.anderson@seco.com> --- arch/arm/cpu/armv7/ls102xa/Kconfig | 1 - arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 2 -- 2 files changed, 3 deletions(-) diff --git a/arch/arm/cpu/armv7/ls102xa/Kconfig b/arch/arm/cpu/armv7/ls102xa/Kconfig index 6a948d7ba7..cec93a27db 100644 --- a/arch/arm/cpu/armv7/ls102xa/Kconfig +++ b/arch/arm/cpu/armv7/ls102xa/Kconfig @@ -7,7 +7,6 @@ config ARCH_LS1021A select SYS_FSL_ERRATUM_A008407 select SYS_FSL_ERRATUM_A008850 select SYS_FSL_ERRATUM_A008997 if USB - select SYS_FSL_ERRATUM_A009007 if USB select SYS_FSL_ERRATUM_A009008 if USB select SYS_FSL_ERRATUM_A009663 select SYS_FSL_ERRATUM_A009798 if USB diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig index 9bb870dcd8..f5a18053e6 100644 --- a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig +++ b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig @@ -74,7 +74,6 @@ config ARCH_LS1043A select SYS_FSL_DDR_VER_50 select SYS_FSL_ERRATUM_A008850 if !TFABOOT select SYS_FSL_ERRATUM_A008997 - select SYS_FSL_ERRATUM_A009007 select SYS_FSL_ERRATUM_A009008 select SYS_FSL_ERRATUM_A009660 if !TFABOOT select SYS_FSL_ERRATUM_A009663 if !TFABOOT @@ -112,7 +111,6 @@ config ARCH_LS1046A select SYS_FSL_ERRATUM_A008511 if !TFABOOT select SYS_FSL_ERRATUM_A008850 if !TFABOOT select SYS_FSL_ERRATUM_A008997 - select SYS_FSL_ERRATUM_A009007 select SYS_FSL_ERRATUM_A009008 select SYS_FSL_ERRATUM_A009798 select SYS_FSL_ERRATUM_A009801 -- 2.25.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] arm: layerscape: Disable erratum A009007 on LS1021A, LS1043A, and LS1046A 2022-02-22 18:38 ` [PATCH 2/2] arm: layerscape: Disable erratum A009007 on LS1021A, LS1043A, and LS1046A Sean Anderson @ 2022-04-19 19:31 ` Sean Anderson 2022-04-20 2:22 ` Ran Wang 0 siblings, 1 reply; 4+ messages in thread From: Sean Anderson @ 2022-04-19 19:31 UTC (permalink / raw) To: u-boot, Priyanka Jain; +Cc: Yinbo Zhu, Ran Wang, Prabhakar Kushwaha, Tom Rini On 2/22/22 1:38 PM, Sean Anderson wrote: > This erratum is reported to cause problems on these processors [1-3]. > The problem is usually with the clocking, which is supposed to be > configured by the RCW [4]. However, if it is not set, or if the default > clocking is not correct, then this erratum will cause an SError. > However, according to Ran Wang in [1]: > >> ... this erratum is used to pass USB compliance test only, you could >> disable this workaround on your board if you don't any USB issue on >> normal use case, I think it's fine. > > So just disable this erratum by default for these processors. > > [1] https://lore.kernel.org/all/761ddd61-05c1-d9b8-ac90-b8f425afde6c@denx.de/ > [2] https://community.nxp.com/t5/Layerscape/LS1046A-U-BOOT-HALT-AT-ERRATUM-A0090078/m-p/742993 > [3] https://community.nxp.com/t5/QorIQ/Why-does-the-LS1043A-U-Boot-hang-at-code-that-fixes-erratum/m-p/644412 > [4] https://source.codeaurora.org/external/qoriq/qoriq-components/rcw/tree/ls1046ardb/usb_phy_freq.rcw > > Signed-off-by: Sean Anderson <sean.anderson@seco.com> > --- > > arch/arm/cpu/armv7/ls102xa/Kconfig | 1 - > arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 2 -- > 2 files changed, 3 deletions(-) > > diff --git a/arch/arm/cpu/armv7/ls102xa/Kconfig b/arch/arm/cpu/armv7/ls102xa/Kconfig > index 6a948d7ba7..cec93a27db 100644 > --- a/arch/arm/cpu/armv7/ls102xa/Kconfig > +++ b/arch/arm/cpu/armv7/ls102xa/Kconfig > @@ -7,7 +7,6 @@ config ARCH_LS1021A > select SYS_FSL_ERRATUM_A008407 > select SYS_FSL_ERRATUM_A008850 > select SYS_FSL_ERRATUM_A008997 if USB > - select SYS_FSL_ERRATUM_A009007 if USB > select SYS_FSL_ERRATUM_A009008 if USB > select SYS_FSL_ERRATUM_A009663 > select SYS_FSL_ERRATUM_A009798 if USB > diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig > index 9bb870dcd8..f5a18053e6 100644 > --- a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig > +++ b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig > @@ -74,7 +74,6 @@ config ARCH_LS1043A > select SYS_FSL_DDR_VER_50 > select SYS_FSL_ERRATUM_A008850 if !TFABOOT > select SYS_FSL_ERRATUM_A008997 > - select SYS_FSL_ERRATUM_A009007 > select SYS_FSL_ERRATUM_A009008 > select SYS_FSL_ERRATUM_A009660 if !TFABOOT > select SYS_FSL_ERRATUM_A009663 if !TFABOOT > @@ -112,7 +111,6 @@ config ARCH_LS1046A > select SYS_FSL_ERRATUM_A008511 if !TFABOOT > select SYS_FSL_ERRATUM_A008850 if !TFABOOT > select SYS_FSL_ERRATUM_A008997 > - select SYS_FSL_ERRATUM_A009007 > select SYS_FSL_ERRATUM_A009008 > select SYS_FSL_ERRATUM_A009798 > select SYS_FSL_ERRATUM_A009801 > ping? Can someone from NXP comment on this (either for or against)? --Sean ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 2/2] arm: layerscape: Disable erratum A009007 on LS1021A, LS1043A, and LS1046A 2022-04-19 19:31 ` Sean Anderson @ 2022-04-20 2:22 ` Ran Wang 0 siblings, 0 replies; 4+ messages in thread From: Ran Wang @ 2022-04-20 2:22 UTC (permalink / raw) To: Sean Anderson, u-boot, Priyanka Jain Cc: Yinbo Zhu, Prabhakar Kushwaha, Tom Rini, Jun Li, Jason Liu, Xiaobo Xie Hi Sean, > -----Original Message----- > From: Sean Anderson <sean.anderson@seco.com> > Sent: Wednesday, April 20, 2022 3:32 AM > To: u-boot@lists.denx.de; Priyanka Jain <priyanka.jain@nxp.com> > Cc: Yinbo Zhu <yinbo.zhu@nxp.com>; Ran Wang <ran.wang_1@nxp.com>; Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Tom > Rini <trini@konsulko.com> > Subject: Re: [PATCH 2/2] arm: layerscape: Disable erratum A009007 on LS1021A, LS1043A, and LS1046A > > On 2/22/22 1:38 PM, Sean Anderson wrote: > > This erratum is reported to cause problems on these processors [1-3]. > > The problem is usually with the clocking, which is supposed to be > > configured by the RCW [4]. However, if it is not set, or if the > > default clocking is not correct, then this erratum will cause an SError. > > However, according to Ran Wang in [1]: > > > >> ... this erratum is used to pass USB compliance test only, you could > >> disable this workaround on your board if you don't any USB issue on > >> normal use case, I think it's fine. > > > > So just disable this erratum by default for these processors. > > > > [1] > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore > > .kernel.org%2Fall%2F761ddd61-05c1-d9b8-ac90-b8f425afde6c%40denx.de%2F& > > amp;data=05%7C01%7Cran.wang_1%40nxp.com%7C3a19547d54eb46a572cc08da223b > > 3cff%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637859935071826709%7 > > CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1 > > haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=0QLVw7ZIW9SYBrTqtCIfFClz > > eA63jn72oAMlw18Y6FA%3D&reserved=0 > > [2] > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcomm > > unity.nxp.com%2Ft5%2FLayerscape%2FLS1046A-U-BOOT-HALT-AT-ERRATUM-A0090 > > 078%2Fm-p%2F742993&data=05%7C01%7Cran.wang_1%40nxp.com%7C3a19547d5 > > 4eb46a572cc08da223b3cff%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6 > > 37859935071826709%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoi > > V2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=dTV6k > > AUn%2BqNDzdXEoEb0EwJEzqbTcFBVFeFpy3XbcnM%3D&reserved=0 > > [3] > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcomm > > unity.nxp.com%2Ft5%2FQorIQ%2FWhy-does-the-LS1043A-U-Boot-hang-at-code- > > that-fixes-erratum%2Fm-p%2F644412&data=05%7C01%7Cran.wang_1%40nxp. > > com%7C3a19547d54eb46a572cc08da223b3cff%7C686ea1d3bc2b4c6fa92cd99c5c301 > > 635%7C0%7C0%7C637859935071826709%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wL > > jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C& > > amp;sdata=5xJd%2BrKCd8b%2Ft8AovVisDuLAsg%2B7aJz%2FA4wZp7echB0%3D&r > > eserved=0 [4] > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsour > > ce.codeaurora.org%2Fexternal%2Fqoriq%2Fqoriq-components%2Frcw%2Ftree%2 > > Fls1046ardb%2Fusb_phy_freq.rcw&data=05%7C01%7Cran.wang_1%40nxp.com > > %7C3a19547d54eb46a572cc08da223b3cff%7C686ea1d3bc2b4c6fa92cd99c5c301635 > > %7C0%7C0%7C637859935071826709%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw > > MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C& > > ;sdata=I9mZiTLAofR7%2F0aWsLvOGoI%2B9xEDhPmRJADbBOZiwwU%3D&reserved > > =0 > > > > Signed-off-by: Sean Anderson <sean.anderson@seco.com> Acked-by: Ran Wang <ran.wang_1@nxp.com> > > --- > > > > arch/arm/cpu/armv7/ls102xa/Kconfig | 1 - > > arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 2 -- > > 2 files changed, 3 deletions(-) > > > > diff --git a/arch/arm/cpu/armv7/ls102xa/Kconfig > > b/arch/arm/cpu/armv7/ls102xa/Kconfig > > index 6a948d7ba7..cec93a27db 100644 > > --- a/arch/arm/cpu/armv7/ls102xa/Kconfig > > +++ b/arch/arm/cpu/armv7/ls102xa/Kconfig > > @@ -7,7 +7,6 @@ config ARCH_LS1021A > > select SYS_FSL_ERRATUM_A008407 > > select SYS_FSL_ERRATUM_A008850 > > select SYS_FSL_ERRATUM_A008997 if USB > > - select SYS_FSL_ERRATUM_A009007 if USB > > select SYS_FSL_ERRATUM_A009008 if USB > > select SYS_FSL_ERRATUM_A009663 > > select SYS_FSL_ERRATUM_A009798 if USB diff --git > > a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig > > b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig > > index 9bb870dcd8..f5a18053e6 100644 > > --- a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig > > +++ b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig > > @@ -74,7 +74,6 @@ config ARCH_LS1043A > > select SYS_FSL_DDR_VER_50 > > select SYS_FSL_ERRATUM_A008850 if !TFABOOT > > select SYS_FSL_ERRATUM_A008997 > > - select SYS_FSL_ERRATUM_A009007 > > select SYS_FSL_ERRATUM_A009008 > > select SYS_FSL_ERRATUM_A009660 if !TFABOOT > > select SYS_FSL_ERRATUM_A009663 if !TFABOOT @@ -112,7 +111,6 @@ > > config ARCH_LS1046A > > select SYS_FSL_ERRATUM_A008511 if !TFABOOT > > select SYS_FSL_ERRATUM_A008850 if !TFABOOT > > select SYS_FSL_ERRATUM_A008997 > > - select SYS_FSL_ERRATUM_A009007 > > select SYS_FSL_ERRATUM_A009008 > > select SYS_FSL_ERRATUM_A009798 > > select SYS_FSL_ERRATUM_A009801 > > > > ping? Can someone from NXP comment on this (either for or against)? I am not longer take USB ownership for Layerscape platforms. Please also include my colleague Jun for any further review. Thanks & Regards, Ran ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-20 2:22 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-02-22 18:38 [PATCH 1/2] armv8: fsl-layerscape: Respect Kconfig for erratum A009007 Sean Anderson 2022-02-22 18:38 ` [PATCH 2/2] arm: layerscape: Disable erratum A009007 on LS1021A, LS1043A, and LS1046A Sean Anderson 2022-04-19 19:31 ` Sean Anderson 2022-04-20 2:22 ` Ran Wang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).