From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A9D0C433F5 for ; Mon, 14 Mar 2022 18:15:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2DDE783BDE; Mon, 14 Mar 2022 19:14:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="jUQ0ird2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 07B2183B9E; Mon, 14 Mar 2022 19:14:37 +0100 (CET) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3F13683B9F for ; Mon, 14 Mar 2022 19:14:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x733.google.com with SMTP id c7so13488528qka.7 for ; Mon, 14 Mar 2022 11:14:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nabvz11zWZjINBOHL8LMarDeuHWu3EZ+slVaOE81Up4=; b=jUQ0ird2FQLlvYR+YoMpXe/UcC0vfsoZC5IyAhFsqDtdwKmNIDzQrReZQamEfROPhZ T7ztEcLHx6QMeKbAdzLySO4BvvSwSpZNiqEhjvo6SXJqKMfqHBGzE9TUwPDrB9+dcT09 dQ0OUThB2I0xypS4DA4r5TXWcDkKilpsYF6W8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nabvz11zWZjINBOHL8LMarDeuHWu3EZ+slVaOE81Up4=; b=YfE2QvlDavGCIhJUO+9MyipT2pSpf10Cs79s+SMPFhDE+PPtXn6rQHXwMHQc2LFK+X X+GCyvriMs3She3Qa+5dxxLh1GvBLmAFvbKFBpVJj1TXlKUAUO8RxFj3n2nTisWHAfR3 dSzA2bKKntG2ZBxWJ8y9h1D9qnJocO3VHwT0BS/GHwojQuio5kXCDSoAQ+1s7Xq8Wdoi aBTJ3h46ZUiBMdxcwUvQQwmceDPxsYQl+MXbkiHu9UWfXfGMM57hnzC6wWtR3NNqHnNV oVuhA/v9/mdTEQZesujlZNRGJfbhHYExMP7mKX/Sf1AdcBKnHS+l/6MS8HoNQUxYJq5r xydw== X-Gm-Message-State: AOAM533dcQmvbT+tEEWuToSL/GcfcTQrQYV87id1deGigomEr6wyRIwc 2ZmXZGoOupUkev3xCZ8r2YZfYw== X-Google-Smtp-Source: ABdhPJzl7JHvIB1By2IVDPS76SXwd/Y52j4F0cZ5UPKbzMLdgYiW5CeZVLmS+ulgfxJKGE1NTKaSRA== X-Received: by 2002:a05:620a:2844:b0:67d:29ea:210f with SMTP id h4-20020a05620a284400b0067d29ea210fmr15842489qkp.332.1647281668033; Mon, 14 Mar 2022 11:14:28 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id bm1-20020a05620a198100b0047bf910892bsm8239242qkb.65.2022.03.14.11.14.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Mar 2022 11:14:27 -0700 (PDT) Date: Mon, 14 Mar 2022 14:14:25 -0400 From: Tom Rini To: Andre Przywara Cc: Liviu Dudau , Linus Walleij , Peter Hoyes , Simon Glass , u-boot@lists.denx.de, Sean Anderson Subject: Re: [PATCH 01/11] vexpress64: fvp: Fix automatic boot Message-ID: <20220314181425.GI9986@bill-the-cat> References: <20220304163018.3167841-1-andre.przywara@arm.com> <20220304163018.3167841-2-andre.przywara@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pmKUVAsxJ35RhmJn" Content-Disposition: inline In-Reply-To: <20220304163018.3167841-2-andre.przywara@arm.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --pmKUVAsxJ35RhmJn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 04, 2022 at 04:30:08PM +0000, Andre Przywara wrote: > Commit 90f262a6951f ("vexpress64: Clean up BASE_FVP boot configuration") > cleaned up the usage of default address variables, but missed to update > the address for the kernel in the FVP's bootcmd definition. >=20 > Change ${kernel_addr} to read ${kernel_addr_r} to bring back the > automated boot for the fastmodel. > Also use "setenv" instead of the potentially ambiguous "set" on the way. >=20 > Fixes: 90f262a6951f ("vexpress64: Clean up BASE_FVP boot configuration") > Signed-off-by: Andre Przywara Applied to u-boot/master, thanks! --=20 Tom --pmKUVAsxJ35RhmJn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmIvhgEACgkQFHw5/5Y0 tywCZgv/TsaCIJ2apZupO1HshVjiq9ZEbKnrc+UEQw0Pl3GnYDLw+VyK4zm3Frdg LE2GqlhxbiI/sqGKYqZR9KUohlBFB+ft7TCkNWorNjMZ5hKk9wCfgIiBXWMrEh6K QY5qat2iZIGqOCG+2FrzYpDbl4l2M0rE7OPibq45wom1TXxsk5TPgEB1wq7g+Fg3 m1XgHNrmoNFHFiHmXJawFHaPRaFM3utQ7M9eeu0Xi838V21u9GsCDpFg9u/YyG9P lv0aFy5cJOFKX/Udmwt6sAZzLO0pooFlgn5MSquPoM8BCGf5n2bVh/UIr2AwmAd3 xpWU12h3fsmmfsldaxuzKCMN/mluq0z61Bx4j6oo4H2eohKHJ+dtrRMWKfH3H+Vo 2DJz75bcF7QwULzN1mkJUm/bvBS4dYM4qIQ3pcQ3brhSPmRHOiU8al2I5VNVozIg 1ivxNk6bP6bO9zgmCZViT9bIFufg9rgri+eGpei6gKG/jr4mTzobFDJcweg8h8Rq BGTrfqoI =TdF0 -----END PGP SIGNATURE----- --pmKUVAsxJ35RhmJn--