From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA9DDC433F5 for ; Wed, 18 May 2022 08:07:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BC42B83961; Wed, 18 May 2022 10:07:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="jGeOMpww"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1305183922; Wed, 18 May 2022 10:07:33 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0EB9A839AA for ; Wed, 18 May 2022 10:07:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kabel@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E45F261530; Wed, 18 May 2022 08:07:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D90DEC385AA; Wed, 18 May 2022 08:07:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652861247; bh=KT0R05Cz0+ZeVHwVvFDV6F/1APw9iIaQWCsBjHF9LuY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jGeOMpwwD3BtIBa3lzaUlzt7C28QbaKkjp4HQI7NUtxPdhc/waqksZxthLJeQ4G8u oSvZpijxqHq7YfdWcja+u1WS68cYh7OPD60ie8Sx6wv/sOhuCD24NUMfIVaXGJ0FR6 /PSEm/UgDXv6B1naBD6g+ieit79cgRdAJg0KFREgZr76gBHr2wnmwFr0nioS0UDxly n78zRz+wZmSspHXqRkjzZYi0ky0n226kAqFMfeU2nXnvz6/xzlpyvqcOKx5CpWojZH MLV48OqU8W1DgAEApCpDAJVhzxFncA5auPOUoix0CIJGusbQlqu08e6wm9tanaKi+P GnYkO16JV8O1w== Date: Wed, 18 May 2022 10:07:22 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Chris Packham Cc: Tom Rini , u-boot , Marek Vasut , Stefan Roese , Marek =?UTF-8?B?QmVo?= =?UTF-8?B?w7pu?= Subject: Re: [PATCH 4/4] Convert CONFIG_USB_EHCI_IS_TDI to Kconfig Message-ID: <20220518100722.5bc1a46b@thinkpad> In-Reply-To: References: <20211009132735.5173-1-kabel@kernel.org> <20211009132735.5173-4-kabel@kernel.org> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Wed, 18 May 2022 16:44:32 +1200 Chris Packham wrote: > Hi Marek, >=20 > On Sun, Oct 10, 2021 at 2:28 AM Marek Beh=C3=BAn wrote: > > > > From: Marek Beh=C3=BAn > > > > On mvebu this is defined if and only if !ARM64. > > =20 >=20 > I'm working on a 64-bit MVEBU board which I'll hopefully be submitting > soon (just getting the Linux stuff sorted first). Was there any > particular reason you added the !ARM64 ? My board appears to need > CONFIG_USB_EHCI_IS_TDI=3Dy. I can make the condition more complicated if > necessary but it might just be easier to remove the !ARM64. It was because only arm32 boards defined it in the config headers when I was converting. So I converted it so that Kconfig selected that if !ARM64. > > Otherwise it is defined for boards with ARCH_MX23, ARCH_TEGRA and > > ARCH_ZYNQ, and also for SOC_AR934X (tplink_wdr4300). > > > > Signed-off-by: Marek Beh=C3=BAn > > --- =20 >=20 > >=20 > > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig > > index be5e4b994d..ccecb5a3b0 100644 > > --- a/drivers/usb/host/Kconfig > > +++ b/drivers/usb/host/Kconfig > > @@ -139,6 +139,9 @@ config USB_EHCI_HCD > > > > if USB_EHCI_HCD > > > > +config USB_EHCI_IS_TDI > > + bool > > + > > config USB_EHCI_ATMEL > > bool "Support for Atmel on-chip EHCI USB controller" > > depends on ARCH_AT91 > > @@ -150,6 +153,7 @@ config USB_EHCI_MARVELL > > bool "Support for Marvell on-chip EHCI USB controller" > > depends on ARCH_MVEBU || ARCH_KIRKWOOD || ARCH_ORION5X > > default y > > + select USB_EHCI_IS_TDI if !ARM64 =20 >=20 > Here I'm thinking about something like if !ARM64 || ALLEYCAT_5 Sure, if you need this, do this. Just make sure it does not get selected for boards that don't need it. Marek