u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Alper Nebi Yasak <alpernebiyasak@gmail.com>
To: u-boot@lists.denx.de
Cc: "Michael Walle" <michael@walle.cc>, "Wolfgang Denk" <wd@denx.de>,
	"Marek Vasut" <marex@denx.de>,
	"Ricardo Salveti" <ricardo@foundries.io>,
	"Patrick Delaunay" <patrick.delaunay@foss.st.com>,
	"Heiko Thiery" <heiko.thiery@gmail.com>,
	"Stefan Roese" <sr@denx.de>, "Peng Fan" <peng.fan@nxp.com>,
	"Philippe Reynes" <philippe.reynes@softathome.com>,
	"Marek Behún" <marek.behun@nic.cz>,
	"Tom Rini" <trini@konsulko.com>, "Simon Glass" <sjg@chromium.org>,
	"Oleksandr Suvorov" <oleksandr.suvorov@foundries.io>,
	"Ovidiu Panait" <ovidiu.panait@windriver.com>,
	"Heiko Schocher" <hs@denx.de>,
	"Alexandru Gagniuc" <mr.nuke.me@gmail.com>,
	"Andre Przywara" <andre.przywara@arm.com>,
	"Pali Rohár" <pali@kernel.org>,
	"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
	"Alper Nebi Yasak" <alpernebiyasak@gmail.com>
Subject: [PATCH v2 7/8] spl: binman: Disable u_boot_any symbols for i.MX8M boards
Date: Sat, 18 Jun 2022 15:13:12 +0300	[thread overview]
Message-ID: <20220618121316.12061-8-alpernebiyasak@gmail.com> (raw)
In-Reply-To: <20220618121316.12061-1-alpernebiyasak@gmail.com>

The i.MX8M boards use partially specified binman images which have an
SPL entry without a U-Boot entry. This would normally cause an error due
to the 'u_boot_any' binman symbols declared by BINMAN_UBOOT_SYMBOLS
requiring a U-Boot-like entry in the same image as the SPL.

However, a problem in the ARMv8 __image_copy_start symbol definition
effectively disables binman from attempting to write any symbols at all,
so everything appears to work fine until runtime. A future patch fixes
the issue in the linker scripts, which lets binman fill in the symbols,
which would result in the build error described above.

Explicitly disable the 'u_boot_any' symbols for i.MX8M boards. They are
already effectively unusable, and they are incompatible with the boards'
current binman image descriptions.

Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
---

Changes in v2:
- Add new patch to disable u_boot_any symbols for i.MX8M boards

 common/spl/Kconfig     | 1 +
 common/spl/Kconfig.tpl | 1 +
 common/spl/Kconfig.vpl | 1 +
 3 files changed, 3 insertions(+)

diff --git a/common/spl/Kconfig b/common/spl/Kconfig
index 46d9be73bb1f..152569ee4350 100644
--- a/common/spl/Kconfig
+++ b/common/spl/Kconfig
@@ -200,6 +200,7 @@ config SPL_BINMAN_SYMBOLS
 config SPL_BINMAN_UBOOT_SYMBOLS
 	bool "Declare binman symbols for U-Boot phases in SPL"
 	depends on SPL_BINMAN_SYMBOLS
+	default n if ARCH_IMX8M
 	default y
 	help
 	  This enables use of symbols in SPL which refer to U-Boot phases,
diff --git a/common/spl/Kconfig.tpl b/common/spl/Kconfig.tpl
index 8c59c767302f..e314b793a2e9 100644
--- a/common/spl/Kconfig.tpl
+++ b/common/spl/Kconfig.tpl
@@ -23,6 +23,7 @@ config TPL_BINMAN_SYMBOLS
 config TPL_BINMAN_UBOOT_SYMBOLS
 	bool "Declare binman symbols for U-Boot phases in TPL"
 	depends on TPL_BINMAN_SYMBOLS
+	default n if ARCH_IMX8M
 	default y
 	help
 	  This enables use of symbols in TPL which refer to U-Boot phases,
diff --git a/common/spl/Kconfig.vpl b/common/spl/Kconfig.vpl
index daec0bb7bfff..ba4b2e4f99e9 100644
--- a/common/spl/Kconfig.vpl
+++ b/common/spl/Kconfig.vpl
@@ -213,6 +213,7 @@ config VPL_BINMAN_SYMBOLS
 config VPL_BINMAN_UBOOT_SYMBOLS
 	bool "Declare binman symbols for U-Boot phases in VPL"
 	depends on VPL_BINMAN_SYMBOLS
+	default n if ARCH_IMX8M
 	default y
 	help
 	  This enables use of symbols in VPL which refer to U-Boot phases,
-- 
2.36.1


  parent reply	other threads:[~2022-06-18 12:15 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-18 12:13 [PATCH v2 0/8] spl: binman: Fixes for BINMAN_SYMBOLS Alper Nebi Yasak
2022-06-18 12:13 ` [PATCH v2 1/8] spl: binman: Fix use of undeclared u_boot_any symbols Alper Nebi Yasak
2022-06-18 12:13 ` [PATCH v2 2/8] spl: binman: Make TPL_BINMAN_SYMBOLS depend on TPL_FRAMEWORK Alper Nebi Yasak
2022-06-18 12:13 ` [PATCH v2 3/8] spl: binman: Declare extern symbols for VPL as well Alper Nebi Yasak
2022-06-18 12:13 ` [PATCH v2 4/8] spl: binman: Split binman symbols support from enabling binman Alper Nebi Yasak
2022-06-18 12:13 ` [PATCH v2 5/8] spl: binman: Add config options for binman symbols in VPL Alper Nebi Yasak
2022-06-18 12:13 ` [PATCH v2 6/8] spl: binman: Check at runtime if binman symbols were filled in Alper Nebi Yasak
2022-06-18 12:13 ` Alper Nebi Yasak [this message]
2022-06-18 12:13 ` [PATCH v2 8/8] armv8: u-boot-spl.lds: mark __image_copy_start as symbol Alper Nebi Yasak
2022-06-23  3:00 ` [PATCH v2 0/8] spl: binman: Fixes for BINMAN_SYMBOLS Peng Fan (OSS)
2022-06-24 15:01   ` Alper Nebi Yasak
2022-06-27 13:19 ` Frieder Schrempf
2022-06-28 13:37 ` [PATCH v2 7/8] spl: binman: Disable u_boot_any symbols for i.MX8M boards Simon Glass
2022-06-28 13:37 ` [PATCH v2 8/8] armv8: u-boot-spl.lds: mark __image_copy_start as symbol Simon Glass
2022-06-28 13:37 ` [PATCH v2 6/8] spl: binman: Check at runtime if binman symbols were filled in Simon Glass
2022-06-28 13:37 ` [PATCH v2 5/8] spl: binman: Add config options for binman symbols in VPL Simon Glass
2022-06-28 13:37 ` [PATCH v2 4/8] spl: binman: Split binman symbols support from enabling binman Simon Glass
2022-06-28 13:37 ` [PATCH v2 3/8] spl: binman: Declare extern symbols for VPL as well Simon Glass
2022-06-28 13:37 ` [PATCH v2 2/8] spl: binman: Make TPL_BINMAN_SYMBOLS depend on TPL_FRAMEWORK Simon Glass
2022-06-28 13:37 ` [PATCH v2 1/8] spl: binman: Fix use of undeclared u_boot_any symbols Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220618121316.12061-8-alpernebiyasak@gmail.com \
    --to=alpernebiyasak@gmail.com \
    --cc=andre.przywara@arm.com \
    --cc=heiko.thiery@gmail.com \
    --cc=hs@denx.de \
    --cc=marek.behun@nic.cz \
    --cc=marex@denx.de \
    --cc=michael@walle.cc \
    --cc=mr.nuke.me@gmail.com \
    --cc=oleksandr.suvorov@foundries.io \
    --cc=ovidiu.panait@windriver.com \
    --cc=pali@kernel.org \
    --cc=patrick.delaunay@foss.st.com \
    --cc=peng.fan@nxp.com \
    --cc=philippe.reynes@softathome.com \
    --cc=ricardo@foundries.io \
    --cc=sjg@chromium.org \
    --cc=sr@denx.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=wd@denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).